Re: [ANNOUNCE] Haisheng Yuan joins Calcite PMC

2019-11-11 Thread Matt Wang
Congratulations!


---
Best,
Matt Wang


On 11/12/2019 12:36,Haisheng Yuan wrote:
Thanks, all!

It's my great honour to be a member of Apache Calcite project. Let's 
collaborate to continue working on it and make it better.

Thanks again.
- Haisheng

--
发件人:XING JIN
日 期:2019年11月12日 10:20:16
收件人:
主 题:Re: [ANNOUNCE] Haisheng Yuan joins Calcite PMC

Congratulations Haisheng ~
You well deserved !

Kevin Risden  于2019年11月12日周二 上午3:13写道:

Congrats and welcome!

Kevin Risden


On Mon, Nov 11, 2019 at 2:10 PM Chunhui Shi  wrote:

Congratulations!

On Mon, Nov 11, 2019 at 10:09 AM Jinfeng Ni  wrote:

Congratulations!


On Tue, Nov 12, 2019 at 1:23 AM Rui Wang  wrote:

Congrats HaiSheng!


-Rui

On Mon, Nov 11, 2019 at 8:05 AM Stamatis Zampetakis <
zabe...@gmail.com

wrote:

Congrats Haisheng!

Reviews, code contributions, design discussions, helping users, and
many
more things for improving the project.

Personally, I also learn a lot from our interactions.

All these are much appreciated; keep it up!!

Best,
Stamatis

On Mon, Nov 11, 2019, 4:17 PM Michael Mior 
wrote:

Welcome and congratulations HaiSheng!
--
Michael Mior
mm...@apache.org

Le dim. 10 nov. 2019 à 22:45, Francis Chuang
 a écrit :

I'm pleased to announce that Haisheng has accepted an
invitation
to
join the Calcite PMC. Haisheng has been a consistent and
helpful
figure in the Calcite community for which we are very grateful.
We
look forward to the continued contributions and support.

Please join me in congratulating Haisheng!

- Francis (on behalf of the Calcite PMC)








Re: Re: [ANNOUNCE] Haisheng Yuan joins Calcite PMC

2019-11-11 Thread Haisheng Yuan
Thanks, all!

It's my great honour to be a member of Apache Calcite project. Let's 
collaborate to continue working on it and make it better.

Thanks again.
- Haisheng

--
发件人:XING JIN
日 期:2019年11月12日 10:20:16
收件人:
主 题:Re: [ANNOUNCE] Haisheng Yuan joins Calcite PMC

Congratulations Haisheng ~
You well deserved !

Kevin Risden  于2019年11月12日周二 上午3:13写道:

> Congrats and welcome!
>
> Kevin Risden
>
>
> On Mon, Nov 11, 2019 at 2:10 PM Chunhui Shi  wrote:
>
> > Congratulations!
> >
> > On Mon, Nov 11, 2019 at 10:09 AM Jinfeng Ni  wrote:
> >
> > > Congratulations!
> > >
> > >
> > > On Tue, Nov 12, 2019 at 1:23 AM Rui Wang  wrote:
> > > >
> > > > Congrats HaiSheng!
> > > >
> > > >
> > > > -Rui
> > > >
> > > > On Mon, Nov 11, 2019 at 8:05 AM Stamatis Zampetakis <
> zabe...@gmail.com
> > >
> > > > wrote:
> > > >
> > > > > Congrats Haisheng!
> > > > >
> > > > > Reviews, code contributions, design discussions, helping users, and
> > > many
> > > > > more things for improving the project.
> > > > >
> > > > > Personally, I also learn a lot from our interactions.
> > > > >
> > > > > All these are much appreciated; keep it up!!
> > > > >
> > > > > Best,
> > > > > Stamatis
> > > > >
> > > > > On Mon, Nov 11, 2019, 4:17 PM Michael Mior 
> wrote:
> > > > >
> > > > > > Welcome and congratulations HaiSheng!
> > > > > > --
> > > > > > Michael Mior
> > > > > > mm...@apache.org
> > > > > >
> > > > > > Le dim. 10 nov. 2019 à 22:45, Francis Chuang
> > > > > >  a écrit :
> > > > > > >
> > > > > > > I'm pleased to announce that Haisheng has accepted an
> invitation
> > to
> > > > > > > join the Calcite PMC. Haisheng has been a consistent and
> helpful
> > > > > > > figure in the Calcite community for which we are very grateful.
> > We
> > > > > > > look forward to the continued contributions and support.
> > > > > > >
> > > > > > > Please join me in congratulating Haisheng!
> > > > > > >
> > > > > > > - Francis (on behalf of the Calcite PMC)
> > > > > >
> > > > >
> > >
> >
>



Re: [ANNOUNCE] Haisheng Yuan joins Calcite PMC

2019-11-11 Thread XING JIN
Congratulations Haisheng ~
You well deserved !

Kevin Risden  于2019年11月12日周二 上午3:13写道:

> Congrats and welcome!
>
> Kevin Risden
>
>
> On Mon, Nov 11, 2019 at 2:10 PM Chunhui Shi  wrote:
>
> > Congratulations!
> >
> > On Mon, Nov 11, 2019 at 10:09 AM Jinfeng Ni  wrote:
> >
> > > Congratulations!
> > >
> > >
> > > On Tue, Nov 12, 2019 at 1:23 AM Rui Wang  wrote:
> > > >
> > > > Congrats HaiSheng!
> > > >
> > > >
> > > > -Rui
> > > >
> > > > On Mon, Nov 11, 2019 at 8:05 AM Stamatis Zampetakis <
> zabe...@gmail.com
> > >
> > > > wrote:
> > > >
> > > > > Congrats Haisheng!
> > > > >
> > > > > Reviews, code contributions, design discussions, helping users, and
> > > many
> > > > > more things for improving the project.
> > > > >
> > > > > Personally, I also learn a lot from our interactions.
> > > > >
> > > > > All these are much appreciated; keep it up!!
> > > > >
> > > > > Best,
> > > > > Stamatis
> > > > >
> > > > > On Mon, Nov 11, 2019, 4:17 PM Michael Mior 
> wrote:
> > > > >
> > > > > > Welcome and congratulations HaiSheng!
> > > > > > --
> > > > > > Michael Mior
> > > > > > mm...@apache.org
> > > > > >
> > > > > > Le dim. 10 nov. 2019 à 22:45, Francis Chuang
> > > > > >  a écrit :
> > > > > > >
> > > > > > > I'm pleased to announce that Haisheng has accepted an
> invitation
> > to
> > > > > > > join the Calcite PMC. Haisheng has been a consistent and
> helpful
> > > > > > > figure in the Calcite community for which we are very grateful.
> > We
> > > > > > > look forward to the continued contributions and support.
> > > > > > >
> > > > > > > Please join me in congratulating Haisheng!
> > > > > > >
> > > > > > > - Francis (on behalf of the Calcite PMC)
> > > > > >
> > > > >
> > >
> >
>


[jira] [Created] (CALCITE-3493) Update docker script to use gradle

2019-11-11 Thread Francis Chuang (Jira)
Francis Chuang created CALCITE-3493:
---

 Summary: Update docker script to use gradle
 Key: CALCITE-3493
 URL: https://issues.apache.org/jira/browse/CALCITE-3493
 Project: Calcite
  Issue Type: Improvement
  Components: avatica
Reporter: Francis Chuang
Assignee: Francis Chuang
 Fix For: avatica-1.16.0






--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (CALCITE-3492) Exception thrown when terms has 1 RexNode in RexUtil.simplifyOrs()

2019-11-11 Thread Haisheng Yuan (Jira)
Haisheng Yuan created CALCITE-3492:
--

 Summary: Exception thrown when terms has 1 RexNode in 
RexUtil.simplifyOrs()
 Key: CALCITE-3492
 URL: https://issues.apache.org/jira/browse/CALCITE-3492
 Project: Calcite
  Issue Type: Improvement
  Components: core
Reporter: Haisheng Yuan


This is a regression caused by the refactoring in 1.20.0.

When {{terms}} has only 1 element, it will throw an exception. We discovered 
the issue when trying to upgrade Calcite.
{code:java}
   public static RexNode simplifyOrs(RexBuilder rexBuilder,
   List terms) {
 return new RexSimplify(rexBuilder, RelOptPredicateList.EMPTY, EXECUTOR)
.simplifyUnknownAs(rexBuilder.makeCall(SqlStdOperatorTable.OR, terms),
 RexUnknownAs.UNKNOWN);
   }
{code}
We can't assume the {{terms}} always has more than 1 element. Although this 
method is deprecated, I think we need to correct the regression. Maybe we don't 
need a test case, given it is a deprecated method.




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: CALCITE-2905: Maven -> Gradle: any thoughts

2019-11-11 Thread Vladimir Sitnikov
As you might know, Avatica is already migrated to Gradle.

On top of that, Calcite is almost there as well:
https://github.com/apache/calcite/pull/1571

The missing bit is probably the notion of tests "fast/slow/etc/etc".
Unfortunately, there are tests that assert on folder layout like
"target/test-classes".
I'm going to ignore those tests for now, and fix them as pom.xml files are
removed.

I'm going to configure Gradle to use JUnit5 engine to run the tests.

In the meantime, everybody's welcome to preview Gradle build.

Vladimir


Re: Custom filters on AbstractAvaticaHandler

2019-11-11 Thread Josh Elser
Hi Som,

There are some examples in the unit tests of wiring up HTTP basic and
digest authentication via the provided Jetty implementations. These
aren't super useful in the real world (because our authentication
database is rarely a flat file).

There is a fine line between things we can cleanly do in Avatica
versus scope creep. For example, projects like Apache Knox have a
gateway whose sole purpose is to proxy RESTful services and provide
authentication to them. I think as long as providing
"batteries-included" authentication for Avatica doesn't detract for
its core mission (proxied JDBC over HTTP), then it would be a fine
addition.

One other concern I have is exposing Jetty-specific functionality via
Avatica public API. Because we cannot control Jetty API, we should not
have any Jetty classes in our public API. Karan had added some
ServerCustomizer logic in CALCITE-2294 which attempted to expose the
ability to configure Avatica for mTLS without polluting our API as an
example. I'd expect you could take a similar approach.

On Mon, Nov 11, 2019 at 3:54 PM Soman Ullah  wrote:
>
> Hello everyone,
> Are there any implementations of AbstractAvaticaHandler which provides a
> method to add a custom servlet filter? I would like to add authentication
> based filters to requests that flow through the avatica driver.
> If this feature doesnt exist, is the community open towards accepting that
> as a feature?
>
> Thanks,
> Som


Re: Avatica + GitHub Actions + Windows = AvaticaSpnegoTest - Principal: HTTP/stratum.antpool....@example.com is not known

2019-11-11 Thread Vladimir Sitnikov
>localhost but the principal being looked up is FQDN.

Where that FQDN is taken from?

Vladimir


Custom filters on AbstractAvaticaHandler

2019-11-11 Thread Soman Ullah
Hello everyone,
Are there any implementations of AbstractAvaticaHandler which provides a
method to add a custom servlet filter? I would like to add authentication
based filters to requests that flow through the avatica driver.
If this feature doesnt exist, is the community open towards accepting that
as a feature?

Thanks,
Som


Re: Avatica + GitHub Actions + Windows = AvaticaSpnegoTest - Principal: HTTP/stratum.antpool....@example.com is not known

2019-11-11 Thread Josh Elser
Yeah, the expectation is that all of the tests are using localhost (to
specifically avoid issues around trying to pull the FQDN and relying
on the developer to have specific setups).

On Mon, Nov 11, 2019 at 3:38 PM Kevin Risden  wrote:
>
> >
> >  2019-11-10 21:29:30,443 [pool-1-thread-2] ERROR - Principal: HTTP/
> > stratum.antpool@example.com is not known
> > 2019-11-10 21:29:30,459 [Test worker] WARN  - NEGOTIATE authentication
> > error: No valid credentials provided (Mechanism level: No valid credentials
> > provided (Mechanism level: Server not found in Kerberos database (7) -
> > Server not found in Kerberos database))
>
>
> Usually means DNS or the SPN being acquired is not correct. Should look at
> the test and see if it is trying to something like localhost and instead
> doing FQDN instead. Looks like
> https://github.com/apache/calcite-avatica/blob/master/server/src/test/java/org/apache/calcite/avatica/SpnegoTestUtil.java#L58
> does
> localhost but the principal being looked up is FQDN.
> Kevin Risden
>
>
>
> On Sun, Nov 10, 2019 at 4:53 PM Vladimir Sitnikov <
> sitnikov.vladi...@gmail.com> wrote:
>
> > Hi,
> >
> > I've added GitHub Actions for CI, and it looks like AvaticaSpnegoTest fails
> > again.
> >
> > The failure is the same for Maven and Gradle, so I expect it is not caused
> > by Gradle migration
> >
> > Maven: https://github.com/vlsi/calcite-avatica/runs/296688961#step:4:31296
> > Gradle:
> >
> > https://github.com/vlsi/calcite-avatica/commit/d1bb6f04c905ed65931800cde0af6a9899e585b6/checks?check_suite_id=304254116#step:4:117
> >
> > org.apache.calcite.avatica.AvaticaSpnegoTest > testAuthenticatedClient[0]
> > STANDARD_OUT
> > 2019-11-10 21:29:29,707 [pool-1-thread-1] INFO  - The preauth data is
> > empty.
> > 2019-11-10 21:29:29,707 [pool-1-thread-1] INFO  - KRB error occurred
> > while processing request: Additional pre-authentication required
> > 2019-11-10 21:29:29,785 [pool-1-thread-2] INFO  - AS_REQ ISSUE:
> > authtime 1573421369770,cli...@example.com for krbtgt/
> > example@example.com
> > 2019-11-10 21:29:30,443 [pool-1-thread-2] ERROR - Principal: HTTP/
> > stratum.antpool@example.com is not known
> > 2019-11-10 21:29:30,459 [Test worker] WARN  - NEGOTIATE authentication
> > error: No valid credentials provided (Mechanism level: No valid credentials
> > provided (Mechanism level: Server not found in Kerberos database (7) -
> > Server not found in Kerberos database))
> >
> > org.apache.calcite.avatica.AvaticaSpnegoTest > testAuthenticatedClient[0]
> > FAILED
> > java.lang.RuntimeException: Failed to execute HTTP Request, got
> > HTTP/401
> > at
> >
> > org.apache.calcite.avatica.remote.AvaticaCommonsHttpClientSpnegoImpl.send(AvaticaCommonsHttpClientSpnegoImpl.java:134)
> > at
> >
> > org.apache.calcite.avatica.remote.RemoteService.apply(RemoteService.java:34)
> > at
> > org.apache.calcite.avatica.remote.JsonService.apply(JsonService.java:172)
> > at
> > org.apache.calcite.avatica.remote.Driver.connect(Driver.java:176)
> > at
> > java.sql/java.sql.DriverManager.getConnection(DriverManager.java:677)
> > at
> > java.sql/java.sql.DriverManager.getConnection(DriverManager.java:251)
> > at
> >
> > org.apache.calcite.avatica.AvaticaSpnegoTest$1.run(AvaticaSpnegoTest.java:225)
> > at
> >
> > org.apache.calcite.avatica.AvaticaSpnegoTest$1.run(AvaticaSpnegoTest.java:223)
> > at java.base/java.security.AccessController.doPrivileged(Native
> > Method)
> > at java.base/javax.security.auth.Subject.doAs(Subject.java:423)
> > at
> >
> > org.apache.calcite.avatica.AvaticaSpnegoTest.testAuthenticatedClient(AvaticaSpnegoTest.java:223)
> >
> > Is it something known?
> >
> > PS. The failure is only for GitHub Actions + Windows.  GitHub Actions macOS
> > test passes.
> >
> > Vladimir
> >


Re: Avatica + GitHub Actions + Windows = AvaticaSpnegoTest - Principal: HTTP/stratum.antpool....@example.com is not known

2019-11-11 Thread Kevin Risden
>
>  2019-11-10 21:29:30,443 [pool-1-thread-2] ERROR - Principal: HTTP/
> stratum.antpool@example.com is not known
> 2019-11-10 21:29:30,459 [Test worker] WARN  - NEGOTIATE authentication
> error: No valid credentials provided (Mechanism level: No valid credentials
> provided (Mechanism level: Server not found in Kerberos database (7) -
> Server not found in Kerberos database))


Usually means DNS or the SPN being acquired is not correct. Should look at
the test and see if it is trying to something like localhost and instead
doing FQDN instead. Looks like
https://github.com/apache/calcite-avatica/blob/master/server/src/test/java/org/apache/calcite/avatica/SpnegoTestUtil.java#L58
does
localhost but the principal being looked up is FQDN.
Kevin Risden



On Sun, Nov 10, 2019 at 4:53 PM Vladimir Sitnikov <
sitnikov.vladi...@gmail.com> wrote:

> Hi,
>
> I've added GitHub Actions for CI, and it looks like AvaticaSpnegoTest fails
> again.
>
> The failure is the same for Maven and Gradle, so I expect it is not caused
> by Gradle migration
>
> Maven: https://github.com/vlsi/calcite-avatica/runs/296688961#step:4:31296
> Gradle:
>
> https://github.com/vlsi/calcite-avatica/commit/d1bb6f04c905ed65931800cde0af6a9899e585b6/checks?check_suite_id=304254116#step:4:117
>
> org.apache.calcite.avatica.AvaticaSpnegoTest > testAuthenticatedClient[0]
> STANDARD_OUT
> 2019-11-10 21:29:29,707 [pool-1-thread-1] INFO  - The preauth data is
> empty.
> 2019-11-10 21:29:29,707 [pool-1-thread-1] INFO  - KRB error occurred
> while processing request: Additional pre-authentication required
> 2019-11-10 21:29:29,785 [pool-1-thread-2] INFO  - AS_REQ ISSUE:
> authtime 1573421369770,cli...@example.com for krbtgt/
> example@example.com
> 2019-11-10 21:29:30,443 [pool-1-thread-2] ERROR - Principal: HTTP/
> stratum.antpool@example.com is not known
> 2019-11-10 21:29:30,459 [Test worker] WARN  - NEGOTIATE authentication
> error: No valid credentials provided (Mechanism level: No valid credentials
> provided (Mechanism level: Server not found in Kerberos database (7) -
> Server not found in Kerberos database))
>
> org.apache.calcite.avatica.AvaticaSpnegoTest > testAuthenticatedClient[0]
> FAILED
> java.lang.RuntimeException: Failed to execute HTTP Request, got
> HTTP/401
> at
>
> org.apache.calcite.avatica.remote.AvaticaCommonsHttpClientSpnegoImpl.send(AvaticaCommonsHttpClientSpnegoImpl.java:134)
> at
>
> org.apache.calcite.avatica.remote.RemoteService.apply(RemoteService.java:34)
> at
> org.apache.calcite.avatica.remote.JsonService.apply(JsonService.java:172)
> at
> org.apache.calcite.avatica.remote.Driver.connect(Driver.java:176)
> at
> java.sql/java.sql.DriverManager.getConnection(DriverManager.java:677)
> at
> java.sql/java.sql.DriverManager.getConnection(DriverManager.java:251)
> at
>
> org.apache.calcite.avatica.AvaticaSpnegoTest$1.run(AvaticaSpnegoTest.java:225)
> at
>
> org.apache.calcite.avatica.AvaticaSpnegoTest$1.run(AvaticaSpnegoTest.java:223)
> at java.base/java.security.AccessController.doPrivileged(Native
> Method)
> at java.base/javax.security.auth.Subject.doAs(Subject.java:423)
> at
>
> org.apache.calcite.avatica.AvaticaSpnegoTest.testAuthenticatedClient(AvaticaSpnegoTest.java:223)
>
> Is it something known?
>
> PS. The failure is only for GitHub Actions + Windows.  GitHub Actions macOS
> test passes.
>
> Vladimir
>


Re: [DISCUSS] Towards Avatica 1.16.0

2019-11-11 Thread Vladimir Sitnikov
The list you provide is outdated.

>these plugins weren't added to the Gradle build at
>some point.

Please feel free to execute "./gradlew tasks" and check what is available

To my best knowledge, the build script is good enough.

The missing items are
> * "Unused dependency"
> * "Used but undeclared dependency"

That, however, is not significant for Avatica since the number of
dependencies is low.
"unused dependency" and "used but undeclared" plugin for Gradle does not
exist yet.
We need "java-library" support, and that is a missing feature (
https://github.com/wfhartford/gradle-dependency-analyze/issues/39)

Vladimir


Re: [DISCUSS] Towards Avatica 1.16.0

2019-11-11 Thread Kevin Risden
>
> To my best knowledge, the missing bits are:
> * Documentation (site) update to reflect Maven -> Gradle
> * Errorprone
> * OWASP plugin
> * "Unused dependency"
> * "Used but undeclared dependency"
> * Removal of pom.xml files
> I'm not really sure there's a hard requirement to implement all of the
> above before flipping the switch.
> I'm inclined that OWASP and "unused/used dependency" can be implemented
> later. Freel free to correct me.


Are there Jiras to make sure these get added back in (specifically the
plugins to ensure build quality(? I think Gradle can be an improvement and
still learning my way around it. I know the above plugins were added
(mostly by me) to ensure that code quality doesn't suffer. It would be a
shame to regress since these plugins weren't added to the Gradle build at
some point.

Kevin Risden


On Sun, Nov 10, 2019 at 2:55 PM Vladimir Sitnikov <
sitnikov.vladi...@gmail.com> wrote:

> As a follow-up, I would like to thank everybody who helped to polish the
> change: Stamatis, Francis, et al.
>
> Vladimir
>


Re: [ANNOUNCE] Haisheng Yuan joins Calcite PMC

2019-11-11 Thread Kevin Risden
Congrats and welcome!

Kevin Risden


On Mon, Nov 11, 2019 at 2:10 PM Chunhui Shi  wrote:

> Congratulations!
>
> On Mon, Nov 11, 2019 at 10:09 AM Jinfeng Ni  wrote:
>
> > Congratulations!
> >
> >
> > On Tue, Nov 12, 2019 at 1:23 AM Rui Wang  wrote:
> > >
> > > Congrats HaiSheng!
> > >
> > >
> > > -Rui
> > >
> > > On Mon, Nov 11, 2019 at 8:05 AM Stamatis Zampetakis  >
> > > wrote:
> > >
> > > > Congrats Haisheng!
> > > >
> > > > Reviews, code contributions, design discussions, helping users, and
> > many
> > > > more things for improving the project.
> > > >
> > > > Personally, I also learn a lot from our interactions.
> > > >
> > > > All these are much appreciated; keep it up!!
> > > >
> > > > Best,
> > > > Stamatis
> > > >
> > > > On Mon, Nov 11, 2019, 4:17 PM Michael Mior  wrote:
> > > >
> > > > > Welcome and congratulations HaiSheng!
> > > > > --
> > > > > Michael Mior
> > > > > mm...@apache.org
> > > > >
> > > > > Le dim. 10 nov. 2019 à 22:45, Francis Chuang
> > > > >  a écrit :
> > > > > >
> > > > > > I'm pleased to announce that Haisheng has accepted an invitation
> to
> > > > > > join the Calcite PMC. Haisheng has been a consistent and helpful
> > > > > > figure in the Calcite community for which we are very grateful.
> We
> > > > > > look forward to the continued contributions and support.
> > > > > >
> > > > > > Please join me in congratulating Haisheng!
> > > > > >
> > > > > > - Francis (on behalf of the Calcite PMC)
> > > > >
> > > >
> >
>


Re: [ANNOUNCE] Haisheng Yuan joins Calcite PMC

2019-11-11 Thread Chunhui Shi
Congratulations!

On Mon, Nov 11, 2019 at 10:09 AM Jinfeng Ni  wrote:

> Congratulations!
>
>
> On Tue, Nov 12, 2019 at 1:23 AM Rui Wang  wrote:
> >
> > Congrats HaiSheng!
> >
> >
> > -Rui
> >
> > On Mon, Nov 11, 2019 at 8:05 AM Stamatis Zampetakis 
> > wrote:
> >
> > > Congrats Haisheng!
> > >
> > > Reviews, code contributions, design discussions, helping users, and
> many
> > > more things for improving the project.
> > >
> > > Personally, I also learn a lot from our interactions.
> > >
> > > All these are much appreciated; keep it up!!
> > >
> > > Best,
> > > Stamatis
> > >
> > > On Mon, Nov 11, 2019, 4:17 PM Michael Mior  wrote:
> > >
> > > > Welcome and congratulations HaiSheng!
> > > > --
> > > > Michael Mior
> > > > mm...@apache.org
> > > >
> > > > Le dim. 10 nov. 2019 à 22:45, Francis Chuang
> > > >  a écrit :
> > > > >
> > > > > I'm pleased to announce that Haisheng has accepted an invitation to
> > > > > join the Calcite PMC. Haisheng has been a consistent and helpful
> > > > > figure in the Calcite community for which we are very grateful. We
> > > > > look forward to the continued contributions and support.
> > > > >
> > > > > Please join me in congratulating Haisheng!
> > > > >
> > > > > - Francis (on behalf of the Calcite PMC)
> > > >
> > >
>


[jira] [Created] (CALCITE-3491) VolcanoPlanner.completeConversion() is bypassed by "if (true)"

2019-11-11 Thread Xiening Dai (Jira)
Xiening Dai created CALCITE-3491:


 Summary: VolcanoPlanner.completeConversion() is bypassed by "if 
(true)"
 Key: CALCITE-3491
 URL: https://issues.apache.org/jira/browse/CALCITE-3491
 Project: Calcite
  Issue Type: Bug
Reporter: Xiening Dai


Not very clear about why we need VolcanoPlanner.completeConversion(). It's 
currently bypassed as below[1] -

   if (true) {
  return rel;
}

If the method is not needed, we should just remove it.

[1] 
https://github.com/apache/calcite/blob/f90e5d7b48848191c1a70e6c0f78eece93433806/core/src/main/java/org/apache/calcite/plan/volcano/VolcanoPlanner.java#L1096





--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: [ANNOUNCE] Haisheng Yuan joins Calcite PMC

2019-11-11 Thread Jinfeng Ni
Congratulations!


On Tue, Nov 12, 2019 at 1:23 AM Rui Wang  wrote:
>
> Congrats HaiSheng!
>
>
> -Rui
>
> On Mon, Nov 11, 2019 at 8:05 AM Stamatis Zampetakis 
> wrote:
>
> > Congrats Haisheng!
> >
> > Reviews, code contributions, design discussions, helping users, and many
> > more things for improving the project.
> >
> > Personally, I also learn a lot from our interactions.
> >
> > All these are much appreciated; keep it up!!
> >
> > Best,
> > Stamatis
> >
> > On Mon, Nov 11, 2019, 4:17 PM Michael Mior  wrote:
> >
> > > Welcome and congratulations HaiSheng!
> > > --
> > > Michael Mior
> > > mm...@apache.org
> > >
> > > Le dim. 10 nov. 2019 à 22:45, Francis Chuang
> > >  a écrit :
> > > >
> > > > I'm pleased to announce that Haisheng has accepted an invitation to
> > > > join the Calcite PMC. Haisheng has been a consistent and helpful
> > > > figure in the Calcite community for which we are very grateful. We
> > > > look forward to the continued contributions and support.
> > > >
> > > > Please join me in congratulating Haisheng!
> > > >
> > > > - Francis (on behalf of the Calcite PMC)
> > >
> >


Re: [ANNOUNCE] Haisheng Yuan joins Calcite PMC

2019-11-11 Thread Rui Wang
Congrats HaiSheng!


-Rui

On Mon, Nov 11, 2019 at 8:05 AM Stamatis Zampetakis 
wrote:

> Congrats Haisheng!
>
> Reviews, code contributions, design discussions, helping users, and many
> more things for improving the project.
>
> Personally, I also learn a lot from our interactions.
>
> All these are much appreciated; keep it up!!
>
> Best,
> Stamatis
>
> On Mon, Nov 11, 2019, 4:17 PM Michael Mior  wrote:
>
> > Welcome and congratulations HaiSheng!
> > --
> > Michael Mior
> > mm...@apache.org
> >
> > Le dim. 10 nov. 2019 à 22:45, Francis Chuang
> >  a écrit :
> > >
> > > I'm pleased to announce that Haisheng has accepted an invitation to
> > > join the Calcite PMC. Haisheng has been a consistent and helpful
> > > figure in the Calcite community for which we are very grateful. We
> > > look forward to the continued contributions and support.
> > >
> > > Please join me in congratulating Haisheng!
> > >
> > > - Francis (on behalf of the Calcite PMC)
> >
>


Re: [ANNOUNCE] Haisheng Yuan joins Calcite PMC

2019-11-11 Thread Stamatis Zampetakis
Congrats Haisheng!

Reviews, code contributions, design discussions, helping users, and many
more things for improving the project.

Personally, I also learn a lot from our interactions.

All these are much appreciated; keep it up!!

Best,
Stamatis

On Mon, Nov 11, 2019, 4:17 PM Michael Mior  wrote:

> Welcome and congratulations HaiSheng!
> --
> Michael Mior
> mm...@apache.org
>
> Le dim. 10 nov. 2019 à 22:45, Francis Chuang
>  a écrit :
> >
> > I'm pleased to announce that Haisheng has accepted an invitation to
> > join the Calcite PMC. Haisheng has been a consistent and helpful
> > figure in the Calcite community for which we are very grateful. We
> > look forward to the continued contributions and support.
> >
> > Please join me in congratulating Haisheng!
> >
> > - Francis (on behalf of the Calcite PMC)
>


Re: [ANNOUNCE] Haisheng Yuan joins Calcite PMC

2019-11-11 Thread Michael Mior
Welcome and congratulations HaiSheng!
--
Michael Mior
mm...@apache.org

Le dim. 10 nov. 2019 à 22:45, Francis Chuang
 a écrit :
>
> I'm pleased to announce that Haisheng has accepted an invitation to
> join the Calcite PMC. Haisheng has been a consistent and helpful
> figure in the Calcite community for which we are very grateful. We
> look forward to the continued contributions and support.
>
> Please join me in congratulating Haisheng!
>
> - Francis (on behalf of the Calcite PMC)


Re: Re: [ANNOUNCE] Haisheng Yuan joins Calcite PMC

2019-11-11 Thread Albert
congrats, well deserved.



On Mon, Nov 11, 2019 at 2:26 PM Wang Yanlin <1989yanlinw...@163.com> wrote:

> Congrats Haisheng! Well deserved!--
>
> Best,
> Wang Yanlin
>
>
>
> 在 2019-11-11 14:09:58,"Leonard Xu"  写道:
> >Congratulations! HaiSheng
> >
> >Best,
> >Leonard Xu
> >> On 2019年11月11日, at 下午1:22, Danny Chan  wrote:
> >>
> >> Congratulations HaiSheng!
> >
>


-- 
~~~
no mistakes
~~