date:20210204

Re: [DISCUSS] Towards Avatica 1.18.0

2021-02-04 Thread Alessandro Solimando

Hi Francis,
thanks for your guidance, I have amended the commit message and opened a
new PR: https://github.com/apache/calcite-avatica/pull/136

Best regards,
Alessandro

On Thu, 4 Feb 2021 at 23:47, Francis Chuang 
wrote:

> Hey Alessandro,
>
> Thanks so much for reviewing CALCITE-3401. The tests on your rebased
> branch look good.
>
> Can you open a new PR with your rebased version? The commit message
> should also be updated to the correct format:
>
> [CALCITE-3401] Assume empty keystore passwords by default (Istvan Toth,
> Alessandro Solimando)
>
> Once that's done, I'll merge it into master for this release.
>
> Francis
>
> On 5/02/2021 5:10 am, Alessandro Solimando wrote:
> > Hi Francis,
> > I had a look at https://github.com/apache/calcite-avatica/pull/115,
> LGTM, I
> > haven't done a review on the PR itself as I have nothing I'd change, if
> you
> > think my approval can help I will mark it as such.
> >
> > I noticed that the PR has conflicts with master, I rebased it and run all
> > tests locally and via github actions (tests
> > 
> > and gradle
> > validate
> > ),
> > it's all good. Since the PR is from another user, I have rebased in a
> > branch in my own fork (
> > https://github.com/asolimando/calcite-avatica/tree/CALCITE-3401-rebased),
> I
> > have never pushed to an open PR from another user, maybe I could have
> done
> > (or could still do) that.
> >
> > Anyway, since I am not a committer this is the farest I can go, but if
> > there is anything else I can do, don't hesitate to let me know.
> >
> > Best regards,
> > Alessandro
> >
> > On Wed, 3 Feb 2021 at 02:50, Francis Chuang 
> > wrote:
> >
> >> Hey everyone,
> >>
> >> It's been around 7 months since the last Avatica release. There has been
> >> some push to get 1.18.0 out before the Calcite 1.27.0 release, so that
> >> the fixes in 1.18.0 can make it into the Calcite release.
> >>
> >> I saw a few open PRs on Github that could be potentially merged for this
> >> release:
> >> - https://github.com/apache/calcite-avatica/pull/135
> >> - https://github.com/apache/calcite-avatica/pull/132
> >> - https://github.com/apache/calcite-avatica/pull/129 <- this one is
> >> pretty much ready to merge except for the commit message
> >> - https://github.com/apache/calcite-avatica/pull/115 <- it would be
> nice
> >> if someone could carry this one, I think this one is almost there
> >>
> >> Are there any other PRs to merge or issues to look at?
> >>
> >> There hasn't been a whole lot of commits since the last release, so I
> >> think this release should be pretty straight forward. It would be much
> >> appreciated if the community can have a look at those PRs I have
> >> highlighted.
> >>
> >> Francis
> >>
> >
>

[jira] [Created] (CALCITE-4488) Release Avatica 1.18.0

2021-02-04 Thread Francis Chuang (Jira)

Francis Chuang created CALCITE-4488:
---

 Summary: Release Avatica 1.18.0
 Key: CALCITE-4488
 URL: https://issues.apache.org/jira/browse/CALCITE-4488
 Project: Calcite
  Issue Type: Task
  Components: avatica
Reporter: Francis Chuang
Assignee: Francis Chuang
 Fix For: avatica-1.18.0






--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: [DISCUSS] Towards Avatica 1.18.0

2021-02-04 Thread Francis Chuang


Hey Alessandro,

Thanks so much for reviewing CALCITE-3401. The tests on your rebased 
branch look good.


Can you open a new PR with your rebased version? The commit message 
should also be updated to the correct format:


[CALCITE-3401] Assume empty keystore passwords by default (Istvan Toth, 
Alessandro Solimando)


Once that's done, I'll merge it into master for this release.

Francis

On 5/02/2021 5:10 am, Alessandro Solimando wrote:

Hi Francis,
I had a look at https://github.com/apache/calcite-avatica/pull/115, LGTM, I
haven't done a review on the PR itself as I have nothing I'd change, if you
think my approval can help I will mark it as such.

I noticed that the PR has conflicts with master, I rebased it and run all
tests locally and via github actions (tests

and gradle
validate
),
it's all good. Since the PR is from another user, I have rebased in a
branch in my own fork (
https://github.com/asolimando/calcite-avatica/tree/CALCITE-3401-rebased), I
have never pushed to an open PR from another user, maybe I could have done
(or could still do) that.

Anyway, since I am not a committer this is the farest I can go, but if
there is anything else I can do, don't hesitate to let me know.

Best regards,
Alessandro

On Wed, 3 Feb 2021 at 02:50, Francis Chuang 
wrote:


Hey everyone,

It's been around 7 months since the last Avatica release. There has been
some push to get 1.18.0 out before the Calcite 1.27.0 release, so that
the fixes in 1.18.0 can make it into the Calcite release.

I saw a few open PRs on Github that could be potentially merged for this
release:
- https://github.com/apache/calcite-avatica/pull/135
- https://github.com/apache/calcite-avatica/pull/132
- https://github.com/apache/calcite-avatica/pull/129 <- this one is
pretty much ready to merge except for the commit message
- https://github.com/apache/calcite-avatica/pull/115 <- it would be nice
if someone could carry this one, I think this one is almost there

Are there any other PRs to merge or issues to look at?

There hasn't been a whole lot of commits since the last release, so I
think this release should be pretty straight forward. It would be much
appreciated if the community can have a look at those PRs I have
highlighted.

Francis

Re: [DISCUSS] Release Managers

2021-02-04 Thread Andrei Sereda

I'm happy to help with 1.30

On Thu, Feb 4, 2021 at 1:27 PM Julian Hyde  wrote:

> Yes, I'll be release manager for 1.28.
>
> I think I promised to be a release manager a while ago. I forget which
> release. Sorry about that.
>
> On Thu, Feb 4, 2021 at 1:09 AM Stamatis Zampetakis 
> wrote:
> >
> > That would be great Rui, thanks for volunteering. So far we have:
> >
> > 1.27 Stamatis
> > 1.28 Julian ?
> > 1.29 Rui
> >
> > It would be nice to also plan for 1.30 & 1.31 just to be a bit ahead of
> > time. Are there other people willing to help?
> >
> > Best,
> > Stamatis
> >
> >
> > On Wed, Feb 3, 2021 at 12:32 AM Rui Wang  wrote:
> >
> > > I can also help on releasing (haven't done one for Calcite).
> > >
> > >
> > > -Rui
> > >
> > > On Tue, Aug 18, 2020 at 2:32 PM Julian Hyde  wrote:
> > >
> > > > I haven't been RM for a while. I'll do 1.27, then Stamatis can do
> 1.28.
> > > >
> > > > On Sun, Aug 16, 2020 at 1:57 AM Stamatis Zampetakis <
> zabe...@gmail.com>
> > > > wrote:
> > > > >
> > > > > Depending on the timing I can possibly get 1.27.0 or 1.28.0.
> > > > >
> > > > > Best,
> > > > > Stamatis
> > > > >
> > > > > On Fri, Aug 14, 2020 at 2:58 AM Haisheng Yuan 
> > > wrote:
> > > > >
> > > > > > Thanks for volunteering, Ruben! I think you can be the release
> > > manager
> > > > for
> > > > > > 1.26.0.
> > > > > >
> > > > > > We still need 2 more volunteers for the next 2 versions.
> > > > > >
> > > > > > Thanks,
> > > > > > Haisheng
> > > > > >
> > > > > > On 2020/07/25 15:24:43, Ruben Q L  wrote:
> > > > > > > Hi,
> > > > > > >
> > > > > > > I can volunteer for one of them, for example 1.26.0
> > > > > > >
> > > > > > > Best regards,
> > > > > > > Ruben
> > > > > > >
> > > > > > >
> > > > > > > Le sam. 25 juil. 2020 à 15:23, Haisheng Yuan 
> a
> > > > écrit
> > > > > > :
> > > > > > >
> > > > > > > > Hi,
> > > > > > > >
> > > > > > > > Would anyone be interested in being release manager for
> v1.26.0,
> > > > > > v1.27.0
> > > > > > > > or v1.28.0?
> > > > > > > > We need 3 volunteers (must be PMC or committer) for these 3
> > > > versions.
> > > > > > > >
> > > > > > > > Thanks,
> > > > > > > > Haisheng Yuan
> > > > > > > >
> > > > > > >
> > > > > >
> > > >
> > >
>

Re: [DISCUSS] Release Managers

2021-02-04 Thread Julian Hyde

Yes, I'll be release manager for 1.28.

I think I promised to be a release manager a while ago. I forget which
release. Sorry about that.

On Thu, Feb 4, 2021 at 1:09 AM Stamatis Zampetakis  wrote:
>
> That would be great Rui, thanks for volunteering. So far we have:
>
> 1.27 Stamatis
> 1.28 Julian ?
> 1.29 Rui
>
> It would be nice to also plan for 1.30 & 1.31 just to be a bit ahead of
> time. Are there other people willing to help?
>
> Best,
> Stamatis
>
>
> On Wed, Feb 3, 2021 at 12:32 AM Rui Wang  wrote:
>
> > I can also help on releasing (haven't done one for Calcite).
> >
> >
> > -Rui
> >
> > On Tue, Aug 18, 2020 at 2:32 PM Julian Hyde  wrote:
> >
> > > I haven't been RM for a while. I'll do 1.27, then Stamatis can do 1.28.
> > >
> > > On Sun, Aug 16, 2020 at 1:57 AM Stamatis Zampetakis 
> > > wrote:
> > > >
> > > > Depending on the timing I can possibly get 1.27.0 or 1.28.0.
> > > >
> > > > Best,
> > > > Stamatis
> > > >
> > > > On Fri, Aug 14, 2020 at 2:58 AM Haisheng Yuan 
> > wrote:
> > > >
> > > > > Thanks for volunteering, Ruben! I think you can be the release
> > manager
> > > for
> > > > > 1.26.0.
> > > > >
> > > > > We still need 2 more volunteers for the next 2 versions.
> > > > >
> > > > > Thanks,
> > > > > Haisheng
> > > > >
> > > > > On 2020/07/25 15:24:43, Ruben Q L  wrote:
> > > > > > Hi,
> > > > > >
> > > > > > I can volunteer for one of them, for example 1.26.0
> > > > > >
> > > > > > Best regards,
> > > > > > Ruben
> > > > > >
> > > > > >
> > > > > > Le sam. 25 juil. 2020 à 15:23, Haisheng Yuan  a
> > > écrit
> > > > > :
> > > > > >
> > > > > > > Hi,
> > > > > > >
> > > > > > > Would anyone be interested in being release manager for v1.26.0,
> > > > > v1.27.0
> > > > > > > or v1.28.0?
> > > > > > > We need 3 volunteers (must be PMC or committer) for these 3
> > > versions.
> > > > > > >
> > > > > > > Thanks,
> > > > > > > Haisheng Yuan
> > > > > > >
> > > > > >
> > > > >
> > >
> >

Re: [DISCUSS] Towards Avatica 1.18.0

2021-02-04 Thread Alessandro Solimando

Hi Francis,
I had a look at https://github.com/apache/calcite-avatica/pull/115, LGTM, I
haven't done a review on the PR itself as I have nothing I'd change, if you
think my approval can help I will mark it as such.

I noticed that the PR has conflicts with master, I rebased it and run all
tests locally and via github actions (tests

and gradle
validate
),
it's all good. Since the PR is from another user, I have rebased in a
branch in my own fork (
https://github.com/asolimando/calcite-avatica/tree/CALCITE-3401-rebased), I
have never pushed to an open PR from another user, maybe I could have done
(or could still do) that.

Anyway, since I am not a committer this is the farest I can go, but if
there is anything else I can do, don't hesitate to let me know.

Best regards,
Alessandro

On Wed, 3 Feb 2021 at 02:50, Francis Chuang 
wrote:

> Hey everyone,
>
> It's been around 7 months since the last Avatica release. There has been
> some push to get 1.18.0 out before the Calcite 1.27.0 release, so that
> the fixes in 1.18.0 can make it into the Calcite release.
>
> I saw a few open PRs on Github that could be potentially merged for this
> release:
> - https://github.com/apache/calcite-avatica/pull/135
> - https://github.com/apache/calcite-avatica/pull/132
> - https://github.com/apache/calcite-avatica/pull/129 <- this one is
> pretty much ready to merge except for the commit message
> - https://github.com/apache/calcite-avatica/pull/115 <- it would be nice
> if someone could carry this one, I think this one is almost there
>
> Are there any other PRs to merge or issues to look at?
>
> There hasn't been a whole lot of commits since the last release, so I
> think this release should be pretty straight forward. It would be much
> appreciated if the community can have a look at those PRs I have
> highlighted.
>
> Francis
>

Re: [DISCUSS] Towards Calcite 1.27.0

2021-02-04 Thread Stamatis Zampetakis

OK so if I understand well for the next release we should aim to finish
CALCITE-4446, CALCITE-4405, and CALCITE-4487.

It would be good if people can test 1.26.0 or the current master now so
that we can see what else needs to be done for 1.27.0.

Best,
Stamatis

On Wed, Feb 3, 2021 at 9:46 AM Vladimir Sitnikov <
sitnikov.vladi...@gmail.com> wrote:

> Julian>because we never had a test case that indicated how actual behavior
> differed from desired behavior
>
> One of the tests has been included in Calcite sources for a while. Please
> refer to RexProgramFuzzyTest that I previously highlighted in
> "Search/Sarg: untested feature merged to the default branch" thread:
>
> https://lists.apache.org/thread.html/rce6e84d0e0cd5a227d64c9f670b43650833f43e0cbccb80e04f5e0cf%40%3Cdev.calcite.apache.org%3E
>
> Note: I believe "Sarg feature" should have been accompanied by the relevant
> additions to RefFuzzer, RexShrinker, and RexInterpreter as a part of the
> test
> coverage.
> Under the current implementation, users can't avoid/disable SEARCH/Sarg,
> and it is enabled by default, so the feature must come with tests.
>
> Vladimir
>

[jira] [Created] (CALCITE-4487) Add fuzzy tests for SEARCH operator

2021-02-04 Thread Stamatis Zampetakis (Jira)

Stamatis Zampetakis created CALCITE-4487:


 Summary: Add fuzzy tests for SEARCH operator
 Key: CALCITE-4487
 URL: https://issues.apache.org/jira/browse/CALCITE-4487
 Project: Calcite
  Issue Type: Improvement
Reporter: Stamatis Zampetakis
 Fix For: 1.27.0


**Most likely the classes that will need some changes are: RexFuzzer, 
RexShrinker, and RexInterpreter.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: [DISCUSS] Release Managers

2021-02-04 Thread Stamatis Zampetakis

That would be great Rui, thanks for volunteering. So far we have:

1.27 Stamatis
1.28 Julian ?
1.29 Rui

It would be nice to also plan for 1.30 & 1.31 just to be a bit ahead of
time. Are there other people willing to help?

Best,
Stamatis


On Wed, Feb 3, 2021 at 12:32 AM Rui Wang  wrote:

> I can also help on releasing (haven't done one for Calcite).
>
>
> -Rui
>
> On Tue, Aug 18, 2020 at 2:32 PM Julian Hyde  wrote:
>
> > I haven't been RM for a while. I'll do 1.27, then Stamatis can do 1.28.
> >
> > On Sun, Aug 16, 2020 at 1:57 AM Stamatis Zampetakis 
> > wrote:
> > >
> > > Depending on the timing I can possibly get 1.27.0 or 1.28.0.
> > >
> > > Best,
> > > Stamatis
> > >
> > > On Fri, Aug 14, 2020 at 2:58 AM Haisheng Yuan 
> wrote:
> > >
> > > > Thanks for volunteering, Ruben! I think you can be the release
> manager
> > for
> > > > 1.26.0.
> > > >
> > > > We still need 2 more volunteers for the next 2 versions.
> > > >
> > > > Thanks,
> > > > Haisheng
> > > >
> > > > On 2020/07/25 15:24:43, Ruben Q L  wrote:
> > > > > Hi,
> > > > >
> > > > > I can volunteer for one of them, for example 1.26.0
> > > > >
> > > > > Best regards,
> > > > > Ruben
> > > > >
> > > > >
> > > > > Le sam. 25 juil. 2020 à 15:23, Haisheng Yuan  a
> > écrit
> > > > :
> > > > >
> > > > > > Hi,
> > > > > >
> > > > > > Would anyone be interested in being release manager for v1.26.0,
> > > > v1.27.0
> > > > > > or v1.28.0?
> > > > > > We need 3 volunteers (must be PMC or committer) for these 3
> > versions.
> > > > > >
> > > > > > Thanks,
> > > > > > Haisheng Yuan
> > > > > >
> > > > >
> > > >
> >
>

Re: [DISCUSS] Towards Avatica 1.18.0

[jira] [Created] (CALCITE-4488) Release Avatica 1.18.0

Re: [DISCUSS] Towards Avatica 1.18.0

Re: [DISCUSS] Release Managers

Re: [DISCUSS] Release Managers

Re: [DISCUSS] Towards Avatica 1.18.0

Re: [DISCUSS] Towards Calcite 1.27.0

[jira] [Created] (CALCITE-4487) Add fuzzy tests for SEARCH operator

Re: [DISCUSS] Release Managers

9 matches

Site Navigation

Mail list logo

Footer information