Re: New rule for Converting UNION ALL with same inputs but different filters to single input with OR FILTER

2022-01-22 Thread Yanjing Wang
Thanks Albert. you could probably refer to osdi paper "resin general sub query fusion" > which has chapters talking about general union fusion that deals with the > case Julian pointed out. > The optimization seems very helpful, but it introduces new operators and the rule for new operators may

Re: [DISCUSS] Refactoring tests

2022-01-22 Thread Julian Hyde
Gavin, Thanks for the kind words. All, I have now squashed and rebased onto latest master. The squashed commit is https://github.com/julianhyde/calcite/commit/cb59231a72e23be260b21670012af33c47c2610e. I plan to merge to master on Monday. Jacques, You may wish to carefully review my changes to

Re: New rule for Converting UNION ALL with same inputs but different filters to single input with OR FILTER

2022-01-22 Thread Albert
On a more general fusion case, you could probably refer to osdi paper "resin general sub query fusion" which has chapters talking about general union fusion that deals with the case Julian pointed out. Btw, per my understanding cases of union fusion is not that many in practice. Curious to know

Re: Apache Calcite - How to create proper nested json object using JSON_OBJECT (it produces json with escapes)

2022-01-22 Thread Hongze Zhang
I think '=' is being shown because by "format json" the statement produced a JSON value expression rather than a regular JSON string. Ideally "format json" should not be at the rhs of a select item and the validator should complain about that. So there could be a missing check rule in validator.

Re: [ANNOUNCE] New Calcite PMC chair: Ruben Q L

2022-01-22 Thread Enrico Olivelli
Congrats! Enrico Il Sab 22 Gen 2022, 03:03 xiong duan ha scritto: > Congratulations to Ruben and thanks to Haisheng! > > Danny Chan 于2022年1月21日周五 12:19写道: > > > Congratulations, Ruben, and good luck! > > > > Haisheng, Thank you for serving as Chair. > > > > Yanjing Wang 于2022年1月21日

Re: [DISCUSS] Refactoring tests

2022-01-22 Thread Gavin Ray
Thank you for doing this, after reading the overview these changes seem like they will make a number of things easier related to testing. Super useful too when you're trying to start building something with Calcite but don't know it well enough to figure out how to put all the pieces together

Re: Apache Calcite - How to create proper nested json object using JSON_OBJECT (it produces json with escapes)

2022-01-22 Thread Stamatis Zampetakis
Hi, Agree with you the equals seems wrong as well but don't have time to investigate. Contributions are welcomed. Best, Stamatis On Tue, Jan 18, 2022 at 10:17 PM M Singh wrote: > Hi Stamatis: > Here is the JIRA ticket - > https://issues.apache.org/jira/browse/CALCITE-4989 > Thanks again for

Re: Questions With Materialized Views

2022-01-22 Thread zhiming she
I try to answer the first question. The materialized view rewriting of `SubstitutionVisitor` is based on the equivalent replacement of relational algebra expressions. Disadvantages of it are explained on the website [1]. 1. it might need to enumerate exhaustively all possible equivalent