Re: Failing CI
I really appreciate the fact that many people jumped in and helped to shoot this down and restabilise CI. Many thanks from my side as well to everyone involved! Best, Stamatis On Thu, Dec 7, 2023 at 12:46 AM Julian Hyde wrote: > > Thank you to everyone who worked on this - Stamatis, Benchao, Hongyu, Jiajun, > and maybe some I’ve missed. It sounded like a very tricky bug to diagnose. > (And it wasn’t even a Calcite bug in the end!) A solid, reliable CI system is > the foundation of high-quality software. > > Gian, The cause seems to have been a subtle bug in Druid’s query cache. If > you would like us to log a bug against Druid, let us know. > > Julian > > > > On Dec 6, 2023, at 8:06 AM, Tanner Clary > > wrote: > > > > Thanks for fixing this, Stamatis! > > > > -Tanner > > > > On Wed, Dec 6, 2023 at 8:04 AM Benchao Li wrote: > > > >> An update on this, it has been solved in CALCITE-6123 by Stamatis, the > >> Druid test is supposed to be stable now, thanks Stamatis for fixing > >> this and also thanks everyone who helped on this. > >> > >> Julian Hyde 于2023年12月2日周六 05:11写道： > >>> > >>> CI has been failing intermittently for three weeks. In 9 of the last18 > >> commits to main, the Druid test has failed. See all the red ‘x’ symbols on > >> https://github.com/apache/calcite/commits/main. > >>> > >>> This has a been logged as > >> https://issues.apache.org/jira/browse/CALCITE-6123, and there has been > >> plenty of discussion but it hasn’t been resolved. Without functioning CI, > >> we are flying blind. There is a high likelihood of more breaking changes > >> going in. What should we do? > >>> > >>> I suggest that we close the main branch until CI is fixed. > >>> > >>> Julian > >>> > >> > >> > >> -- > >> > >> Best, > >> Benchao Li > >> >
Re: [VOTE] Release apache-calcite-avatica-go-5.3.0 (release candidate 0)
Upgraded Docker version to 24.0.7, build afdd53b and rerun the
built/test checks.
* Built from git tag and run tests OK
* Built from source artifacts and run tests OK
Changing my vote to +1 (binding)
Stamatis
On Thu, Dec 7, 2023 at 10:40 AM Stamatis Zampetakis wrote:
>
> Ubuntu 20.04.6 LTS,
> docker-compose version 1.25.5, build 8a1c60f6
> Docker version 20.10.5, build 55c4c88
>
> * Checked signatures and checksums OK
> * Checked diff between repo and artifacts OK
> * Went over release note OK
> * Checked README.md (Logged CALCITE-6158)
> * Checked LICENSE, NOTICE OK
> * All source files have ASF headers OK
> * No unexpected binary files OK (find . -type f -exec file {} \; |
> grep -v text)
> * Built from git tag and run tests KO (Logged CALCITE-6159)
> * Built from source artifacts and run tests KO (Logged CALCITE-6159)
>
> 0 (binding)
>
> I couldn't build/test the release on my environment (CALCITE-6159)
> thus my vote. I will try updating docker and compose versions as it
> was suggested in the past and will try again.
>
> Best,
> Stamatis
>
> On Mon, Dec 4, 2023 at 5:19 AM Francis Chuang
> wrote:
> >
> > Hi all,
> >
> > I have created a release for Apache Calcite Avatica Go 5.3.0, release
> > candidate 0.
> >
> > Thanks to everyone who has contributed to this release. The release
> > notes are available here:
> > https://github.com/apache/calcite-avatica-go/blob/v5.3.0-rc0/site/_docs/go_history.md
> >
> > The commit to be voted on:
> > https://gitbox.apache.org/repos/asf?p=calcite-avatica-go.git;a=commit;h=8657d0ac4148dca20f67253e78be222d10cc9c6a
> >
> > The hash is 8657d0ac4148dca20f67253e78be222d10cc9c6a
> >
> > The artifacts to be voted on are located here:
> > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-avatica-go-5.3.0-rc0/
> >
> > The hashes of the artifacts are as follows:
> > src.tar.gz 4927DE62 7C46BE04 2F8092E6 86D5FE36 A3E0115F 7D1672AB
> > F0B32285 AB437FE53B6347CE 5824E1D9 C37A24D0 8B80088C 132F706D D484F0F8
> > C2961453 941AC048
> >
> > Release artifacts are signed with the following key:
> > https://people.apache.org/keys/committer/francischuang.asc
> >
> > Instructions for running the test suite is located here:
> > https://github.com/apache/calcite-avatica-go/blob/v5.3.0-rc0/site/develop/avatica-go.md#testing
> >
> > Please vote on releasing this package as Apache Calcite Avatica Go 5.3.0.
> >
> > To run the tests without a Go environment, install docker and docker
> > compose. Then, in the root of the release's directory, run: docker
> > compose run test
> >
> > When the test suite completes, run "docker compose down" to remove and
> > shutdown all the containers.
> >
> > The vote is open for the next 72 hours and passes if a majority of at
> > least three +1 PMC votes are cast.
> >
> > [ ] +1 Release this package as Apache Calcite Avatica Go 5.3.0
> > [ ] 0 I don't feel strongly about it, but I'm okay with the release
> > [ ] -1 Do not release this package because...
> >
> >
> > Here is my vote:
> >
> > +1 (binding)
> >
> > Francis
Re: [VOTE] Release apache-calcite-avatica-go-5.3.0 (release candidate 0)
Ubuntu 20.04.6 LTS,
docker-compose version 1.25.5, build 8a1c60f6
Docker version 20.10.5, build 55c4c88
* Checked signatures and checksums OK
* Checked diff between repo and artifacts OK
* Went over release note OK
* Checked README.md (Logged CALCITE-6158)
* Checked LICENSE, NOTICE OK
* All source files have ASF headers OK
* No unexpected binary files OK (find . -type f -exec file {} \; |
grep -v text)
* Built from git tag and run tests KO (Logged CALCITE-6159)
* Built from source artifacts and run tests KO (Logged CALCITE-6159)
0 (binding)
I couldn't build/test the release on my environment (CALCITE-6159)
thus my vote. I will try updating docker and compose versions as it
was suggested in the past and will try again.
Best,
Stamatis
On Mon, Dec 4, 2023 at 5:19 AM Francis Chuang wrote:
>
> Hi all,
>
> I have created a release for Apache Calcite Avatica Go 5.3.0, release
> candidate 0.
>
> Thanks to everyone who has contributed to this release. The release
> notes are available here:
> https://github.com/apache/calcite-avatica-go/blob/v5.3.0-rc0/site/_docs/go_history.md
>
> The commit to be voted on:
> https://gitbox.apache.org/repos/asf?p=calcite-avatica-go.git;a=commit;h=8657d0ac4148dca20f67253e78be222d10cc9c6a
>
> The hash is 8657d0ac4148dca20f67253e78be222d10cc9c6a
>
> The artifacts to be voted on are located here:
> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-avatica-go-5.3.0-rc0/
>
> The hashes of the artifacts are as follows:
> src.tar.gz 4927DE62 7C46BE04 2F8092E6 86D5FE36 A3E0115F 7D1672AB
> F0B32285 AB437FE53B6347CE 5824E1D9 C37A24D0 8B80088C 132F706D D484F0F8
> C2961453 941AC048
>
> Release artifacts are signed with the following key:
> https://people.apache.org/keys/committer/francischuang.asc
>
> Instructions for running the test suite is located here:
> https://github.com/apache/calcite-avatica-go/blob/v5.3.0-rc0/site/develop/avatica-go.md#testing
>
> Please vote on releasing this package as Apache Calcite Avatica Go 5.3.0.
>
> To run the tests without a Go environment, install docker and docker
> compose. Then, in the root of the release's directory, run: docker
> compose run test
>
> When the test suite completes, run "docker compose down" to remove and
> shutdown all the containers.
>
> The vote is open for the next 72 hours and passes if a majority of at
> least three +1 PMC votes are cast.
>
> [ ] +1 Release this package as Apache Calcite Avatica Go 5.3.0
> [ ] 0 I don't feel strongly about it, but I'm okay with the release
> [ ] -1 Do not release this package because...
>
>
> Here is my vote:
>
> +1 (binding)
>
> Francis
[jira] [Created] (CALCITE-6160) Missing ASF header from go.mod and go.sum files
Stamatis Zampetakis created CALCITE-6160: Summary: Missing ASF header from go.mod and go.sum files Key: CALCITE-6160 URL: https://issues.apache.org/jira/browse/CALCITE-6160 Project: Calcite Issue Type: Bug Components: avatica-go Affects Versions: avatica-go-5.2.0 Reporter: Stamatis Zampetakis Assignee: Francis Chuang The go.mod and go.sum files in [avatica-go repository|https://github.com/apache/calcite-avatica-go] do not contain the ASF header according to the [ASF policy|https://www.apache.org/legal/src-headers.html#headers]. I am not familiar with go so maybe it is impossible to add comments in these files so in that case I guess it is ok to leave them as is. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (CALCITE-6159) SIGABRT when running tests with docker-compose
Stamatis Zampetakis created CALCITE-6159:
Summary: SIGABRT when running tests with docker-compose
Key: CALCITE-6159
URL: https://issues.apache.org/jira/browse/CALCITE-6159
Project: Calcite
Issue Type: Bug
Components: avatica-go
Affects Versions: avatica-go-5.2.0
Environment: docker --version
Docker version 20.10.5, build 55c4c88
docker-compose --version
docker-compose version 1.25.5, build 8a1c60f6
Reporter: Stamatis Zampetakis
Assignee: Francis Chuang
{code:bash}
docker-compose run test
{code}
{noformat}
WARNING: The GOPATH variable is not set. Defaulting to a blank string.
Creating network "apache-calcite-avatica-go-530-src_default" with the default
driver
Creating apache-calcite-avatica-go-530-src_phoenix_1 ... done
Creating apache-calcite-avatica-go-530-src_hsqldb_1 ... done
? github.com/apache/calcite-avatica-go/v5/errors [no test files]
? github.com/apache/calcite-avatica-go/v5/generic [no test files]
? github.com/apache/calcite-avatica-go/v5/hsqldb [no test files]
? github.com/apache/calcite-avatica-go/v5/internal[no test files]
? github.com/apache/calcite-avatica-go/v5/message [no test files]
? github.com/apache/calcite-avatica-go/v5/phoenix [no test files]
runtime/cgo: pthread_create failed: Operation not permitted
SIGABRT: abort
PC=0x7f35ff61bd3c m=0 sigcode=18446744073709551610
goroutine 0 [idle]:
runtime: g 0: unknown pc 0x7f35ff61bd3c
stack: frame={sp:0x7fff98c7f800, fp:0x0} stack=[0x7fff98480c80,0x7fff98c7fc90)
0x7fff98c7f700: 0x00c58000 0x
0x7fff98c7f710: 0x 0x
0x7fff98c7f720: 0x 0x7fff98c7f948
0x7fff98c7f730: 0x00c32000 0x7fff98c7f968
0x7fff98c7f740: 0x0002 0x800e
0x7fff98c7f750: 0x 0x
0x7fff98c7f760: 0x 0x
0x7fff98c7f770: 0x 0x
0x7fff98c7f780: 0x009a874d 0x0003
0x7fff98c7f790: 0x00e0dc2c 0x
0x7fff98c7f7a0: 0x009a91e2 0x0006
0x7fff98c7f7b0: 0x00e0dc2a 0x
0x7fff98c7f7c0: 0x009a89fe 0x0004
0x7fff98c7f7d0: 0x 0x7f35ff689194
0x7fff98c7f7e0: 0x 0x000d
0x7fff98c7f7f0: 0x00a79653 0x7f35ff61bd2e
0x7fff98c7f800: <0x 0x114d148a7e0ab100
0x7fff98c7f810: 0x0006 0x7f35ff58e740
0x7fff98c7f820: 0x7fff98c7fad0 0x
0x7fff98c7f830: 0x00ddde00 0x7f35ff5ccf32
0x7fff98c7f840: 0x7f35ff764e70 0x7f35ff5b7472
0x7fff98c7f850: 0x0020 0x7f35ff764703
0x7fff98c7f860: 0x0d68 0x7f35ff611290
0x7fff98c7f870: 0x7f35ff7605e0 0x0001
0x7fff98c7f880: 0x000a 0x7f35ff58e740
0x7fff98c7f890: 0x 0x00ddde00
0x7fff98c7f8a0: 0x0006 0x7f35ff612ee9
0x7fff98c7f8b0: 0x7f35ff764680 0x7f35ff6132f3
0x7fff98c7f8c0: 0x7f35ff764680 0x000a
0x7fff98c7f8d0: 0x7f35ff58e740 0x7f35ff60e87a
0x7fff98c7f8e0: 0x7f35ff764840 0x114d148a7e0ab100
0x7fff98c7f8f0: 0x7f35ff764840 0x7f35ff764840
runtime: g 0: unknown pc 0x7f35ff61bd3c
stack: frame={sp:0x7fff98c7f800, fp:0x0} stack=[0x7fff98480c80,0x7fff98c7fc90)
0x7fff98c7f700: 0x00c58000 0x
0x7fff98c7f710: 0x 0x
0x7fff98c7f720: 0x 0x7fff98c7f948
0x7fff98c7f730: 0x00c32000 0x7fff98c7f968
0x7fff98c7f740: 0x0002 0x800e
0x7fff98c7f750: 0x 0x
0x7fff98c7f760: 0x 0x
0x7fff98c7f770: 0x 0x
0x7fff98c7f780: 0x009a874d 0x0003
0x7fff98c7f790: 0x00e0dc2c 0x
0x7fff98c7f7a0: 0x009a91e2 0x0006
0x7fff98c7f7b0: 0x00e0dc2a 0x
0x7fff98c7f7c0: 0x009a89fe 0x0004
0x7fff98c7f7d0: 0x 0x7f35ff689194
0x7fff98c7f7e0: 0x 0x000d
0x7fff98c7f7f0: 0x00a79653 0x7f35ff61bd2e
0x7fff98c7f800: <0x 0x114d148a7e0ab100
0x7fff98c7f810: 0x0006 0x7f35ff58e740
0x7fff98c7f820: 0x7fff98c7fad0 0x
0x7fff98c7f830: 0x00ddde00 0x7f35ff5ccf32
0x7fff98c7f840: 0x7f35ff764e70
[jira] [Created] (CALCITE-6158) No instructions for building/testing the project in README file
Stamatis Zampetakis created CALCITE-6158: Summary: No instructions for building/testing the project in README file Key: CALCITE-6158 URL: https://issues.apache.org/jira/browse/CALCITE-6158 Project: Calcite Issue Type: Bug Components: avatica-go Affects Versions: avatica-go-5.2.0 Reporter: Stamatis Zampetakis Assignee: Francis Chuang The [avatica-go repository|https://github.com/apache/calcite-avatica-go] and subsequently the source distribution do not contain instructions (or links to the appropriate place in the documentation) to build and test the project in the README file at the root of the project. Someone who downloads the released sources and its not familiar with the project may have a hard time using it. -- This message was sent by Atlassian Jira (v8.20.10#820010)
