[GitHub] calcite-avatica-go pull request #12: [CALCITE-2258] Add .travis.yml

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/calcite-avatica-go/pull/12


---

[GitHub] calcite-avatica-go pull request #12: [CALCITE-2258] Add .travis.yml

[F21]

Github user F21 commented on a diff in the pull request:

https://github.com/apache/calcite-avatica-go/pull/12#discussion_r181611670
  
--- Diff: .travis.yml ---
@@ -0,0 +1,54 @@
+# Configuration file for Travis continuous integration.
+# See https://travis-ci.org/apache/calcite-avatica-go
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to you under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+language: go
+
+branches:
+  only:
+- master
+- /^branch-.*$/
--- End diff --

Ah, I see. Let's keep this the way it is then.


---

[GitHub] calcite-avatica-go pull request #12: [CALCITE-2258] Add .travis.yml

[risdenk]

Github user risdenk commented on a diff in the pull request:

https://github.com/apache/calcite-avatica-go/pull/12#discussion_r181610048
  
--- Diff: .travis.yml ---
@@ -0,0 +1,54 @@
+# Configuration file for Travis continuous integration.
+# See https://travis-ci.org/apache/calcite-avatica-go
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to you under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+language: go
+
+branches:
+  only:
+- master
+- /^branch-.*$/
+- /^[0-9]+-.*$/
+
+go:
+  - "1.10.x"
+
+sudo: required
+services:
+  - docker
+
+env:
+  global:
+  - AVATICA_IMAGE=boostport/hbase-phoenix-all-in-one:1.3-4.13
+  - AVATICA_HOST=http://localhost:8765
+
+before_install:
+  - go get -u github.com/golang/dep/cmd/dep
+  - dep ensure -v
+  - docker pull $AVATICA_IMAGE
+  - docker run -d -p 8765:8765 $AVATICA_IMAGE
+  - docker ps -a
+
+install:
+  - go build
+
+script:
+  - go test -cover -v $(go list ./... | grep -v /vendor/)
--- End diff --

Just updated and pushed.


---

[GitHub] calcite-avatica-go pull request #12: [CALCITE-2258] Add .travis.yml

[risdenk]

Github user risdenk commented on a diff in the pull request:

https://github.com/apache/calcite-avatica-go/pull/12#discussion_r181610032
  
--- Diff: .travis.yml ---
@@ -0,0 +1,54 @@
+# Configuration file for Travis continuous integration.
+# See https://travis-ci.org/apache/calcite-avatica-go
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to you under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+language: go
+
+branches:
+  only:
+- master
+- /^branch-.*$/
--- End diff --

I tried to match what was in calcite and calcite-avatica. It is the exact 
same from those repos. Pull requests will get tested regardless of branch name.


---

[GitHub] calcite-avatica-go pull request #12: [CALCITE-2258] Add .travis.yml

[F21]

Github user F21 commented on a diff in the pull request:

https://github.com/apache/calcite-avatica-go/pull/12#discussion_r181600746
  
--- Diff: .travis.yml ---
@@ -0,0 +1,54 @@
+# Configuration file for Travis continuous integration.
+# See https://travis-ci.org/apache/calcite-avatica-go
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to you under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+language: go
+
+branches:
+  only:
+- master
+- /^branch-.*$/
--- End diff --

I think instead of these regexes, we can just use `/.*/


---

[GitHub] calcite-avatica-go pull request #12: [CALCITE-2258] Add .travis.yml

[F21]

Github user F21 commented on a diff in the pull request:

https://github.com/apache/calcite-avatica-go/pull/12#discussion_r181600756
  
--- Diff: .travis.yml ---
@@ -0,0 +1,54 @@
+# Configuration file for Travis continuous integration.
+# See https://travis-ci.org/apache/calcite-avatica-go
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to you under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+language: go
+
+branches:
+  only:
+- master
+- /^branch-.*$/
+- /^[0-9]+-.*$/
+
+go:
+  - "1.10.x"
+
+sudo: required
+services:
+  - docker
+
+env:
+  global:
+  - AVATICA_IMAGE=boostport/hbase-phoenix-all-in-one:1.3-4.13
+  - AVATICA_HOST=http://localhost:8765
+
+before_install:
+  - go get -u github.com/golang/dep/cmd/dep
+  - dep ensure -v
+  - docker pull $AVATICA_IMAGE
+  - docker run -d -p 8765:8765 $AVATICA_IMAGE
+  - docker ps -a
+
+install:
+  - go build
+
+script:
+  - go test -cover -v $(go list ./... | grep -v /vendor/)
--- End diff --

We can now use `go test -cover -v ./...` because newer versions of Go will 
no longer test repos in `/vendor/`.


---

[GitHub] calcite-avatica-go pull request #12: [CALCITE-2258] Add .travis.yml

[risdenk]

GitHub user risdenk opened a pull request:

https://github.com/apache/calcite-avatica-go/pull/12

[CALCITE-2258] Add .travis.yml

Addes .travis.yml based on existing wercker.yml.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/risdenk/calcite-avatica-go CALCITE-2258

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/calcite-avatica-go/pull/12.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #12


commit b381215f9cb1c0c0792f106cdccd2b6bcb0f1130
Author: Kevin Risden 
Date:   2018-04-15T18:55:42Z

[CALCITE-2258] Add .travis.yml




---