[GitHub] calcite-avatica-go pull request #15: Add script to generate release artifact...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/calcite-avatica-go/pull/15


---

[GitHub] calcite-avatica-go pull request #15: Add script to generate release artifact...

[risdenk]

Github user risdenk commented on a diff in the pull request:

https://github.com/apache/calcite-avatica-go/pull/15#discussion_r181917580
  
--- Diff: make-release-artifacts.sh ---
@@ -0,0 +1,26 @@
+# Clean dist directory
+rm -rf dist
+mkdir -p dist
+
+# Get new tags from remote
+git fetch --tags
+
+# Get latest tag name
+latestTag=$(git describe --tags `git rev-list --tags --max-count=1`)
--- End diff --

Fair enough just checking :)


---

[GitHub] calcite-avatica-go pull request #15: Add script to generate release artifact...

[F21]

Github user F21 commented on a diff in the pull request:

https://github.com/apache/calcite-avatica-go/pull/15#discussion_r181917310
  
--- Diff: make-release-artifacts.sh ---
@@ -0,0 +1,26 @@
+# Clean dist directory
+rm -rf dist
+mkdir -p dist
+
+# Get new tags from remote
+git fetch --tags
+
+# Get latest tag name
+latestTag=$(git describe --tags `git rev-list --tags --max-count=1`)
--- End diff --

To keep the script simple, it will only release the latest tag. In most 
cases, we only need to sign and release each tag once. If required in the 
future, we can include functionality to allow tag selection, but that's 
gold-plating at the moment in my opinion.


---

[GitHub] calcite-avatica-go pull request #15: Add script to generate release artifact...

[F21]

Github user F21 commented on a diff in the pull request:

https://github.com/apache/calcite-avatica-go/pull/15#discussion_r181917109
  
--- Diff: make-release-artifacts.sh ---
@@ -0,0 +1,26 @@
+# Clean dist directory
+rm -rf dist
+mkdir -p dist
+
+# Get new tags from remote
+git fetch --tags
+
+# Get latest tag name
+latestTag=$(git describe --tags `git rev-list --tags --max-count=1`)
+
+# Checkout latest tag
+git checkout $latestTag
+
+# Make tar
+tar -zcvf dist/calcite-avatica-go-src-$latestTag.tar.gz --transform 
"s/^\./calcite-avatica-go-src-$latestTag/g" --exclude "dist" .
+
+cd dist
+
+# Calculate MD5
+gpg --print-md MD5 calcite-avatica-go-src-$latestTag.tar.gz > 
calcite-avatica-go-src-$latestTag.tar.gz.md5
+
+# Calculate SHA256
+gpg --print-md SHA256 calcite-avatica-go-src-$latestTag.tar.gz > 
calcite-avatica-go-src-$latestTag.tar.gz.sha512
--- End diff --

Good catch.


---

[GitHub] calcite-avatica-go pull request #15: Add script to generate release artifact...

[risdenk]

Github user risdenk commented on a diff in the pull request:

https://github.com/apache/calcite-avatica-go/pull/15#discussion_r181916510
  
--- Diff: make-release-artifacts.sh ---
@@ -0,0 +1,26 @@
+# Clean dist directory
+rm -rf dist
+mkdir -p dist
+
+# Get new tags from remote
+git fetch --tags
+
+# Get latest tag name
+latestTag=$(git describe --tags `git rev-list --tags --max-count=1`)
--- End diff --

Will this always be the latest tag? Could tag be specified?


---

[GitHub] calcite-avatica-go pull request #15: Add script to generate release artifact...

[risdenk]

Github user risdenk commented on a diff in the pull request:

https://github.com/apache/calcite-avatica-go/pull/15#discussion_r181916445
  
--- Diff: make-release-artifacts.sh ---
@@ -0,0 +1,26 @@
+# Clean dist directory
+rm -rf dist
+mkdir -p dist
+
+# Get new tags from remote
+git fetch --tags
+
+# Get latest tag name
+latestTag=$(git describe --tags `git rev-list --tags --max-count=1`)
+
+# Checkout latest tag
+git checkout $latestTag
+
+# Make tar
+tar -zcvf dist/calcite-avatica-go-src-$latestTag.tar.gz --transform 
"s/^\./calcite-avatica-go-src-$latestTag/g" --exclude "dist" .
+
+cd dist
+
+# Calculate MD5
+gpg --print-md MD5 calcite-avatica-go-src-$latestTag.tar.gz > 
calcite-avatica-go-src-$latestTag.tar.gz.md5
+
+# Calculate SHA256
+gpg --print-md SHA256 calcite-avatica-go-src-$latestTag.tar.gz > 
calcite-avatica-go-src-$latestTag.tar.gz.sha512
--- End diff --

Extension should be sha256


---

[GitHub] calcite-avatica-go pull request #15: Add script to generate release artifact...

[F21]

GitHub user F21 opened a pull request:

https://github.com/apache/calcite-avatica-go/pull/15

Add script to generate release artifacts



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Boostport/calcite-avatica-go 
release-artifacts-script

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/calcite-avatica-go/pull/15.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #15


commit 2e6d4fdf62bd8d96bbf0e9296a52f0354c32d973
Author: Francis Chuang 
Date:   2018-04-16T23:37:57Z

Add script to generate release artifacts




---