[GitHub] calcite-avatica-go pull request #22: Check files for Apache license header i...

2018-04-22 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/calcite-avatica-go/pull/22


---


[GitHub] calcite-avatica-go pull request #22: Check files for Apache license header i...

2018-04-20 Thread F21
GitHub user F21 opened a pull request:

https://github.com/apache/calcite-avatica-go/pull/22

Check files for Apache license header in make-release-artifacts script

cc @julianhyde 

One quick question:

In cb2d4cb4596d5850bd0eb10c9c7697b679aabc2d, the script was updated to 
strip `-rc` identifiers from the tag name. Unfortunately, this means that if we 
only have a tag such as `3.0.0-rc1`, the tag won't be checked out. Should we 
revert it back to just: `latestTag=$(git describe --tags `git rev-list --tags 
--max-count=1`)` ?

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Boostport/calcite-avatica-go 
check-files-for-apache-license

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/calcite-avatica-go/pull/22.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #22


commit f910c0eaee14177a8c1f1252df2346ef6a587301
Author: Francis Chuang 
Date:   2018-04-21T02:59:54Z

Check files for Apache license header




---