vlsi commented on a change in pull request #1024: [CALCITE-2817] Make
CannotPlanException great
URL: https://github.com/apache/calcite/pull/1024#discussion_r256147817
##########
File path:
core/src/main/java/org/apache/calcite/plan/volcano/VolcanoPlanner.java
##########
@@ -1157,8 +1156,32 @@ public void setImportance(RelNode rel, double
importance) {
public void dump(PrintWriter pw) {
pw.println("Root: " + root.getDescription());
pw.println("Original rel:");
- pw.println(originalRootString);
- pw.println("Sets:");
+
+ if (originalRoot != null) {
+ originalRoot.explain(
+ new RelWriterImpl(pw, SqlExplainLevel.ALL_ATTRIBUTES, false));
+ }
+ if (DUMP_SETS) {
+ pw.println();
+ pw.println("Sets:");
+ dumpSets(pw);
+ }
+ if (DUMP_GRAPHVIZ) {
+ pw.println();
+ pw.println("Graphviz:");
+ dumpGraphviz(pw);
+ }
+ }
+
+ public String toDot() {
Review comment:
I'm not sure if this should be package-private (or just private) though
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
