Re: spi-annotations

2013-08-27 Thread Claus Ibsen
Okay a bit weird it does that, as there is no instructions in the pom.xml about that for it. I would assume we should have provided For the spi-annotations in the pom.xml so its not on the transitive list as its embedded and not needed. On Wed, Aug 28, 2013 at 8:09 AM, Willem jiang wrote: > Al

Re: spi-annotations

2013-08-27 Thread Willem jiang
All the tests except the ones in camel-core were failed. We don't need to install the spi-annotations bundle as the classes are shade into camel-core by the bnd plugin. -- Willem Jiang Red Hat, Inc. Web: http://www.redhat.com Blog: http://willemjiang.blogspot.com (http://willemjiang.blogspot.

Re: spi-annotations

2013-08-27 Thread Claus Ibsen
Which tests is failing? That seems odd as the .class is just added to camel-core? We need to find a solution as the JAR must be on the classpath. And for OSGi its not possible as its not an OSGi bundle. On Wed, Aug 28, 2013 at 3:01 AM, Willem jiang wrote: > spi-annotations is already shaded into

Re: spi-annotations

2013-08-27 Thread Willem jiang
spi-annotations is already shaded into camel-core by bnd plugin, we don't need to use the shaded plugin to do this kind of job. So I just revert the change for camel-2.12.0 release. -- Willem Jiang Red Hat, Inc. Web: http://www.redhat.com Blog: http://willemjiang.blogspot.com (http://willemji

Re: spi-annotations

2013-08-27 Thread Willem jiang
Lots of tests failed with this change, I'm trying to figure a solution for it now. BTW, it is not the good practice to shade the jars with the same package. -- Willem Jiang Red Hat, Inc. Web: http://www.redhat.com Blog: http://willemjiang.blogspot.com (http://willemjiang.blogspot.com/) (Engl

Re: Camel 2.12.0 release

2013-08-27 Thread Christian Müller
+1 Best, Christian - Software Integration Specialist Apache Camel committer: https://camel.apache.org/team V.P. Apache Camel: https://www.apache.org/foundation/ Apache Member: https://www.apache.org/foundation/members.html https://www.linkedin.com/pub/christian-mueller/11/551/64

Re: JSMPP doesn't catch Revision: r267

2013-08-27 Thread Christian Müller
Hi JB! Here is the ticket [1] ;-) I'm in contact with the jsmpp project owner (Google term) to figure out what works best for him to develop the project further... Applying patches, grant commit rights, ... [1] http://code.google.com/p/jsmpp/issues/detail?id=144 Best, Christian -

Re: Camel 2.12.0 release

2013-08-27 Thread Claus Ibsen
Hi Yeah AMQ 5.9 is not so far away. It requires Camel 2.12 and hence would need this release. We could start a talk on ActiveMQ @dev about the 5.9 release. As that would be required for a new SMX release also so its up to date with latest Karaf / AMQ / Camel / CXF etc. On Tue, Aug 27, 2013 at

Re: Camel 2.12.0 release

2013-08-27 Thread Christian Schneider
Sorry for not checking this more thoroughly. Yes. The camel feature file does not reference activemq. I just tested my camel tutorial example with camel 2.11.1 and activemq 5.7.0. The problem I face there is that activemq 5.7.0 does not work on karaf 2.3.x because it requires a blueprint versio

Re: MessageSupport

2013-08-27 Thread Claus Ibsen
Yeah its great that you dive into camel-core. We love when ppl get more familiar with the code base. We are always looking for contributors, and eventually also new committers. On Tue, Aug 27, 2013 at 1:30 PM, Jan Matèrne (jhm) wrote: > Ok, I just wondered ... > > Jan > >> -Ursprüngliche Nach

Re: spi-annotations

2013-08-27 Thread Willem jiang
cool, it sounds good. I will double check the change later today. -- Willem Jiang Red Hat, Inc. Web: http://www.redhat.com Blog: http://willemjiang.blogspot.com (http://willemjiang.blogspot.com/) (English) http://jnn.iteye.com (http://jnn.javaeye.com/) (Chinese) Twitter: willemjiang

AW: MessageSupport

2013-08-27 Thread jhm
Ok, I just wondered ... Jan > -Ursprüngliche Nachricht- > Von: Claus Ibsen [mailto:claus.ib...@gmail.com] > Gesendet: Dienstag, 27. August 2013 13:09 > An: dev > Betreff: Re: MessageSupport > > No its fine as is, according to the javadoc. Its only intended to be > overridden for special

Re: XML Signature DataFormat

2013-08-27 Thread Claus Ibsen
Hi Yeah I think Willem will look into getting this into the 2.12 release. To have a success is all the patch files there? And are they easy to apply? On Tue, Aug 27, 2013 at 9:00 AM, Franz Paul Forsthofer wrote: > Hi Claus, > > Colm and I aggreed on the implementation please have a look at > htt

Re: Camel 2.12.0 release

2013-08-27 Thread Claus Ibsen
I cannot see how this related to Apache Camel? At Apache Camel we do not have any OSGi imports/features for Apache ActiveMQ. Its "the other way around". ActiveMQ has a Camel module, and its own feature files. And the OSGi problems in AMQ 5.8.0 has been fixed on trunk and will be in the upcoming 5

Re: MessageSupport

2013-08-27 Thread Claus Ibsen
No its fine as is, according to the javadoc. Its only intended to be overridden for special use-cases. On Tue, Aug 27, 2013 at 1:05 PM, Jan Matèrne (jhm) wrote: > package org.apache.camel.impl; > > public abstract class MessageSupport implements Message { > > > > /** > > * A factory meth

MessageSupport

2013-08-27 Thread jhm
package org.apache.camel.impl; public abstract class MessageSupport implements Message { /** * A factory method to allow a provider to lazily create the message body * for inbound messages from other sources * * @return the value of the message body or null if there

Re: spi-annotations

2013-08-27 Thread Claus Ibsen
Hi The shading seems to work fine. I have committed a change to master. On Tue, Aug 27, 2013 at 12:34 PM, Claus Ibsen wrote: > Hi > > Logged a ticket > https://issues.apache.org/jira/browse/CAMEL-6673 > > Looks like shading works nicely. I will give it a test spin before > committing any changes

Re: Camel 2.12.0 release

2013-08-27 Thread Christian Schneider
We currently have some issues with ActiveMQ 8 on OSGi. Would it make sense to switch back to ActiveMQ 7 in the feature and possibly for imports for 2.12.0? Christian On 27.08.2013 11:52, Willem jiang wrote: Hi, I'm planing cut the Camel 2.12.0 release 12 hours later (About 27 August 2013,

Re: spi-annotations

2013-08-27 Thread Claus Ibsen
Hi Logged a ticket https://issues.apache.org/jira/browse/CAMEL-6673 Looks like shading works nicely. I will give it a test spin before committing any changes. But the .class files get included in camel-core and available for everybody now. On Tue, Aug 27, 2013 at 12:26 PM, Claus Ibsen wrote: >

Re: Camel 2.12.0 release

2013-08-27 Thread Claus Ibsen
Hi There is an issue with spi-annotations we need to sort before we can cut a release. I posted a mail on @dev on an existing thread about this. On Tue, Aug 27, 2013 at 12:14 PM, Claus Ibsen wrote: > Hi > > Sounds good. There is a few new documents that needs documentation but > I have moved the

Re: spi-annotations

2013-08-27 Thread Claus Ibsen
Hi I wonder if we can shade spi-annotations into the camel-core module, so its included out of the box? As they are needed at runtime, for example by components extending UriEndpointComponent etc. If not we should IMHO have it as required dependency and would need for it to be an OSGi bundle, and

Re: Camel 2.12.0 release

2013-08-27 Thread Claus Ibsen
Hi Sounds good. There is a few new documents that needs documentation but I have moved them to 2.12.1, as we may not get the docs ready in time. And they can be added later. One of the new components is in camel-extra and hence okay for it to wait post 2.12 release. On Tue, Aug 27, 2013 at 11:

Camel 2.12.0 release

2013-08-27 Thread Willem jiang
Hi, I'm planing cut the Camel 2.12.0 release 12 hours later (About 27 August 2013, 10 PM GMT). Please don't commit any code at that time and make sure the code you commit don't break any thing if you had to commit the code today. Thanks, -- Willem Jiang Red Hat, Inc. Web: http://www.r

Re: JSMPP doesn't catch Revision: r267

2013-08-27 Thread Jean-Baptiste Onofré
Hi Christian, It's what I saw too. I will work to add OSGi statements directly in JSMPP. Regards JB On 08/26/2013 10:27 PM, Christian Müller wrote: JSMPP 2.1.0 war released with revision 262. It cannot contain revision 267... :-( I sent Nuruddin a message and ask if I can help to resolve the o

Re: XML Signature DataFormat

2013-08-27 Thread Franz Paul Forsthofer
Hi Claus, Colm and I aggreed on the implementation please have a look at https://issues.apache.org/jira/browse/CAMEL-6339 Will you take care that the patch will be part of 2.12.0 release? Thanks and Regards Franz -- View this message in context: http://camel.465427.n5.nabble.com/XML-Signatur