Re: [DISCUSS] - camel-websocket component

2012-06-13 Thread Claus Ibsen
Hi I have logged a ticket about this https://issues.apache.org/jira/browse/CAMEL-5364 I don't think we got the time to work on this now. So I have scheduled it for 2.11. Also I can see that camel-websocket needs to mature a bit more, for example the last commit by Charles is a bit "hacky". And I

Re: [DISCUSS] - camel-websocket component

2012-06-13 Thread Babak Vahdat
Hi +1 to postpone this for 2.11 and bring the 2.10 release asap out the door, as I think we're now in a good shape for this (mostly because of your own hard work :-) ) BTW as I've already mentioned by the "[DISCUSS] - Apache Camel 2.10 release" thread there are still tests being commented out:

Re: [DISCUSS] - camel-websocket component

2012-06-13 Thread Charles Moulliard
Babak, Maybe the two tests commented could be removed as they are coming from initial upload when the code was mainly based on WebSocketComponent and not really using WebSocket Endpoint. I have put them in comment as I haven't had the time to think if we should keep them or not (was pretty busy la

Re: [DISCUSS] - camel-websocket component

2012-06-13 Thread Babak Vahdat
Hi all of the 9 @Test by WebsocketComponentTest are now fixed and enabled again. Babak Charles Moulliard wrote > > Babak, > > Maybe the two tests commented could be removed as they are coming from > initial upload when the code was mainly based on WebSocketComponent and > not > really using W

Re: svn commit: r1349901 - in /camel/trunk/components/camel-cxf/src: main/java/org/apache/camel/component/cxf/converter/ test/java/org/apache/camel/component/cxf/ test/resources/org/apache/camel/compo

2012-06-13 Thread Claus Ibsen
Hi In the converter code, you do a try .. catch and then swallow the caused exception. You should not do this, but throw the exception. And remove the logging. On Wed, Jun 13, 2012 at 5:20 PM, wrote: > Author: ningjiang > Date: Wed Jun 13 15:20:35 2012 > New Revision: 1349901 > > URL: http://s