[GitHub] camel pull request #2467: CAMEL-12726: Fix FindBugs warnings: Invocation of ...

2018-08-10 Thread hiroakiy
GitHub user hiroakiy opened a pull request:

https://github.com/apache/camel/pull/2467

CAMEL-12726: Fix FindBugs warnings: Invocation of toString on an array

FindBugs-3.0.1 
([http://findbugs.sourceforge.net/](http://findbugs.sourceforge.net/)) reported 
4 DMI_INVOKING_TOSTRING_ON_ARRAY warnings on master:
```
H C USELESS_STRING: Invocation of toString on 
org.apache.camel.processor.RemoveHeadersProcessor.getExcludePattern() in new 
org.apache.camel.management.mbean.ManagedRemoveHeaders(CamelContext, 
RemoveHeadersProcessor, ProcessorDefinition)  At 
ManagedRemoveHeaders.java:[line 37]
H C USELESS_STRING: Invocation of toString on 
org.apache.camel.processor.RemovePropertiesProcessor.getExcludePattern() in new 
org.apache.camel.management.mbean.ManagedRemoveProperties(CamelContext, 
RemovePropertiesProcessor, ProcessorDefinition)  At 
ManagedRemoveProperties.java:[line 37]
M C USELESS_STRING: Invocation of toString on 
ScpConfiguration.getPrivateKeyBytes() in 
org.apache.camel.component.scp.ScpOperations.createSession(ScpConfiguration)  
At ScpOperations.java:[line 262]
M C USELESS_STRING: Invocation of toString on path in 
org.apache.camel.component.box.api.BoxFoldersManager.createFolder(String, 
String[])  At BoxFoldersManager.java:[line 204]
```
The description of the bug is as follows:
> USELESS_STRING: Invocation of toString on an array 
(DMI_INVOKING_TOSTRING_ON_ARRAY)
>  The code invokes toString on an array, which will generate a fairly 
useless result such as [C@16f0472. Consider using Arrays.toString to convert 
the array into a readable String that gives the contents of the array. See 
Programming Puzzlers, chapter 3, puzzle 12.
 
[http://findbugs.sourceforge.net/bugDescriptions.html#DMI_INVOKING_TOSTRING_ON_ARRAY](http://findbugs.sourceforge.net/bugDescriptions.html#DMI_INVOKING_TOSTRING_ON_ARRAY)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/hiroakiy/camel CAMEL-12726

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/camel/pull/2467.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2467


commit 28627fe3301f8e5854194c92bdf4d961996d6e92
Author: Hiroaki Yoshida 
Date:   2018-08-11T01:33:09Z

CAMEL-12726: Fix FindBugs warnings: Invocation of toString on an array




---


[GitHub] camel pull request #2466: Fix some log messages that do not match with their...

2018-08-10 Thread lzh3636
GitHub user lzh3636 opened a pull request:

https://github.com/apache/camel/pull/2466

Fix some log messages that do not match with their method function

An extension to this pull request:
https://github.com/apache/camel/pull/2426

There are some possible copy and paste errors in the log messages (The 
logging statement was copied from an old place to a new place, but the message 
wasn't changed to adapt to the function of the new place). I found two more 
instances which are suffering from this problem and changed the logging 
messages to make them more adaptive to record the actual behavior.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/lzh3636/camel log-message

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/camel/pull/2466.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2466


commit 457c4ce93c9c9ff9b46292e0294b27eb17a68fc4
Author: zhenhaoli 
Date:   2018-08-10T20:14:48Z

fix some log messages




---


[GitHub] camel pull request #2465: CAMEL-12715: Fixed camel-script dependencies

2018-08-10 Thread aldettinger
GitHub user aldettinger opened a pull request:

https://github.com/apache/camel/pull/2465

CAMEL-12715: Fixed camel-script dependencies

I have it running with this PR in karaf-itests and also manual install in 
karaf 4.1.2. Could anyone double-check please ?

More context in 
[CAMEL-12715](https://issues.apache.org/jira/browse/CAMEL-12715).

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/aldettinger/camel master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/camel/pull/2465.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2465


commit 3644cbc0de50aca971a64e3382291057b57bdc09
Author: aldettinger 
Date:   2018-08-10T17:26:15Z

CAMEL-12715: Fixed camel-script dependencies




---


[GitHub] camel pull request #2452: [CAMEL-12711] Add configuration property 'bindAddr...

2018-08-10 Thread davsclaus
Github user davsclaus closed the pull request at:

https://github.com/apache/camel/pull/2452


---


[GitHub] camel pull request #2464: CAMEL-12725: [ERROR] /sobject-pojo-optional.vm

2018-08-10 Thread zregvart
Github user zregvart closed the pull request at:

https://github.com/apache/camel/pull/2464


---


[GitHub] camel pull request #2464: CAMEL-12725: [ERROR] /sobject-pojo-optional.vm

2018-08-10 Thread tinusn
GitHub user tinusn opened a pull request:

https://github.com/apache/camel/pull/2464

CAMEL-12725: [ERROR] /sobject-pojo-optional.vm



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tinusn/camel master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/camel/pull/2464.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2464


commit b0652d9707cbd4696d31467b258c2bd61f784980
Author: Tinus Aamand Norstved 
Date:   2018-08-10T07:13:05Z

Update sobject-pojo-optional.vm

Fixed error in setting the $fieldType - the syntax in the template document 
throws the  following error upon running:

[ERROR] Failed to execute goal 
org.apache.camel.maven:camel-salesforce-maven-plugin:2.21.0:generate 
(executable pom) on project test-project: Execution executable pom of goal 
org.apache.camel.maven:camel-salesforce-maven-plugin:2.21.0:generate failed: 
Encountered "(" at /sobject-pojo-optional.vm[line 64, column 8]
[ERROR] Was expecting one of:
[ERROR]  ...
[ERROR]  ...
[ERROR]  ...
[ERROR] "{" ...


This change fixes that.

commit 3aa87a7d67332139e69085881d55c7914a7b8efd
Author: Tinus Aamand Norstved 
Date:   2018-08-10T07:30:00Z

Merge pull request #1 from tinusn/tinusn-patch-1

Update sobject-pojo-optional.vm




---


[GitHub] camel pull request #2463: camel-ftp - SftpOperations should set byte[] inste...

2018-08-10 Thread davsclaus
Github user davsclaus closed the pull request at:

https://github.com/apache/camel/pull/2463


---