[GitHub] [camel-quarkus] asf-ci commented on issue #134: Fix #133 Test netty4-http as a producer
asf-ci commented on issue #134: Fix #133 Test netty4-http as a producer URL: https://github.com/apache/camel-quarkus/pull/134#issuecomment-521021881 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/camel-quarkus-pr/87/Failed Tests: 2camel-quarkus-pr/org.apache.camel.quarkus:camel-quarkus-integration-test-netty4-http: 2org.apache.camel.quarkus.component.netty4.http.CamelTest.netty4HttpProducerorg.apache.camel.quarkus.component.netty4.http.CamelIT.netty4HttpProducer This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k-runtime] lburgazzoli merged pull request #127: Re-organize repo and update deps
lburgazzoli merged pull request #127: Re-organize repo and update deps URL: https://github.com/apache/camel-k-runtime/pull/127 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request #134: Fix #133 Test netty4-http as a producer
lburgazzoli commented on a change in pull request #134: Fix #133 Test
netty4-http as a producer
URL: https://github.com/apache/camel-quarkus/pull/134#discussion_r313608723
##
File path:
integration-tests/netty4-http/src/test/java/org/apache/camel/quarkus/component/netty4/http/CamelTest.java
##
@@ -16,18 +16,119 @@
*/
package org.apache.camel.quarkus.component.netty4.http;
+import static org.hamcrest.Matchers.is;
+
+import java.io.BufferedReader;
+import java.io.Closeable;
+import java.io.IOException;
+import java.io.InputStreamReader;
+import java.io.OutputStreamWriter;
+import java.io.Reader;
+import java.io.Writer;
+import java.net.ServerSocket;
+import java.net.Socket;
+import java.net.SocketException;
import java.net.URI;
+import java.nio.charset.StandardCharsets;
+import java.util.concurrent.atomic.AtomicBoolean;
-import io.quarkus.test.junit.QuarkusTest;
-import io.restassured.RestAssured;
import org.junit.jupiter.api.Test;
-import static org.hamcrest.Matchers.is;
+import io.quarkus.test.junit.QuarkusTest;
+import io.restassured.RestAssured;
@QuarkusTest
public class CamelTest {
+
@Test
public void testNetty4Http() throws Exception {
RestAssured.when().get(new
URI("http://localhost:8999/foo;)).then().body(is("Netty Hello World"));
}
+
+@Test
+public void netty4HttpProducer() throws Exception {
+try (Server s = new Server("HTTP/1.1 200 OK\r\n" +
+"Content-Type: text/plain\r\n" +
+"\r\n" +
+"Hello from the mockserver!")) {
+/* First check that our mockserver actually works */
+RestAssured.when().get(new URI("http://localhost:; +
CamelRoute.PRODUCER_TARGET_PORT + "/")).then()
+.statusCode(200)
+.body(is("Hello from the mockserver!"));
+/* The producer route should proxy the mockserver */
+RestAssured.when().get(new
URI("http://localhost:8999/producer;)).then()
+.statusCode(200)
+.body(is("Hello from the mockserver!"));
+}
+}
+
+/**
+ * An HTTP server always sending the same response.
+ */
+static class Server implements Closeable, Runnable {
Review comment:
can't we use something like undertow or the simple http server provided by
openjdk ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request #134: Fix #133 Test netty4-http as a producer
lburgazzoli commented on a change in pull request #134: Fix #133 Test
netty4-http as a producer
URL: https://github.com/apache/camel-quarkus/pull/134#discussion_r313608723
##
File path:
integration-tests/netty4-http/src/test/java/org/apache/camel/quarkus/component/netty4/http/CamelTest.java
##
@@ -16,18 +16,119 @@
*/
package org.apache.camel.quarkus.component.netty4.http;
+import static org.hamcrest.Matchers.is;
+
+import java.io.BufferedReader;
+import java.io.Closeable;
+import java.io.IOException;
+import java.io.InputStreamReader;
+import java.io.OutputStreamWriter;
+import java.io.Reader;
+import java.io.Writer;
+import java.net.ServerSocket;
+import java.net.Socket;
+import java.net.SocketException;
import java.net.URI;
+import java.nio.charset.StandardCharsets;
+import java.util.concurrent.atomic.AtomicBoolean;
-import io.quarkus.test.junit.QuarkusTest;
-import io.restassured.RestAssured;
import org.junit.jupiter.api.Test;
-import static org.hamcrest.Matchers.is;
+import io.quarkus.test.junit.QuarkusTest;
+import io.restassured.RestAssured;
@QuarkusTest
public class CamelTest {
+
@Test
public void testNetty4Http() throws Exception {
RestAssured.when().get(new
URI("http://localhost:8999/foo;)).then().body(is("Netty Hello World"));
}
+
+@Test
+public void netty4HttpProducer() throws Exception {
+try (Server s = new Server("HTTP/1.1 200 OK\r\n" +
+"Content-Type: text/plain\r\n" +
+"\r\n" +
+"Hello from the mockserver!")) {
+/* First check that our mockserver actually works */
+RestAssured.when().get(new URI("http://localhost:; +
CamelRoute.PRODUCER_TARGET_PORT + "/")).then()
+.statusCode(200)
+.body(is("Hello from the mockserver!"));
+/* The producer route should proxy the mockserver */
+RestAssured.when().get(new
URI("http://localhost:8999/producer;)).then()
+.statusCode(200)
+.body(is("Hello from the mockserver!"));
+}
+}
+
+/**
+ * An HTTP server always sending the same response.
+ */
+static class Server implements Closeable, Runnable {
Review comment:
can't we just use something like undertow or the simple http server provided
by openjdk ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] oscerd commented on a change in pull request #134: Fix #133 Test netty4-http as a producer
oscerd commented on a change in pull request #134: Fix #133 Test netty4-http as
a producer
URL: https://github.com/apache/camel-quarkus/pull/134#discussion_r313598243
##
File path:
integration-tests/netty4-http/src/main/java/org/apache/camel/quarkus/component/netty4/http/CamelRoute.java
##
@@ -19,10 +19,16 @@
import org.apache.camel.builder.RouteBuilder;
public class CamelRoute extends RouteBuilder {
+
+public static final int PRODUCER_TARGET_PORT = 10102;
Review comment:
Probably we'll need to re-use the AvailablePortFinder from Camel
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga opened a new pull request #134: Fix #133 Test netty4-http as a producer
ppalaga opened a new pull request #134: Fix #133 Test netty4-http as a producer URL: https://github.com/apache/camel-quarkus/pull/134 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on issue #132: netty4-http producer fails with RejectedExecutionException
lburgazzoli commented on issue #132: netty4-http producer fails with RejectedExecutionException URL: https://github.com/apache/camel-quarkus/issues/132#issuecomment-520922629 Seems related to different behaviour of default LRU cache vs LRU cache based on caffeine This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on issue #132: netty4-http producer fails with RejectedExecutionException
ppalaga commented on issue #132: netty4-http producer fails with RejectedExecutionException URL: https://github.com/apache/camel-quarkus/issues/132#issuecomment-520899302 I can see it failing in JVM mode. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on issue #132: netty4-http producer fails with RejectedExecutionException
lburgazzoli commented on issue #132: netty4-http producer fails with RejectedExecutionException URL: https://github.com/apache/camel-quarkus/issues/132#issuecomment-520897029 @hholtzhausen this looks like an issue on our side, as confirmation: does it fails in both jvm and native mode ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] ppalaga opened a new issue #133: Test netty4-http as a producer
ppalaga opened a new issue #133: Test netty4-http as a producer URL: https://github.com/apache/camel-quarkus/issues/133 Required by https://github.com/apache/camel-quarkus/issues/132 Plz assign to me. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] jamesnetherton opened a new issue #907: Add option to disable Kaniko cache warming
jamesnetherton opened a new issue #907: Add option to disable Kaniko cache warming URL: https://github.com/apache/camel-k/issues/907 See comments in https://github.com/apache/camel-k/pull/905. Also issues #736 & #898. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] tim-hellhake opened a new issue #906: Dev mode doesn't show if the build failed
tim-hellhake opened a new issue #906: Dev mode doesn't show if the build failed URL: https://github.com/apache/camel-k/issues/906 Although the build failed the dev mode is still in interactive mode with the last phase `Building Kit`. I would expect the dev mode to be terminated or at least an error message. ``` > kamel run examples/Sample.java --dev integration "sample" created integration "sample" in phase Waiting For Platform integration "sample" in phase Initialization integration "sample" in phase Building Kit ```  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] astefanutti merged pull request #905: fix: Enable proxy server to be configured for Kaniko builds
astefanutti merged pull request #905: fix: Enable proxy server to be configured for Kaniko builds URL: https://github.com/apache/camel-k/pull/905 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] hholtzhausen commented on issue #132: netty4-http producer fails with RejectedExecutionException
hholtzhausen commented on issue #132: netty4-http producer fails with RejectedExecutionException URL: https://github.com/apache/camel-quarkus/issues/132#issuecomment-520861586 Tried that to :) https://github.com/hholtzhausen/examples/commit/2816c9eec4bbfd8f55e6b6ce9335c6b89f7bb04a This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] astefanutti closed issue #899: camel-k-kit-XXXXX is not able to inherit docker proxy configuration
astefanutti closed issue #899: camel-k-kit-X is not able to inherit docker proxy configuration URL: https://github.com/apache/camel-k/issues/899 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] astefanutti closed issue #898: Camel-k-cache not able to create PVC (pod has unbound immediate PersistentVolumeClaims)
astefanutti closed issue #898: Camel-k-cache not able to create PVC (pod has unbound immediate PersistentVolumeClaims) URL: https://github.com/apache/camel-k/issues/898 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] astefanutti closed issue #736: camel-k-cache crashes on minikube
astefanutti closed issue #736: camel-k-cache crashes on minikube URL: https://github.com/apache/camel-k/issues/736 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] astefanutti commented on issue #905: fix: Enable proxy server to be configured for Kaniko builds
astefanutti commented on issue #905: fix: Enable proxy server to be configured for Kaniko builds URL: https://github.com/apache/camel-k/pull/905#issuecomment-520861487 Let's merge this and create a separate issue for the option to disable Kaniko cache warming. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on issue #132: netty4-http producer fails with RejectedExecutionException
lburgazzoli commented on issue #132: netty4-http producer fails with RejectedExecutionException URL: https://github.com/apache/camel-quarkus/issues/132#issuecomment-520860909 last thing the I'll test, can you change quarkus.camel.defer-init-phase from false to true ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] jamesnetherton commented on issue #905: fix: Enable proxy server to be configured for Kaniko builds
jamesnetherton commented on issue #905: fix: Enable proxy server to be configured for Kaniko builds URL: https://github.com/apache/camel-k/pull/905#issuecomment-520860871 Yeah we could add an option to disable cache warming. I can raise an issue for it (unless you'd prefer it to be part of this fix). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] hholtzhausen commented on issue #132: netty4-http producer fails with RejectedExecutionException
hholtzhausen commented on issue #132: netty4-http producer fails with RejectedExecutionException URL: https://github.com/apache/camel-quarkus/issues/132#issuecomment-520860117 Same behaviour and exception without @ApplicationScoped annotation. https://github.com/hholtzhausen/examples/commit/58e123d1852c4ea409a08f67aa35b052ecbe05f1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on issue #132: netty4-http producer fails with RejectedExecutionException
lburgazzoli commented on issue #132: netty4-http producer fails with RejectedExecutionException URL: https://github.com/apache/camel-quarkus/issues/132#issuecomment-520856723 Can you remove @ApplicationScoped from the route ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] hholtzhausen opened a new issue #132: netty4-http producer fails with RejectedExecutionException
hholtzhausen opened a new issue #132: netty4-http producer fails with RejectedExecutionException URL: https://github.com/apache/camel-quarkus/issues/132 A netty4-http producer is started and stopped immediately during application init. The route then fails with a _java.util.concurrent.RejectedExecutionException_ when executed. Producer debug logs during startup: ``` 2019-08-13 15:51:38,827 DEBUG [org.apa.cam.com.net.htt.NettyHttpProducer] (main) Starting producer: Producer[http://localhost:8080/greeter/hello] 2019-08-13 15:51:38,869 DEBUG [org.apa.cam.com.net.htt.NettyHttpProducer] (main) Created NettyProducer pool[maxActive=-1, minIdle=0, maxIdle=100, minEvictableIdleTimeMillis=30] -> org.apache.commons.pool.impl.GenericObjectPool@1e3e1014 2019-08-13 15:51:38,870 DEBUG [org.apa.cam.com.net.htt.NettyHttpProducer] (main) Stopping producer at address: localhost:8080 2019-08-13 15:51:38,885 DEBUG [org.apa.cam.com.net.htt.NettyHttpProducer] (main) Stopping producer with channel pool[active=0, idle=0] 2019-08-13 15:51:38,887 DEBUG [org.apa.cam.com.net.htt.NettyHttpProducer] (main) Stopping producer: Producer[http://localhost:8080/greeter/hello] ``` The exception can be reproduced using: [https://github.com/hholtzhausen/examples/tree/master/camel-quarkus-netty4-http-producer](url) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli merged pull request #130: Fix #129 Properies evaluation broken after the introduction of Proper…
lburgazzoli merged pull request #130: Fix #129 Properies evaluation broken after the introduction of Proper… URL: https://github.com/apache/camel-quarkus/pull/130 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli closed issue #129: Properies evaluation broken after the introduction of PropertyBindingSupport
lburgazzoli closed issue #129: Properies evaluation broken after the introduction of PropertyBindingSupport URL: https://github.com/apache/camel-quarkus/issues/129 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on issue #130: Fix #129 Properies evaluation broken after the introduction of Proper…
lburgazzoli commented on issue #130: Fix #129 Properies evaluation broken after the introduction of Proper… URL: https://github.com/apache/camel-quarkus/pull/130#issuecomment-520839831 thx @ppalaga This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] asf-ci commented on issue #130: Fix #129 Properies evaluation broken after the introduction of Proper…
asf-ci commented on issue #130: Fix #129 Properies evaluation broken after the introduction of Proper… URL: https://github.com/apache/camel-quarkus/pull/130#issuecomment-520837559 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/camel-quarkus-pr/86/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] astefanutti commented on issue #905: fix: Enable proxy server to be configured for Kaniko builds
astefanutti commented on issue #905: fix: Enable proxy server to be configured for Kaniko builds URL: https://github.com/apache/camel-k/pull/905#issuecomment-520823718 I wonder whether we should consider adding a parameter to disable Kaniko cache warming if that's too much unreliable. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] jamesnetherton opened a new pull request #905: fix: Enable proxy server to be configured for Kaniko builds
jamesnetherton opened a new pull request #905: fix: Enable proxy server to be configured for Kaniko builds URL: https://github.com/apache/camel-k/pull/905 fixes #899 I also tacked on a small 'fix' for the Kaniko cache pod, because it's almost impossible to reliably install camel-k on Minikube without the cache pod crashing (for me at least). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k-runtime] lburgazzoli opened a new issue #126: Base knative-http component to vertx-web as undertow 3 will be based on it
lburgazzoli opened a new issue #126: Base knative-http component to vertx-web as undertow 3 will be based on it URL: https://github.com/apache/camel-k-runtime/issues/126 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] kameshsampath commented on issue #118: Decide how to maintain examples
kameshsampath commented on issue #118: Decide how to maintain examples URL: https://github.com/apache/camel-quarkus/issues/118#issuecomment-520788132 @ppalaga @lburgazzoli - I will try to add few examples based on https://github.com/apache/camel/tree/master/examples and see how many i can migrate as few components might need quarkizing This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on issue #118: Decide how to maintain examples
ppalaga commented on issue #118: Decide how to maintain examples URL: https://github.com/apache/camel-quarkus/issues/118#issuecomment-520768521 OK, sounds like we agree about 1.: the examples should live in `camel-quarkus` git repo, in an new directory called `examples`. For 2: Yes, I have the concerns about the build times. That's why I hold the view that we should avoid having similar projects in itests and examples. I prefer starting with testing the native mode in examples on every PR and I am open to revisit this when we feel the builds take too long. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli opened a new issue #131: Add support for quarkus provided event loop
lburgazzoli opened a new issue #131: Add support for quarkus provided event loop URL: https://github.com/apache/camel-quarkus/issues/131 We should back camel-core with event loop from quarkus, as example: https://github.com/quarkusio/quarkus/blob/master/extensions/netty/deployment/src/main/java/io/quarkus/netty/deployment/NettyProcessor.java#L57-L72 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
