Re: what is my first contribution ?
You can have a look here https://github.com/apache/camel/blob/master/CONTRIBUTING.md Il gio 12 set 2019, 18:50 Gopi Katuri ha scritto: > Hi Team, > > I would like to know my first step to start contributing . > > Regards, > Gopi. >
what is my first contribution ?
Hi Team, I would like to know my first step to start contributing . Regards, Gopi.
[GitHub] [camel-k] astefanutti commented on a change in pull request #922: fix: Add option to disable Kaniko cache warming
astefanutti commented on a change in pull request #922: fix: Add option to
disable Kaniko cache warming
URL: https://github.com/apache/camel-k/pull/922#discussion_r323816673
##
File path: pkg/controller/integrationplatform/initialize.go
##
@@ -137,7 +137,7 @@ func (action *initializeAction) Handle(ctx
context.Context, platform *v1alpha1.I
}
// Check if the operator is running in the same namespace
before starting the cache warmer
- if platform.Namespace == platformutil.GetOperatorNamespace() {
+ if platform.Namespace == platformutil.GetOperatorNamespace() &&
platform.Spec.Build.KanikoBuildCache {
Review comment:
Some may find _negative boolean variable_ a bad practice. I'm not sure Cobra
handle boolean pointer so that it is possible to detect the option is not set
and deal with a positive default. If it turns out it's possible, I think it'd
be a better alternative.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-k] astefanutti opened a new pull request #935: fix(knative): Use channel hostname to filter Knative history header
astefanutti opened a new pull request #935: fix(knative): Use channel hostname to filter Knative history header URL: https://github.com/apache/camel-k/pull/935 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] lburgazzoli opened a new issue #934: User profiles
lburgazzoli opened a new issue #934: User profiles URL: https://github.com/apache/camel-k/issues/934 As today we have a profile concept but it is related only to the platform , we should introduce a user profile concept as a way to share common options among integrations This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] ffang commented on issue #199: Camel jira
ffang commented on issue #199: Camel jira URL: https://github.com/apache/camel-quarkus/pull/199#issuecomment-530848125 I'm investigating the build failure This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] asf-ci commented on issue #189: Make xml and jaxb disabled by default and opt-in when depending on camel
asf-ci commented on issue #189: Make xml and jaxb disabled by default and opt-in when depending on camel URL: https://github.com/apache/camel-quarkus/pull/189#issuecomment-530836969 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/camel-quarkus-pr/155/Build result: FAILURE[...truncated 885.54 KB...]at java.lang.reflect.Method.invoke (Method.java:498)at hudson.maven.Maven3Builder.call (Maven3Builder.java:139)at hudson.maven.Maven3Builder.call (Maven3Builder.java:70)at hudson.remoting.UserRequest.perform (UserRequest.java:212)at hudson.remoting.UserRequest.perform (UserRequest.java:54)at hudson.remoting.Request$2.run (Request.java:369)at hudson.remoting.InterceptingExecutorService$1.call (InterceptingExecutorService.java:72)at java.util.concurrent.FutureTask.run (FutureTask.java:266)at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1149)at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:624)at java.lang.Thread.run (Thread.java:748)[ERROR] [ERROR] Re-run Maven using the -X switch to enable full debug logging.[ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles:[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException[ERROR] [ERROR] After correcting the problems, you can resume the build with the command[ERROR] mvn -rf :camel-quarkus-integration-test-corechannel stoppedAdding one-line test results to commit status...Setting status of f917cae8d3bc7382d3531c89d8c11befe509fae5 to FAILURE with url https://builds.apache.org/job/camel-quarkus-pr/155/ and message: 'FAILURE 46 tests run, 1 skipped, 0 failed.'Using context: default This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Re: [camel] 01/02: Remove the very outdated "Can I use Camel on Java 1.4" FAQ entry.
Sorry for breaking the navigation. Thank you for fixing it! - Pascal Am 12.09.2019 um 13:06 schrieb Andrea Cosentino: Hello, when we remove/modify a link or a name, don't forget to always run the docs module in the camel project. It will check for dead xref. In this case it was broken. I fixed it. Il giorno gio 12 set 2019 alle ore 11:50 ha scritto: This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/camel.git commit d02e88989dcc30ccf4b5ae38e5db1735b65cb48e Author: Pascal Schumacher AuthorDate: Thu Sep 12 11:45:09 2019 +0200 Remove the very outdated "Can I use Camel on Java 1.4" FAQ entry. --- docs/user-manual/modules/ROOT/pages/faq.adoc | 1 - .../modules/ROOT/pages/faq/can-i-use-camel-on-java-14.adoc | 9 - 2 files changed, 10 deletions(-) diff --git a/docs/user-manual/modules/ROOT/pages/faq.adoc b/docs/user-manual/modules/ROOT/pages/faq.adoc index 691e0c2..0e6a101 100644 --- a/docs/user-manual/modules/ROOT/pages/faq.adoc +++ b/docs/user-manual/modules/ROOT/pages/faq.adoc @@ -16,7 +16,6 @@ so please join in and help us make the documentation better! General questions about Camel * xref:faq/can-i-get-commercial-support.adoc[Can I get commercial support?] -* xref:faq/can-i-use-camel-on-java-14.adoc[Can I use Camel on Java 1.4?] * xref:faq/does-camel-work-on-ibms-jdk.adoc[Does Camel work on IBM's JDK?] * xref:support.adoc[How can I get help?] * xref:faq/how-can-i-get-the-source-code.adoc[How can I get the source code?] diff --git a/docs/user-manual/modules/ROOT/pages/faq/can-i-use-camel-on-java-14.adoc b/docs/user-manual/modules/ROOT/pages/faq/can-i-use-camel-on-java-14.adoc deleted file mode 100644 index 7dfe697..000 --- a/docs/user-manual/modules/ROOT/pages/faq/can-i-use-camel-on-java-14.adoc +++ /dev/null @@ -1,9 +0,0 @@ -[[CanIuseCamelonJava1.4-CanIuseCamelonJava1.4]] -= Can I use Camel on Java 1.4? - -Apache Camel was developed to run on Java 1.5 or later to take advantage -of the new language features like generics and annotations together with -using the Java 5 concurrency code. Starting with version 2.7.0, only -Java 1.6 is supported. - -Starting with version 2.10.0, Java 1.7 is supported, but not required.
Re: Where to add Spring Boot integration tests?
Probably we can also think about adding a module in the tests folder, but for the naming it will be hard. Il giorno gio 12 set 2019 alle ore 13:03 Tadayoshi Sato < sato.tadayo...@gmail.com> ha scritto: > Thanks Andrea for your comments. > > On Thu, Sep 12, 2019 at 7:26 PM Andrea Cosentino > wrote: > > > I don't think it's a good idea to create something with issues in the > > folder name. > > > > Yes, it was just a bad example for further better ideas ;-) > > > > > > If this is an integration tests specific to camel-servlet, you can create > > an integration test in the component starter folder. > > > > Ideally this isn't specific to any single starter; it is rather based on a > real use case, which may grow into cross-component integration tests. But > practically this time it seems to only need camel-log & camel-rest other > than camel-servlet, so it appears that I can put it in > camel-servlet-starter. > > If things grow otherwise and I cannot put it in a single starter project > I'll consider other options. > > Thank you! > > > > > > Il giorno gio 12 set 2019 alle ore 12:21 Tadayoshi Sato < > > sato.tadayo...@gmail.com> ha scritto: > > > > > Hi folks, > > > > > > I'd like to add an integration test for camel-servlet that can run only > > on > > > Spring Boot. Initially I thought to add it to > > > tests/camel-itest-spring-boot, but this is rather for systematic > > > compatibility checks for camel components with Spring Boot, not where a > > > real cross-component regression test is placed. > > > > > > Where should I put such Spring Boot integration tests in Camel project? > > Is > > > it good idea to create another sub-project under tests/? If so what do > > you > > > think is the best name for the project? I cannot think of a good name > > for > > > such a project..., e.g. tests/camel-itest-spring-boot-issues? > > > > > > Best regards, > > > Tadayoshi > > > > > >
Re: [camel] 01/02: Remove the very outdated "Can I use Camel on Java 1.4" FAQ entry.
Hello, when we remove/modify a link or a name, don't forget to always run the docs module in the camel project. It will check for dead xref. In this case it was broken. I fixed it. Il giorno gio 12 set 2019 alle ore 11:50 ha scritto: > This is an automated email from the ASF dual-hosted git repository. > > pascalschumacher pushed a commit to branch master > in repository https://gitbox.apache.org/repos/asf/camel.git > > commit d02e88989dcc30ccf4b5ae38e5db1735b65cb48e > Author: Pascal Schumacher > AuthorDate: Thu Sep 12 11:45:09 2019 +0200 > > Remove the very outdated "Can I use Camel on Java 1.4" FAQ entry. > --- > docs/user-manual/modules/ROOT/pages/faq.adoc | 1 - > .../modules/ROOT/pages/faq/can-i-use-camel-on-java-14.adoc | 9 > - > 2 files changed, 10 deletions(-) > > diff --git a/docs/user-manual/modules/ROOT/pages/faq.adoc > b/docs/user-manual/modules/ROOT/pages/faq.adoc > index 691e0c2..0e6a101 100644 > --- a/docs/user-manual/modules/ROOT/pages/faq.adoc > +++ b/docs/user-manual/modules/ROOT/pages/faq.adoc > @@ -16,7 +16,6 @@ so please join in and help us make the documentation > better! > General questions about Camel > > * xref:faq/can-i-get-commercial-support.adoc[Can I get commercial > support?] > -* xref:faq/can-i-use-camel-on-java-14.adoc[Can I use Camel on Java 1.4?] > * xref:faq/does-camel-work-on-ibms-jdk.adoc[Does Camel work on IBM's JDK?] > * xref:support.adoc[How can I get help?] > * xref:faq/how-can-i-get-the-source-code.adoc[How can I get the source > code?] > diff --git > a/docs/user-manual/modules/ROOT/pages/faq/can-i-use-camel-on-java-14.adoc > b/docs/user-manual/modules/ROOT/pages/faq/can-i-use-camel-on-java-14.adoc > deleted file mode 100644 > index 7dfe697..000 > --- > a/docs/user-manual/modules/ROOT/pages/faq/can-i-use-camel-on-java-14.adoc > +++ /dev/null > @@ -1,9 +0,0 @@ > -[[CanIuseCamelonJava1.4-CanIuseCamelonJava1.4]] > -= Can I use Camel on Java 1.4? > - > -Apache Camel was developed to run on Java 1.5 or later to take advantage > -of the new language features like generics and annotations together with > -using the Java 5 concurrency code. Starting with version 2.7.0, only > -Java 1.6 is supported. > - > -Starting with version 2.10.0, Java 1.7 is supported, but not required. > >
Re: Where to add Spring Boot integration tests?
Thanks Andrea for your comments. On Thu, Sep 12, 2019 at 7:26 PM Andrea Cosentino wrote: > I don't think it's a good idea to create something with issues in the > folder name. > Yes, it was just a bad example for further better ideas ;-) > > If this is an integration tests specific to camel-servlet, you can create > an integration test in the component starter folder. > Ideally this isn't specific to any single starter; it is rather based on a real use case, which may grow into cross-component integration tests. But practically this time it seems to only need camel-log & camel-rest other than camel-servlet, so it appears that I can put it in camel-servlet-starter. If things grow otherwise and I cannot put it in a single starter project I'll consider other options. Thank you! > > Il giorno gio 12 set 2019 alle ore 12:21 Tadayoshi Sato < > sato.tadayo...@gmail.com> ha scritto: > > > Hi folks, > > > > I'd like to add an integration test for camel-servlet that can run only > on > > Spring Boot. Initially I thought to add it to > > tests/camel-itest-spring-boot, but this is rather for systematic > > compatibility checks for camel components with Spring Boot, not where a > > real cross-component regression test is placed. > > > > Where should I put such Spring Boot integration tests in Camel project? > Is > > it good idea to create another sub-project under tests/? If so what do > you > > think is the best name for the project? I cannot think of a good name > for > > such a project..., e.g. tests/camel-itest-spring-boot-issues? > > > > Best regards, > > Tadayoshi > > >
Re: Where to add Spring Boot integration tests?
I don't think it's a good idea to create something with issues in the folder name. If this is an integration tests specific to camel-servlet, you can create an integration test in the component starter folder. Il giorno gio 12 set 2019 alle ore 12:21 Tadayoshi Sato < sato.tadayo...@gmail.com> ha scritto: > Hi folks, > > I'd like to add an integration test for camel-servlet that can run only on > Spring Boot. Initially I thought to add it to > tests/camel-itest-spring-boot, but this is rather for systematic > compatibility checks for camel components with Spring Boot, not where a > real cross-component regression test is placed. > > Where should I put such Spring Boot integration tests in Camel project? Is > it good idea to create another sub-project under tests/? If so what do you > think is the best name for the project? I cannot think of a good name for > such a project..., e.g. tests/camel-itest-spring-boot-issues? > > Best regards, > Tadayoshi >
Where to add Spring Boot integration tests?
Hi folks, I'd like to add an integration test for camel-servlet that can run only on Spring Boot. Initially I thought to add it to tests/camel-itest-spring-boot, but this is rather for systematic compatibility checks for camel components with Spring Boot, not where a real cross-component regression test is placed. Where should I put such Spring Boot integration tests in Camel project? Is it good idea to create another sub-project under tests/? If so what do you think is the best name for the project? I cannot think of a good name for such a project..., e.g. tests/camel-itest-spring-boot-issues? Best regards, Tadayoshi
[GitHub] [camel-quarkus] lburgazzoli commented on issue #198: Remove support for RuntimeValue from registry
lburgazzoli commented on issue #198: Remove support for RuntimeValue from registry URL: https://github.com/apache/camel-quarkus/issues/198#issuecomment-530742898 Digging into it a little bit more, we can use https://github.com/apache/camel/blob/master/core/camel-api/src/main/java/org/apache/camel/spi/BeanRepository.java#L72-L74 to unwrap the runtime value when needed. Will work on a PR This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on issue #200: improve the paho integration test
ppalaga commented on issue #200: improve the paho integration test URL: https://github.com/apache/camel-quarkus/pull/200#issuecomment-530696348 @zhfeng perfect, thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
