[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request #231: Add support for quarkus provided event loop
lburgazzoli commented on a change in pull request #231: Add support for quarkus
provided event loop
URL: https://github.com/apache/camel-quarkus/pull/231#discussion_r331850515
##
File path:
extensions/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/BuildProcessor.java
##
@@ -66,7 +66,26 @@ CamelRegistryBuildItem registry(
RuntimeValue registry = recorder.createRegistry();
-CamelSupport.services(applicationArchives).forEach(si -> {
+CamelSupport.services(applicationArchives)
+.filter(si -> {
+//
+// we need to filter out some services for being
registered as some
+// extension configure them programmatically and if not
properly
+// configured, they may cause troubles.
+//
+// As example, a reactive-executor can be provided by
adding a dep on
+// camel-reactive-executor-vertx but if that service get
detected and
+// initialized, it will create an instance of Vert.x
during static init
Review comment:
ok, found out that I was wrong so I probably had some bad code during the
development that leaded to the reactive executor being started in the wrong
phase.
I've updated the comment.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
Notifications from camel-k & camel-quarkus github repos
Hi folks, I've just realised that this dev mailing list is receiving a huge amount of notifications from camel-k & camel-quarkus github repositories. I am a bit afraid that this overwhelms the actually discussions on camel development here and perhaps is making some who are willing to get involved in the dev discussions but not yet ready to be interested in camel-k & camel-quarkus developments scared of the mailing list and even be leaving. For github activities I think those who are interested in the dev of camel-k & camel-quarkus are already 'watch'ing the repos so they should get notified already, so it doesn't seem to make sense to route them to this mailing list as well. What do you think? Is there any way to mitigate this? Best regards,
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request #231: Add support for quarkus provided event loop
lburgazzoli commented on a change in pull request #231: Add support for quarkus
provided event loop
URL: https://github.com/apache/camel-quarkus/pull/231#discussion_r331846540
##
File path:
extensions/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/BuildProcessor.java
##
@@ -66,7 +66,26 @@ CamelRegistryBuildItem registry(
RuntimeValue registry = recorder.createRegistry();
-CamelSupport.services(applicationArchives).forEach(si -> {
+CamelSupport.services(applicationArchives)
+.filter(si -> {
+//
+// we need to filter out some services for being
registered as some
+// extension configure them programmatically and if not
properly
+// configured, they may cause troubles.
+//
+// As example, a reactive-executor can be provided by
adding a dep on
+// camel-reactive-executor-vertx but if that service get
detected and
+// initialized, it will create an instance of Vert.x
during static init
Review comment:
Yeah, I need to digg into the camel-reactive-executor-vertx a little bit
more as the camel context is not supposed to be started at build time but only
at runtime init by camel main.
Btw, filtering is still needed as in this case the reactive service is
configured by an extension and what we have in the registry is ignored.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request #231: Add support for quarkus provided event loop
lburgazzoli commented on a change in pull request #231: Add support for quarkus
provided event loop
URL: https://github.com/apache/camel-quarkus/pull/231#discussion_r331846540
##
File path:
extensions/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/BuildProcessor.java
##
@@ -66,7 +66,26 @@ CamelRegistryBuildItem registry(
RuntimeValue registry = recorder.createRegistry();
-CamelSupport.services(applicationArchives).forEach(si -> {
+CamelSupport.services(applicationArchives)
+.filter(si -> {
+//
+// we need to filter out some services for being
registered as some
+// extension configure them programmatically and if not
properly
+// configured, they may cause troubles.
+//
+// As example, a reactive-executor can be provided by
adding a dep on
+// camel-reactive-executor-vertx but if that service get
detected and
+// initialized, it will create an instance of Vert.x
during static init
Review comment:
Yeah, I need to digg into the camel-reactive-executor-vertx a little bit
more as the camel context is not supposed to be started at build time but only
at runtime init by camel main.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request #231: Add support for quarkus provided event loop
lburgazzoli commented on a change in pull request #231: Add support for quarkus
provided event loop
URL: https://github.com/apache/camel-quarkus/pull/231#discussion_r331846133
##
File path:
extensions/core/runtime/src/main/java/org/apache/camel/quarkus/core/RuntimeRegistry.java
##
@@ -30,4 +34,26 @@ public Object unwrap(Object value) {
? ((RuntimeValue)value).getValue()
: value;
}
+
+// TODO: fix upstream
Review comment:
Sorry was late and forgot to open an issue. The problem is that the default
implementations does not merge the results from the repositories with the
fallback one so if you bind something to the registry and one of the
repositories return a non null set, then you' won't get the local instance but
an empty answer.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
Re: [VOTE] Release Apache Camel K 1.0.0-M2 and Runtime 1.0.4
+1 (binding) On Sat, Oct 5, 2019 at 12:24 PM Nicola Ferraro wrote: > > Hello all: > > This is a combined vote to release Apache Camel K 1.0.0-M2 and Apache Camel > K Runtime 1.0.4. > > Release notes: > https://github.com/apache/camel-k/issues/944#issuecomment-538636280 > > Runtime staging repository: > https://repository.apache.org/content/repositories/orgapachecamel-1156 > Runtime Tag: > https://gitbox.apache.org/repos/asf?p=camel-k-runtime.git;a=shortlog;h=refs/tags/camel-k-runtime-parent-1.0.4 > > Camel K staging repository: > https://dist.apache.org/repos/dist/dev/camel/camel-k/1.0.0-M2/ > Camel K Tag: > https://gitbox.apache.org/repos/asf?p=camel-k.git;a=shortlog;h=refs/tags/1.0.0-M2 > > Staging container image repository: https://hub.docker.com/r/camelk/camel-k > /tags > > It's possible to install all staging artifacts with a single command: > kamel install --operator-image=camelk/camel-k:1.0.0-M2 --maven-repository= > https://repository.apache.org/content/repositories/orgapachecamel-1156 > > Please test this release candidate and cast your vote. > > [ ] +1 Release the binary as Apache Camel K 1.0.0-M2 and Apache Camel K > Runtime > 1.0.4 > [ ] -1 Veto the release (provide specific comments) > > The vote is open for at least 72 hours. > > Thanks, > Nicola Ferraro -- Claus Ibsen - http://davsclaus.com @davsclaus Camel in Action 2: https://www.manning.com/ibsen2
[GitHub] [camel-quarkus] davsclaus commented on a change in pull request #231: Add support for quarkus provided event loop
davsclaus commented on a change in pull request #231: Add support for quarkus
provided event loop
URL: https://github.com/apache/camel-quarkus/pull/231#discussion_r331834980
##
File path:
extensions/core/runtime/src/main/java/org/apache/camel/quarkus/core/RuntimeRegistry.java
##
@@ -30,4 +34,26 @@ public Object unwrap(Object value) {
? ((RuntimeValue)value).getValue()
: value;
}
+
+// TODO: fix upstream
Review comment:
Whats the issue upstream?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] davsclaus commented on a change in pull request #231: Add support for quarkus provided event loop
davsclaus commented on a change in pull request #231: Add support for quarkus
provided event loop
URL: https://github.com/apache/camel-quarkus/pull/231#discussion_r331835287
##
File path:
extensions/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/BuildProcessor.java
##
@@ -66,7 +66,26 @@ CamelRegistryBuildItem registry(
RuntimeValue registry = recorder.createRegistry();
-CamelSupport.services(applicationArchives).forEach(si -> {
+CamelSupport.services(applicationArchives)
+.filter(si -> {
+//
+// we need to filter out some services for being
registered as some
+// extension configure them programmatically and if not
properly
+// configured, they may cause troubles.
+//
+// As example, a reactive-executor can be provided by
adding a dep on
+// camel-reactive-executor-vertx but if that service get
detected and
+// initialized, it will create an instance of Vert.x
during static init
Review comment:
Its created in doStart lifecycle phase. So I wonder if quarkus-camel is a
bit "wrong" if it starts Camel services during build phase? We should only use
doInit phase IMHO for that.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] asf-ci commented on issue #231: Add support for quarkus provided event loop
asf-ci commented on issue #231: Add support for quarkus provided event loop URL: https://github.com/apache/camel-quarkus/pull/231#issuecomment-538802123 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/camel-quarkus-pr/211/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli opened a new pull request #231: Add support for quarkus provided event loop
lburgazzoli opened a new pull request #231: Add support for quarkus provided event loop URL: https://github.com/apache/camel-quarkus/pull/231 Fixes #131 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] oscerd closed issue #218: Ensure the PlatformHttpComponent is registered before the routes are started
oscerd closed issue #218: Ensure the PlatformHttpComponent is registered before the routes are started URL: https://github.com/apache/camel-quarkus/issues/218 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] oscerd merged pull request #230: Ensure the PlatformHttpComponent is registered before the routes are started
oscerd merged pull request #230: Ensure the PlatformHttpComponent is registered before the routes are started URL: https://github.com/apache/camel-quarkus/pull/230 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] asf-ci commented on issue #230: Ensure the PlatformHttpComponent is registered before the routes are started
asf-ci commented on issue #230: Ensure the PlatformHttpComponent is registered before the routes are started URL: https://github.com/apache/camel-quarkus/pull/230#issuecomment-538777062 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/camel-quarkus-pr/210/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[ANNOUNCEMENT] Apache Camel 3.0.0-RC2 (Release Candidate 2) Released
The Camel community announces the immediate availability of Camel 3.0.0-RC2, the second release candidate towards a new 3.0.0 major release with 94 improvements and fixes. The artifacts are published and ready for you to download from the Central Maven repository. For more details please take a look at the release notes [1]. Many thanks to all who made this release possible. On behalf of the Camel PMC, Gregor Zurowski [1] https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12345998=12311211
[GitHub] [camel-quarkus] lburgazzoli commented on issue #9: quarkus-camel - Use MainSupport as base for running Camel
lburgazzoli commented on issue #9: quarkus-camel - Use MainSupport as base for running Camel URL: https://github.com/apache/camel-quarkus/issues/9#issuecomment-538761371 Fixed by https://github.com/apache/camel-quarkus/pull/226 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli closed issue #9: quarkus-camel - Use MainSupport as base for running Camel
lburgazzoli closed issue #9: quarkus-camel - Use MainSupport as base for running Camel URL: https://github.com/apache/camel-quarkus/issues/9 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli closed issue #132: netty4-http producer fails with RejectedExecutionException
lburgazzoli closed issue #132: netty4-http producer fails with RejectedExecutionException URL: https://github.com/apache/camel-quarkus/issues/132 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[RESULT] [VOTE] Release Apache Camel 3.0.0-RC2 (Release Candidate 2)
Thanks for your participation in this vote. The vote passes with the following results: +1 binding: 8 (Alex Dettinger, Andrea Cosentino, Claus Ibsen, Gregor Zurowski, Jean-Baptiste Onofré, Jon Anstey, Luca Burgazzoli, Zoran Regvart) +1 non-binding: 2 (François Papon, Omar Al-Safi) I am going to publish the artifacts for Camel 3.0.0-RC2 shortly. Thanks, Gregor On Wed, Oct 2, 2019 at 9:19 AM Gregor Zurowski wrote: > > Hi Everyone: > > This is a vote to release Apache Camel 3.0.0-RC2 (Release Candidate > 2), the second release candidate towards a new 3.0.0 major release > with another 94 improvements and fixes. > > Release notes: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12345998=12311211 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachecamel-1154/ > > Tarballs: > https://repository.apache.org/content/repositories/orgapachecamel-1154/org/apache/camel/apache-camel/3.0.0-RC2/ > > Tag: > https://gitbox.apache.org/repos/asf?p=camel.git;a=tag;h=refs/tags/camel-3.0.0-RC2 > > Please test this release candidate and cast your vote. > [ ] +1 Release the binary as Apache Camel 3.0.0-RC2 > [ ] -1 Veto the release (provide specific comments) > > The vote is open for at least 72 hours. > > Thanks, > Gregor
[GitHub] [camel-quarkus] lburgazzoli commented on issue #132: netty4-http producer fails with RejectedExecutionException
lburgazzoli commented on issue #132: netty4-http producer fails with RejectedExecutionException URL: https://github.com/apache/camel-quarkus/issues/132#issuecomment-538761299 should be fixed now in master This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on issue #198: Remove custom registry implementation
lburgazzoli commented on issue #198: Remove custom registry implementation URL: https://github.com/apache/camel-quarkus/issues/198#issuecomment-538761228 Fixed by https://github.com/apache/camel-quarkus/pull/226 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli closed issue #198: Remove custom registry implementation
lburgazzoli closed issue #198: Remove custom registry implementation URL: https://github.com/apache/camel-quarkus/issues/198 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Re: [VOTE] Release Apache Camel 3.0.0-RC2 (Release Candidate 2)
+1 (binding) Gregor On Wed, Oct 2, 2019 at 9:19 AM Gregor Zurowski wrote: > > Hi Everyone: > > This is a vote to release Apache Camel 3.0.0-RC2 (Release Candidate > 2), the second release candidate towards a new 3.0.0 major release > with another 94 improvements and fixes. > > Release notes: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12345998=12311211 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachecamel-1154/ > > Tarballs: > https://repository.apache.org/content/repositories/orgapachecamel-1154/org/apache/camel/apache-camel/3.0.0-RC2/ > > Tag: > https://gitbox.apache.org/repos/asf?p=camel.git;a=tag;h=refs/tags/camel-3.0.0-RC2 > > Please test this release candidate and cast your vote. > [ ] +1 Release the binary as Apache Camel 3.0.0-RC2 > [ ] -1 Veto the release (provide specific comments) > > The vote is open for at least 72 hours. > > Thanks, > Gregor
[GitHub] [camel-quarkus] asf-ci commented on issue #230: Ensure the PlatformHttpComponent is registered before the routes are started
asf-ci commented on issue #230: Ensure the PlatformHttpComponent is registered before the routes are started URL: https://github.com/apache/camel-quarkus/pull/230#issuecomment-538756865 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/camel-quarkus-pr/209/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli merged pull request #229: Do not use deprecated methods
lburgazzoli merged pull request #229: Do not use deprecated methods URL: https://github.com/apache/camel-quarkus/pull/229 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli opened a new pull request #230: Ensure the PlatformHttpComponent is registered before the routes are started
lburgazzoli opened a new pull request #230: Ensure the PlatformHttpComponent is registered before the routes are started URL: https://github.com/apache/camel-quarkus/pull/230 Fixes #218 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] asf-ci commented on issue #229: Do not use deprecated methods
asf-ci commented on issue #229: Do not use deprecated methods URL: https://github.com/apache/camel-quarkus/pull/229#issuecomment-538749251 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/camel-quarkus-pr/208/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] oscerd merged pull request #134: Fix #133 Test netty4-http as a producer
oscerd merged pull request #134: Fix #133 Test netty4-http as a producer URL: https://github.com/apache/camel-quarkus/pull/134 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] oscerd closed issue #133: Test netty4-http as a producer
oscerd closed issue #133: Test netty4-http as a producer URL: https://github.com/apache/camel-quarkus/issues/133 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
