[GitHub] [camel-quarkus] ppalaga commented on issue #138: Add tests to the twitter itest project

2019-08-20 Thread GitBox
ppalaga commented on issue #138: Add tests to the twitter itest project URL: https://github.com/apache/camel-quarkus/pull/138#issuecomment-522970725 Is there anything missing here, @lburgazzoli @oscerd ? This is an automated m

[GitHub] [camel-quarkus] ppalaga commented on issue #138: Add tests to the twitter itest project

2019-08-19 Thread GitBox
ppalaga commented on issue #138: Add tests to the twitter itest project URL: https://github.com/apache/camel-quarkus/pull/138#issuecomment-522637918 Removed the test scopes in 8d87b17 to make this PR independent of #140 . It should be good to merge. --

[GitHub] [camel-quarkus] ppalaga commented on issue #138: Add tests to the twitter itest project

2019-08-19 Thread GitBox
ppalaga commented on issue #138: Add tests to the twitter itest project URL: https://github.com/apache/camel-quarkus/pull/138#issuecomment-522513753 96196a9 is passing for me locally. It will fail on Jenkins unless https://github.com/apache/camel-quarkus/pull/140 is merged first. -

[GitHub] [camel-quarkus] ppalaga commented on issue #138: Add tests to the twitter itest project

2019-08-16 Thread GitBox
ppalaga commented on issue #138: Add tests to the twitter itest project URL: https://github.com/apache/camel-quarkus/pull/138#issuecomment-522135500 05d6f85 eliminates the routes altogether as agreed with @lburgazzoli. Please do not merge yet, just review. I have exceeded my Twitter r

[GitHub] [camel-quarkus] ppalaga commented on issue #138: Add tests to the twitter itest project

2019-08-15 Thread GitBox
ppalaga commented on issue #138: Add tests to the twitter itest project URL: https://github.com/apache/camel-quarkus/pull/138#issuecomment-521762314 > > > We may also think about using `camel-mock` > > > > > > Not sure how? Injecting to the test class works only JVM mode. >

[GitHub] [camel-quarkus] ppalaga commented on issue #138: Add tests to the twitter itest project

2019-08-15 Thread GitBox
ppalaga commented on issue #138: Add tests to the twitter itest project URL: https://github.com/apache/camel-quarkus/pull/138#issuecomment-521739474 > No we don't have credentials. May I provide mine then? This is an au

[GitHub] [camel-quarkus] ppalaga commented on issue #138: Add tests to the twitter itest project

2019-08-15 Thread GitBox
ppalaga commented on issue #138: Add tests to the twitter itest project URL: https://github.com/apache/camel-quarkus/pull/138#issuecomment-521739084 > I think this can be greatly simplified by using consumer/producer templates instead i.e. putting thing on a queue and polling. Thank

[GitHub] [camel-quarkus] ppalaga commented on issue #138: Add tests to the twitter itest project

2019-08-15 Thread GitBox
ppalaga commented on issue #138: Add tests to the twitter itest project URL: https://github.com/apache/camel-quarkus/pull/138#issuecomment-521710478 Anybody knows what the Jenkins message `git clean -fdx" returned status code 143:` means? ---