[GitHub] [carbondata] akashrn5 commented on pull request #4115: [CARBONDATA-4163] Support adding of single-level complex columns(array/struct)

2021-04-19 Thread GitBox
akashrn5 commented on pull request #4115: URL: https://github.com/apache/carbondata/pull/4115#issuecomment-822983721 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [carbondata] ydvpankaj99 commented on pull request #4120: ci test random issue or not

2021-04-19 Thread GitBox
ydvpankaj99 commented on pull request #4120: URL: https://github.com/apache/carbondata/pull/4120#issuecomment-822982313 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4120: ci test random issue or not

2021-04-19 Thread GitBox
CarbonDataQA2 commented on pull request #4120: URL: https://github.com/apache/carbondata/pull/4120#issuecomment-822968465 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/3465/ -- This is an automated message from the

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4120: ci test random issue or not

2021-04-19 Thread GitBox
CarbonDataQA2 commented on pull request #4120: URL: https://github.com/apache/carbondata/pull/4120#issuecomment-822966299 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5213/ -- This is an automated message from the Apache Git

[GitHub] [carbondata] ydvpankaj99 commented on pull request #4120: ci test random issue or not

2021-04-19 Thread GitBox
ydvpankaj99 commented on pull request #4120: URL: https://github.com/apache/carbondata/pull/4120#issuecomment-822935849 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4120: ci test random issue or not

2021-04-19 Thread GitBox
CarbonDataQA2 commented on pull request #4120: URL: https://github.com/apache/carbondata/pull/4120#issuecomment-822674554 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/3464/ -- This is an automated message from the

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4120: ci test random issue or not

2021-04-19 Thread GitBox
CarbonDataQA2 commented on pull request #4120: URL: https://github.com/apache/carbondata/pull/4120#issuecomment-822671455 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5212/ -- This is an automated message from the Apache Git

[GitHub] [carbondata] ydvpankaj99 commented on pull request #4120: ci test random issue or not

2021-04-19 Thread GitBox
ydvpankaj99 commented on pull request #4120: URL: https://github.com/apache/carbondata/pull/4120#issuecomment-822612384 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4118: [CARBONDATA-4167][CARBONDATA-4168] Fix case sensitive issues and input validation for Geo values.

2021-04-19 Thread GitBox
CarbonDataQA2 commented on pull request #4118: URL: https://github.com/apache/carbondata/pull/4118#issuecomment-822579372 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/3463/ -- This is an automated message from the

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4118: [CARBONDATA-4167][CARBONDATA-4168] Fix case sensitive issues and input validation for Geo values.

2021-04-19 Thread GitBox
CarbonDataQA2 commented on pull request #4118: URL: https://github.com/apache/carbondata/pull/4118#issuecomment-822578777 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5211/ -- This is an automated message from the Apache Git

[GitHub] [carbondata] asfgit closed pull request #4113: [CARBONDATA-4161] Describe complex columns

2021-04-19 Thread GitBox
asfgit closed pull request #4113: URL: https://github.com/apache/carbondata/pull/4113 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4120: ci test random issue or not

2021-04-19 Thread GitBox
CarbonDataQA2 commented on pull request #4120: URL: https://github.com/apache/carbondata/pull/4120#issuecomment-822517283 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/3462/ -- This is an automated message from the

[GitHub] [carbondata] akkio-97 commented on a change in pull request #4115: [CARBONDATA-4163] Support adding of single-level complex columns(array/struct)

2021-04-19 Thread GitBox
akkio-97 commented on a change in pull request #4115: URL: https://github.com/apache/carbondata/pull/4115#discussion_r615904251 ## File path: integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/alterTable/TestAlterTableAddColumns.scala ## @@ -136,14

Re: [DISCUSSION] Support JOIN query with spatial index

2021-04-19 Thread Ajantha Bhat
Hi, I think now the latest document has addressed my previous comments and questions. polygon list query and polyline list query design looks ok. But the design of polygon query with join, I have performance concern. In this approach, we are using union polygon filter on spatial_table to prune

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4120: ci test random issue or not

2021-04-19 Thread GitBox
CarbonDataQA2 commented on pull request #4120: URL: https://github.com/apache/carbondata/pull/4120#issuecomment-822504281 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5210/ -- This is an automated message from the Apache Git

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4113: [CARBONDATA-4161] Describe complex columns

2021-04-19 Thread GitBox
CarbonDataQA2 commented on pull request #4113: URL: https://github.com/apache/carbondata/pull/4113#issuecomment-822484996 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5209/ -- This is an automated message from the Apache Git

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4113: [CARBONDATA-4161] Describe complex columns

2021-04-19 Thread GitBox
CarbonDataQA2 commented on pull request #4113: URL: https://github.com/apache/carbondata/pull/4113#issuecomment-822482372 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/3461/ -- This is an automated message from the

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4115: [CARBONDATA-4163] Support adding of single-level complex columns(array/struct)

2021-04-19 Thread GitBox
CarbonDataQA2 commented on pull request #4115: URL: https://github.com/apache/carbondata/pull/4115#issuecomment-822476499 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5208/ -- This is an automated message from the Apache Git

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4115: [CARBONDATA-4163] Support adding of single-level complex columns(array/struct)

2021-04-19 Thread GitBox
CarbonDataQA2 commented on pull request #4115: URL: https://github.com/apache/carbondata/pull/4115#issuecomment-822476020 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/3460/ -- This is an automated message from the

[GitHub] [carbondata] ydvpankaj99 commented on pull request #4120: ci test random issue or not

2021-04-19 Thread GitBox
ydvpankaj99 commented on pull request #4120: URL: https://github.com/apache/carbondata/pull/4120#issuecomment-822439792 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [carbondata] Indhumathi27 commented on pull request #4113: [CARBONDATA-4161] Describe complex columns

2021-04-19 Thread GitBox
Indhumathi27 commented on pull request #4113: URL: https://github.com/apache/carbondata/pull/4113#issuecomment-822421143 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4120: ci test random issue or not

2021-04-19 Thread GitBox
CarbonDataQA2 commented on pull request #4120: URL: https://github.com/apache/carbondata/pull/4120#issuecomment-822366877 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/3459/ -- This is an automated message from the

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4120: ci test random issue or not

2021-04-19 Thread GitBox
CarbonDataQA2 commented on pull request #4120: URL: https://github.com/apache/carbondata/pull/4120#issuecomment-822360744 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5207/ -- This is an automated message from the Apache Git

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4115: [CARBONDATA-4163] Support adding of single-level complex columns(array/struct)

2021-04-19 Thread GitBox
CarbonDataQA2 commented on pull request #4115: URL: https://github.com/apache/carbondata/pull/4115#issuecomment-822355050 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/3457/ -- This is an automated message from the

[GitHub] [carbondata] akashrn5 commented on a change in pull request #3988: [CARBONDATA-4037] Improve the table status and segment file writing

2021-04-19 Thread GitBox
akashrn5 commented on a change in pull request #3988: URL: https://github.com/apache/carbondata/pull/3988#discussion_r615721648 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/events/MergeIndexEventListener.scala ## @@ -140,19 +141,47 @@ class

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #3988: [CARBONDATA-4037] Improve the table status and segment file writing

2021-04-19 Thread GitBox
CarbonDataQA2 commented on pull request #3988: URL: https://github.com/apache/carbondata/pull/3988#issuecomment-822354240 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/3458/ -- This is an automated message from the

Re: query on string type return error

2021-04-19 Thread Yahui Liu
I encounter the same error in later carbon version. Have you find the root cause and solution for this error? -- Sent from: http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/

[GitHub] [carbondata] akashrn5 commented on a change in pull request #4115: [CARBONDATA-4163] Support adding of single-level complex columns(array/struct)

2021-04-19 Thread GitBox
akashrn5 commented on a change in pull request #4115: URL: https://github.com/apache/carbondata/pull/4115#discussion_r615698795 ## File path: integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/alterTable/TestAlterTableAddColumns.scala ## @@ -136,14

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #3988: [CARBONDATA-4037] Improve the table status and segment file writing

2021-04-19 Thread GitBox
CarbonDataQA2 commented on pull request #3988: URL: https://github.com/apache/carbondata/pull/3988#issuecomment-822328365 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5205/ -- This is an automated message from the Apache Git

[GitHub] [carbondata] Indhumathi27 commented on pull request #4115: [CARBONDATA-4163] Support adding of single-level complex columns(array/struct)

2021-04-19 Thread GitBox
Indhumathi27 commented on pull request #4115: URL: https://github.com/apache/carbondata/pull/4115#issuecomment-822311739 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #1390: [CARBONDATA-1360] fix for update table failures for struct data type

2021-04-19 Thread GitBox
CarbonDataQA2 commented on pull request #1390: URL: https://github.com/apache/carbondata/pull/1390#issuecomment-822291842 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5206/ -- This is an automated message from the Apache Git

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4120: ci test random issue or not

2021-04-19 Thread GitBox
CarbonDataQA2 commented on pull request #4120: URL: https://github.com/apache/carbondata/pull/4120#issuecomment-822267379 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5204/ -- This is an automated message from the Apache Git

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4120: ci test random issue or not

2021-04-19 Thread GitBox
CarbonDataQA2 commented on pull request #4120: URL: https://github.com/apache/carbondata/pull/4120#issuecomment-822267153 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/3452/ -- This is an automated message from the

[GitHub] [carbondata] ydvpankaj99 opened a new pull request #4120: ci test random issue or not

2021-04-19 Thread GitBox
ydvpankaj99 opened a new pull request #4120: URL: https://github.com/apache/carbondata/pull/4120 ### Why is this PR needed? ### What changes were proposed in this PR? ### Does this PR introduce any user interface change? - No - Yes. (please explain the

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4115: [CARBONDATA-4163] Support adding of single-level complex columns(array/struct)

2021-04-19 Thread GitBox
CarbonDataQA2 commented on pull request #4115: URL: https://github.com/apache/carbondata/pull/4115#issuecomment-822256718 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/3451/ -- This is an automated message from the

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4115: [CARBONDATA-4163] Support adding of single-level complex columns(array/struct)

2021-04-19 Thread GitBox
CarbonDataQA2 commented on pull request #4115: URL: https://github.com/apache/carbondata/pull/4115#issuecomment-822254971 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5203/ -- This is an automated message from the Apache Git

[GitHub] [carbondata] QiangCai commented on a change in pull request #4100: [CARBONDATA-4138] Reordering Carbon Expression instead of Spark Filter

2021-04-19 Thread GitBox
QiangCai commented on a change in pull request #4100: URL: https://github.com/apache/carbondata/pull/4100#discussion_r615581462 ## File path: core/src/main/java/org/apache/carbondata/core/scan/expression/optimize/reorder/ExpressionReorder.java ## @@ -0,0 +1,68 @@ +/* + *

[GitHub] [carbondata] QiangCai commented on a change in pull request #4100: [CARBONDATA-4138] Reordering Carbon Expression instead of Spark Filter

2021-04-19 Thread GitBox
QiangCai commented on a change in pull request #4100: URL: https://github.com/apache/carbondata/pull/4100#discussion_r615580115 ## File path: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java ## @@ -2602,6 +2602,11 @@ private

[GitHub] [carbondata] akkio-97 commented on a change in pull request #4115: [CARBONDATA-4163] Support adding of single-level complex columns(array/struct)

2021-04-19 Thread GitBox
akkio-97 commented on a change in pull request #4115: URL: https://github.com/apache/carbondata/pull/4115#discussion_r615567566 ## File path: integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/alterTable/TestAlterTableAddColumns.scala ## @@ -136,14