[GitHub] incubator-carbondata pull request #200: [CARBONDATA-276]add trim option

2016-09-29 Thread sujith71955
Github user sujith71955 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/200#discussion_r81281079 --- Diff: hadoop/src/test/java/org/apache/carbondata/hadoop/test/util/StoreCreator.java --- @@ -465,6 +466,7 @@ private static void

[GitHub] incubator-carbondata pull request #200: [CARBONDATA-276]add trim option

2016-09-29 Thread sujith71955
Github user sujith71955 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/200#discussion_r81281050 --- Diff: hadoop/src/test/java/org/apache/carbondata/hadoop/test/util/StoreCreator.java --- @@ -465,6 +466,7 @@ private static void

[GitHub] incubator-carbondata pull request #189: [CARBONDATA-267] Set block_size for ...

2016-09-29 Thread sujith71955
Github user sujith71955 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/189#discussion_r81280420 --- Diff: core/src/main/java/org/apache/carbondata/core/carbon/metadata/schema/table/TableSchema.java --- @@ -102,6 +107,14 @@ public void

[GitHub] incubator-carbondata pull request #189: [CARBONDATA-267] Set block_size for ...

2016-09-29 Thread sujith71955
Github user sujith71955 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/189#discussion_r81280323 --- Diff: integration/spark/src/main/scala/org/apache/spark/sql/CarbonSqlParser.scala --- @@ -546,6 +548,18 @@ class CarbonSqlParser()

[GitHub] incubator-carbondata pull request #189: [CARBONDATA-267] Set block_size for ...

2016-09-29 Thread sujith71955
Github user sujith71955 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/189#discussion_r81280222 --- Diff: format/src/main/thrift/schema.thrift --- @@ -124,6 +124,7 @@ struct TableSchema{ 1: required string table_id; // ID used

[GitHub] incubator-carbondata pull request #189: [CARBONDATA-267] Set block_size for ...

2016-09-29 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/189#discussion_r81279628 --- Diff: processing/src/main/java/org/apache/carbondata/processing/store/writer/AbstractFactDataWriter.java --- @@ -196,11 +197,22 @@

Re: intellij compiling issue

2016-09-29 Thread Qingqing Zhou
On Thu, Sep 29, 2016 at 3:38 PM, Aniket Adnaik wrote: > > > 2. After you import project as maven project in intellij >Go to "Build" tab and Click "*Make Project*" . >*Please note:* Do NOT use "Rebuild Project" , it will do a clean build, Perfect, this works for

[GitHub] incubator-carbondata pull request #203: [CARBONDATA-279]Load RDD to carbonda...

2016-09-29 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/203#discussion_r81246241 --- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataLoadRDD.scala --- @@ -462,3 +478,133 @@ class

Re: [Discussion] Support Date/Time format for Timestamp columns tobe defined at column level

2016-09-29 Thread Aniket Adnaik
+1 single date/time format. Regards, Aniket On Thu, Sep 29, 2016 at 12:50 PM, Kumar Vishal wrote: > +1 I agree vimals opinion > > On Sep 29, 2016 17:22, "杰" <2550062...@qq.com> wrote: > > > +1 agree to vimal's opinion > > > > ---Original--- > > From:

RE: [discussion]When table properties is repeated it only set the last one

2016-09-29 Thread Jihong Ma
We have start the discussion with Spark guys to open the door for pluggable parser going forward, and some of features we have now would require syntax extension as well, for now, we are ok. Regards. Jenny -Original Message- From: Ravindra Pesala [mailto:ravi.pes...@gmail.com]

Re: [Discussion] Support Date/Time format for Timestamp columns tobe defined at column level

2016-09-29 Thread ??
+1 agree to vimal's opinion ---Original--- From: "bill.zhou" Date: 2016/9/29 17:07:04 To: "dev"; Subject: Re: [Discussion] Support Date/Time format for Timestamp columns tobe defined at column level +1 I agree Vimal's opinion. if user want

Re: [Discussion] Support Date/Time format for Timestamp columns to be defined at column level

2016-09-29 Thread bill.zhou
+1 I agree Vimal's opinion. if user want other formatted, he can use function to convert. Regards Bill -- View this message in context:

Re: [discussion]When table properties is repeated it only set the last one

2016-09-29 Thread bill.zhou
+1 -- View this message in context: http://apache-carbondata-mailing-list-archive.1130556.n5.nabble.com/discussion-When-table-properties-is-repeated-it-only-set-the-last-one-tp1539p1559.html Sent from the Apache CarbonData Mailing List archive mailing list archive at Nabble.com.