Re: [PROPOSAL] Update on the Jenkins CarbonData job

2017-03-18 Thread Vimal Das Kammath
+1 On Mar 17, 2017 8:18 PM, "Jean-Baptiste Onofré" wrote: > Hi guys, > > Tomorrow I plan to update our jobs on Apache Jenkins as the following: > > - carbondata-master-spark-1.5 building master branch with Spark 1.5 profile > - carbondata-master-spark-1.6 building master

Re: CarbonData propose major version number increment for next version (to 1.0.0)

2016-11-27 Thread Vimal Das Kammath
+1 -vimal On Nov 23, 2016 9:39 PM, "Venkata Gollamudi" wrote: > Hi All, > > CarbonData 0.2.0 has been a good work and stable release with lot of > defects fixed and with number of performance improvements. >

Re: [Feature ]Design Document for Update/Delete support in CarbonData

2016-11-22 Thread Vimal Das Kammath
Hi Aniket, The design looks sound and the documentation is great. I have few suggestions. 1) Measure update vs dimension update : In case of dimension update. for example user wants to change dept1 to dept2 for all users who are under dept1. Can we just update the dictionary for faster

Re: [VOTE] Apache CarbonData 0.2.0-incubating release

2016-11-09 Thread Vimal Das Kammath
+1 -Vimal On Nov 10, 2016 4:47 AM, "Liang Chen" wrote: > Hi all, > > I submit the CarbonData 0.2.0-incubating to your vote. > > Release Notes: > https://issues.apache.org/jira/secure/ReleaseNote.jspa? > projectId=12320220=12337896 > > Staging Repository: >

Re: please vote and comment: remove thrift solution

2016-10-24 Thread Vimal Das Kammath
+1 for directly using java code to build. At the same time, we should have the CI infrastructure to ensure that the .thrift files and the generated source code are always in sync. Regards Vimal On Mon, Oct 24, 2016 at 2:09 PM, Liang Chen wrote: > Hi > > I prefer to the

[GitHub] incubator-carbondata pull request #231: [CARBONDATA-311]Log the data size of...

2016-10-17 Thread Vimal-Das
Github user Vimal-Das commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/231#discussion_r83780338 --- Diff: processing/src/main/java/org/apache/carbondata/processing/store/writer/CarbonFactDataWriterImplForIntIndexAndAggBlock.java

Re: Discussion(New feature) Support Complex Data Type: Map in Carbon Data

2016-10-17 Thread Vimal Das Kammath
iki.apache.org/confluence/display/ > CARBONDATA/CarbonData+Home > > Regards > Liang > > > Vimal Das Kammath wrote > > Hi All, > > > > This discussion is regarding support for Map Data type in Carbon Data. > > > > Carbon Data supports complex and nested d

Discussion(New feature) Support Complex Data Type: Map in Carbon Data

2016-10-15 Thread Vimal Das Kammath
Hi All, This discussion is regarding support for Map Data type in Carbon Data. Carbon Data supports complex and nested data types such as Arrays and Struts. However, Carbon Data does not support other complex data types such as Maps and Union which are generally supported by popular opensource

Re: [Discussion] Code generation in carbon result preparation

2016-10-14 Thread Vimal Das Kammath
Hi Vishal, I think, we need both solution 1 & 2 Solution1 may need re-desiging several parts of Carbon's query process starting from scanner, aggregator to result preparation. This can help avoid the frequent cache invalidation. In Solution2 code generation will not solve the frequent cache

Re: Disscusion shall CI support run carbondata based on multi version spark?

2016-10-14 Thread Vimal Das Kammath
Yes, I Agree. CI should be configured to build Carbon on different spark versions. On Fri, Oct 14, 2016 at 7:56 AM, Liang Chen wrote: > > Yes, need to solve it , the CI should support different spark version. > > Regards > Liang > > > zhujin wrote > > One issue: > > I

[GitHub] incubator-carbondata pull request #123: [CARBONDATA-204] Clear queryStatisti...

2016-09-05 Thread Vimal-Das
Github user Vimal-Das commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/123#discussion_r77496731 --- Diff: core/src/main/java/org/apache/carbondata/core/carbon/querystatistics/DriverQueryStatisticsRecorder.java --- @@ -78,106 +83,148

[GitHub] incubator-carbondata pull request #123: [CARBONDATA-204] Clear queryStatisti...

2016-09-03 Thread Vimal-Das
Github user Vimal-Das commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/123#discussion_r77435578 --- Diff: core/src/main/java/org/apache/carbondata/core/carbon/querystatistics/DriverQueryStatisticsRecorder.java --- @@ -78,106 +82,142

[GitHub] incubator-carbondata pull request #123: [CARBONDATA-204] Clear queryStatisti...

2016-09-03 Thread Vimal-Das
Github user Vimal-Das commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/123#discussion_r77435539 --- Diff: core/src/main/java/org/apache/carbondata/core/carbon/querystatistics/DriverQueryStatisticsRecorder.java --- @@ -78,106 +82,142

[GitHub] incubator-carbondata pull request #110: [CARBONDATA-193]Fix the bug that neg...

2016-08-31 Thread Vimal-Das
Github user Vimal-Das commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/110#discussion_r76929816 --- Diff: core/src/main/java/org/apache/carbondata/core/util/ValueCompressionUtil.java --- @@ -78,26 +78,26 @@ private ValueCompressionUtil

[GitHub] incubator-carbondata pull request #92: [CARBONDATA-176] Deletion of compacte...

2016-08-27 Thread Vimal-Das
Github user Vimal-Das commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/92#discussion_r76516430 --- Diff: processing/src/main/java/org/apache/carbondata/lcm/status/SegmentStatusManager.java --- @@ -410,6 +410,14 @@ public void

[GitHub] incubator-carbondata pull request #95: [CARBONDATA-152]Double min max differ...

2016-08-27 Thread Vimal-Das
Github user Vimal-Das commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/95#discussion_r76512976 --- Diff: core/src/main/java/org/apache/carbondata/core/datastorage/store/compression/type/UnCompressNonDecimalMaxMinFloat.java --- @@ -98,7

[GitHub] incubator-carbondata pull request #95: [CARBONDATA-152]Double min max differ...

2016-08-27 Thread Vimal-Das
Github user Vimal-Das commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/95#discussion_r76512979 --- Diff: core/src/main/java/org/apache/carbondata/core/datastorage/store/compression/type/UnCompressNonDecimalMaxMinInt.java --- @@ -93,7

[GitHub] incubator-carbondata pull request #95: [CARBONDATA-152]Double min max differ...

2016-08-27 Thread Vimal-Das
Github user Vimal-Das commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/95#discussion_r76512974 --- Diff: core/src/main/java/org/apache/carbondata/core/datastorage/store/compression/type/UnCompressNonDecimalMaxMinDefault.java

[GitHub] incubator-carbondata pull request #97: [CARBONDATA-180]give proper error mes...

2016-08-27 Thread Vimal-Das
Github user Vimal-Das commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/97#discussion_r76512936 --- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/util/GlobalDictionaryUtil.scala --- @@ -689,6 +689,10 @@ object

Re: [VOTE] Apache CarbonData 0.1.0-incubating release

2016-08-20 Thread Vimal Das Kammath
+1 (binding) On Aug 20, 2016 12:27 AM, "Jean-Baptiste Onofré" wrote: > Hi all, > > I submit the first CarbonData release to your vote. > > Release Notes: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?proje > ctId=12320220=12337895 > > Staging Repository: >

Re: Open discussion and Vote: What kind of JIRA issue events need send mail to dev@carbondata.incubator.apache.org

2016-08-19 Thread Vimal Das Kammath
+1 for option 2 On Aug 19, 2016 6:36 AM, "chenliang613" wrote: > Hi > > I agree Henry's proposal. > > Issue Created, send mails to dev@mailing list > Issue Created and all other JIRA events send mails to new mailing list at > issues@mailing list. > > > Regards > Liang >

Re: [PROPOSAL] How to merge a pull request

2016-08-10 Thread Vimal Das Kammath
+1 Great idea, Having it as a tool as Henry suggested would definitely make life easier. On Wed, Aug 10, 2016 at 12:29 PM, Jihong Ma wrote: > +1 > > Great idea and I am sure it will make our life a lot easier as committer!! > > Jihong > > Sent from HUAWEI AnyOffice >