[GitHub] incubator-carbondata pull request #93: [CARBONDATA-177] Greater than and Les...

2016-08-30 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-carbondata/pull/93


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-carbondata pull request #106: [CARBONDATA-160]Data mismatch issue ...

2016-08-30 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-carbondata/pull/106


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-carbondata pull request #110: [wip][CARBONDATA-193]Fix the bug tha...

2016-08-30 Thread Zhangshunyu
GitHub user Zhangshunyu opened a pull request:

https://github.com/apache/incubator-carbondata/pull/110

[wip][CARBONDATA-193]Fix the bug that negative data compress is not 
properly when datatype is Double

## Why raise this pr?
**Fix bug: negative data compress is not properly when datatype is Double.**
For example, If the column datatype is double and it data is like this:
-7489.7976
-11234567490
-11234567490
-1.2
-2
-11234567490
-11234567490
-11234567490
-11234567490
**the query result would be all 0, this is a bug.**
## How to solve?
This bug is becasue we only consider the MAX value of this column is 
+values, and conpare it wll Byte.MAXCVALUE, here is 127. But when the values is 
-12343554634645, it also < Byte.MAXVALUE, but we can not use byte, becasue it < 
-127, so we should consider both Byte.MAXVALUE and Byte.MINVALUE, the same to 
other datatype.
How to test?
Added test case: test("When the values of Double datatype are negative 
values"), should pass all the exist cases and this new testcase.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Zhangshunyu/incubator-carbondata double92

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-carbondata/pull/110.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #110


commit 5773928ff7c7867a1925ce258fb2b57bc49513b6
Author: Zhangshunyu 
Date:   2016-08-31T01:34:12Z

Fix the bug that negtive data compress is not properly when datatype is 
Double




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (CARBONDATA-193) Data is not loading properly when double data type is having negative values

2016-08-30 Thread zhangshunyu (JIRA)
zhangshunyu created CARBONDATA-193:
--

 Summary: Data is not loading properly when double data type is 
having negative values
 Key: CARBONDATA-193
 URL: https://issues.apache.org/jira/browse/CARBONDATA-193
 Project: CarbonData
  Issue Type: Bug
Reporter: zhangshunyu


For example:
-7489.797600
-11234567489.797
-11234567489.7
-1.2
-2
-11234567489.797600
-11234567489.797600
-11234567489.797600
-11234567489.797600
would be all 0 after query



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] incubator-carbondata pull request #102: [CARBONDATA-186] Except compaction a...

2016-08-30 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-carbondata/pull/102


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-carbondata pull request #109: [CARBONDATA-192] Invalidating the ta...

2016-08-30 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-carbondata/pull/109


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-carbondata pull request #97: [CARBONDATA-180]give proper error mes...

2016-08-30 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-carbondata/pull/97


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-carbondata pull request #107: [CARBONDATA-191]Fix bug when quote c...

2016-08-30 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request:

https://github.com/apache/incubator-carbondata/pull/107#discussion_r76787331
  
--- Diff: 
integration/spark/src/test/scala/org/apache/carbondata/integration/spark/testsuite/dataload/TestLoadDataWithSingleQuotechar.scala
 ---
@@ -0,0 +1,60 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.carbondata.integration.spark.testsuite.dataload
+
+import org.apache.spark.sql.{DataFrame, Row}
+import org.apache.spark.sql.common.util.CarbonHiveContext._
+import org.apache.spark.sql.common.util.QueryTest
+import org.scalatest.BeforeAndAfterAll
+
+/**
+ * Test Class for data loading when there is single quote in fact data
+ *
+ */
+class TestLoadDataWithSingleQuotechar extends QueryTest with 
BeforeAndAfterAll {
+  override def beforeAll {
+sql("DROP TABLE IF EXISTS carbontable")
+sql(
+  "CREATE TABLE carbontable (id Int, name String) STORED BY 
'carbondata'")
+  }
+
+  test("test data loading with single quote char") {
+try {
+  sql(
+"LOAD DATA LOCAL INPATH 
'./src/test/resources/dataWithSingleQuote.csv' INTO TABLE " +
+  "carbontable OPTIONS('DELIMITER'= ',')")
+  checkAnswer(
+sql("SELECT * from carbontable"),
+Seq(Row("Tom",1),
+  Row("Tony\n3,Lily",2),
+  Row("Games\"",4),
+  Row("prival\"\n6,\"hello\"",5)
+)
--- End diff --

@Jay357089 ...Please perform the below mentioned activities.
1. Can you test the same scenario with same set of data in spark and hive 
to check their behavior and paste the result screenshot here.
2. What about cases when instead of default escape character (\), some 
other escape character is given (like @, ^, /, etc)? Test with some other 
escape characters in carbon, spark and hive and verify that behavior is same 
everywhere and paste the snapshots here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-carbondata pull request #106: [CARBONDATA-160]Data mismatch issue ...

2016-08-30 Thread kumarvishal09
Github user kumarvishal09 commented on a diff in the pull request:

https://github.com/apache/incubator-carbondata/pull/106#discussion_r76785449
  
--- Diff: 
core/src/main/java/org/apache/carbondata/scan/filter/FilterUtil.java ---
@@ -57,7 +68,17 @@
 import org.apache.carbondata.scan.expression.conditional.ListExpression;
 import 
org.apache.carbondata.scan.expression.exception.FilterIllegalMemberException;
 import 
org.apache.carbondata.scan.expression.exception.FilterUnsupportedException;
-import org.apache.carbondata.scan.filter.executer.*;
+import org.apache.carbondata.scan.filter.executer.AndFilterExecuterImpl;
--- End diff --

ok


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-carbondata pull request #106: [CARBONDATA-160]Data mismatch issue ...

2016-08-30 Thread ravipesala
Github user ravipesala commented on a diff in the pull request:

https://github.com/apache/incubator-carbondata/pull/106#discussion_r76784836
  
--- Diff: 
core/src/main/java/org/apache/carbondata/scan/filter/FilterUtil.java ---
@@ -623,9 +655,11 @@ public static DimColumnFilterInfo 
getFilterListForAllMembersRS(Expression expres
 if (null != dimColumnFilterInfo) {
   for (Integer surrogate : dimColumnFilterInfo.getFilterList()) {
 try {
-  keys[carbonDimension.getKeyOrdinal()] = surrogate;
-  filterValuesList
-  .add(getMaskedKey(rangesForMaskedByte, 
blockLevelKeyGenerator.generateKey(keys)));
+  if (surrogate <= 
dimColumnsCardinality[carbonDimension.getKeyOrdinal()]) {
+keys[carbonDimension.getKeyOrdinal()] = surrogate;
+filterValuesList
+.add(getMaskedKey(rangesForMaskedByte, 
blockLevelKeyGenerator.generateKey(keys)));
+  }
--- End diff --

Please break the loop if it greater since the surrogates are always in 
sorted order here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Podling Report Reminder - September 2016

2016-08-30 Thread johndament
Dear podling,

This email was sent by an automated system on behalf of the Apache
Incubator PMC. It is an initial reminder to give you plenty of time to
prepare your quarterly board report.

The board meeting is scheduled for Wed, 21 September 2016, 10:30 am PDT.
The report for your podling will form a part of the Incubator PMC
report. The Incubator PMC requires your report to be submitted 2 weeks
before the board meeting, to allow sufficient time for review and
submission (Wed, September 07).

Please submit your report with sufficient time to allow the Incubator
PMC, and subsequently board members to review and digest. Again, the
very latest you should submit your report is 2 weeks prior to the board
meeting.

Thanks,

The Apache Incubator PMC

Submitting your Report

--

Your report should contain the following:

*   Your project name
*   A brief description of your project, which assumes no knowledge of
the project or necessarily of its field
*   A list of the three most important issues to address in the move
towards graduation.
*   Any issues that the Incubator PMC or ASF Board might wish/need to be
aware of
*   How has the community developed since the last report
*   How has the project developed since the last report.

This should be appended to the Incubator Wiki page at:

http://wiki.apache.org/incubator/September2016

Note: This is manually populated. You may need to wait a little before
this page is created from a template.

Mentors
---

Mentors should review reports for their project(s) and sign them off on
the Incubator wiki page. Signing off reports shows that you are
following the project - projects that are not signed may raise alarms
for the Incubator PMC.

Incubator PMC


[GitHub] incubator-carbondata pull request #91: [WIP] Add performance statistics logs...

2016-08-30 Thread kumarvishal09
Github user kumarvishal09 commented on a diff in the pull request:

https://github.com/apache/incubator-carbondata/pull/91#discussion_r76760660
  
--- Diff: 
core/src/main/java/org/apache/carbondata/scan/result/iterator/DetailQueryResultIterator.java
 ---
@@ -45,10 +47,28 @@
 
   public DetailQueryResultIterator(List infos, 
QueryModel queryModel) {
 super(infos, queryModel);
+this.queryModel = queryModel;
+  }
+
+  private Boolean flag;
+
+  private Long total = 0L;
+
+  private QueryModel queryModel;
+
+  @Override public boolean hasNext() {
+flag = super.hasNext();
+if(!flag && total > 0) {
--- End diff --

why total >0 check is required? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-carbondata pull request #91: [WIP] Add performance statistics logs...

2016-08-30 Thread kumarvishal09
Github user kumarvishal09 commented on a diff in the pull request:

https://github.com/apache/incubator-carbondata/pull/91#discussion_r76760563
  
--- Diff: 
core/src/main/java/org/apache/carbondata/scan/result/iterator/DetailQueryResultIterator.java
 ---
@@ -45,10 +47,28 @@
 
   public DetailQueryResultIterator(List infos, 
QueryModel queryModel) {
 super(infos, queryModel);
+this.queryModel = queryModel;
+  }
+
+  private Boolean flag;
+
+  private Long total = 0L;
--- End diff --

Why wrapper Long is required why not primitive long ? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-carbondata pull request #91: [WIP] Add performance statistics logs...

2016-08-30 Thread kumarvishal09
Github user kumarvishal09 commented on a diff in the pull request:

https://github.com/apache/incubator-carbondata/pull/91#discussion_r76760461
  
--- Diff: 
core/src/main/java/org/apache/carbondata/scan/result/iterator/DetailQueryResultIterator.java
 ---
@@ -45,10 +47,28 @@
 
   public DetailQueryResultIterator(List infos, 
QueryModel queryModel) {
 super(infos, queryModel);
+this.queryModel = queryModel;
+  }
+
+  private Boolean flag;
+
+  private Long total = 0L;
+
+  private QueryModel queryModel;
+
+  @Override public boolean hasNext() {
+flag = super.hasNext();
--- End diff --

why we are overriding hasnext?? We can handle this in super class 
AbstractDetailQueryResultIterator 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-carbondata pull request #91: [WIP] Add performance statistics logs...

2016-08-30 Thread kumarvishal09
Github user kumarvishal09 commented on a diff in the pull request:

https://github.com/apache/incubator-carbondata/pull/91#discussion_r76758327
  
--- Diff: 
core/src/main/java/org/apache/carbondata/core/carbon/querystatistics/QueryStatisticsRecorder.java
 ---
@@ -61,14 +67,275 @@ public QueryStatisticsRecorder(String queryId) {
*/
   public synchronized void recordStatistics(QueryStatistic statistic) {
 queryStatistics.add(statistic);
+// refresh query Statistics Map
+String key = statistic.getQueryId();
+if (!StringUtils.isEmpty(key)) {
+  // 240954528274124_0 and 240954528274124 is the same query id
+  key = key.substring(0, 15);
+}
+if (queryStatisticsMap.get(key) != null) {
--- End diff --

query id is not based on segment it is based on task 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-carbondata pull request #91: [WIP] Add performance statistics logs...

2016-08-30 Thread foryou2030
Github user foryou2030 commented on a diff in the pull request:

https://github.com/apache/incubator-carbondata/pull/91#discussion_r76754835
  
--- Diff: 
core/src/main/java/org/apache/carbondata/core/carbon/querystatistics/QueryStatisticsRecorder.java
 ---
@@ -61,14 +67,275 @@ public QueryStatisticsRecorder(String queryId) {
*/
   public synchronized void recordStatistics(QueryStatistic statistic) {
 queryStatistics.add(statistic);
+// refresh query Statistics Map
+String key = statistic.getQueryId();
+if (!StringUtils.isEmpty(key)) {
+  // 240954528274124_0 and 240954528274124 is the same query id
+  key = key.substring(0, 15);
+}
+if (queryStatisticsMap.get(key) != null) {
--- End diff --

i think 240954528274124_0  means queryid for each segment? yes?
each executor will print whole time for all segment 
if we have 3 executors, 2 segments, print like:
executor1 log:
|++ +--+
|| Dictionary load| | 0.002  0.001 |
|++ +--+

executor 2 log:
|++ +--+
|| Dictionary load| | 0.003  0.002 |
|++ +--+

executor3 log:
|++ +--+
|| Dictionary load| | 0.001  0.003 |
|++ +--+


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-carbondata pull request #91: [WIP] Add performance statistics logs...

2016-08-30 Thread kumarvishal09
Github user kumarvishal09 commented on a diff in the pull request:

https://github.com/apache/incubator-carbondata/pull/91#discussion_r76752133
  
--- Diff: 
core/src/main/java/org/apache/carbondata/core/carbon/querystatistics/QueryStatisticsRecorder.java
 ---
@@ -61,14 +67,275 @@ public QueryStatisticsRecorder(String queryId) {
*/
   public synchronized void recordStatistics(QueryStatistic statistic) {
 queryStatistics.add(statistic);
+// refresh query Statistics Map
+String key = statistic.getQueryId();
+if (!StringUtils.isEmpty(key)) {
+  // 240954528274124_0 and 240954528274124 is the same query id
+  key = key.substring(0, 15);
+}
+if (queryStatisticsMap.get(key) != null) {
+  queryStatisticsMap.get(key).add(statistic);
+} else {
+  List newQueryStatistics = new 
ArrayList();
+  newQueryStatistics.add(statistic);
+  queryStatisticsMap.put(key, newQueryStatistics);
+}
   }
 
   /**
* Below method will be used to log the statistic
*/
   public void logStatistics() {
 for (QueryStatistic statistic : queryStatistics) {
-  LOGGER.statistic(statistic.getStatistics(queryIWthTask));
+  LOGGER.statistic(statistic.getStatistics());
+}
+  }
+
+  /**
+   * Below method will be used to show statistic log as table
+   */
+  public void logStatisticsTable() {
+String tableInfo = putStatisticsIntoTable();
+if (null != tableInfo) {
+  LOGGER.statistic(tableInfo);
+}
+  }
+
+  /**
+   * Below method will parse queryStatisticsMap and put time into table
+   */
+  public String putStatisticsIntoTable() {
+for (String key: queryStatisticsMap.keySet()) {
+  try {
+// TODO: get the finished query, and print Statistics
+if (queryStatisticsMap.get(key).size() > 8) {
+  String jdbc_connection_time = "";
+  String sql_parse_time = "";
+  String load_meta_time = "";
+  String block_identification_time = "";
+  String schedule_time = "";
+  String driver_part_time = "";
+  String executor_part_time = "";
+  String load_index_time = "";
+  String scan_data_time = "";
+  String dictionary_load_time = "";
--- End diff --

dictionary loading time required in both the side executor and driver, 
please add in driver side 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-carbondata pull request #91: [WIP] Add performance statistics logs...

2016-08-30 Thread kumarvishal09
Github user kumarvishal09 commented on a diff in the pull request:

https://github.com/apache/incubator-carbondata/pull/91#discussion_r76751950
  
--- Diff: 
core/src/main/java/org/apache/carbondata/core/carbon/querystatistics/QueryStatisticsRecorder.java
 ---
@@ -61,14 +67,275 @@ public QueryStatisticsRecorder(String queryId) {
*/
   public synchronized void recordStatistics(QueryStatistic statistic) {
 queryStatistics.add(statistic);
+// refresh query Statistics Map
+String key = statistic.getQueryId();
+if (!StringUtils.isEmpty(key)) {
+  // 240954528274124_0 and 240954528274124 is the same query id
+  key = key.substring(0, 15);
+}
+if (queryStatisticsMap.get(key) != null) {
+  queryStatisticsMap.get(key).add(statistic);
+} else {
+  List newQueryStatistics = new 
ArrayList();
+  newQueryStatistics.add(statistic);
+  queryStatisticsMap.put(key, newQueryStatistics);
+}
   }
 
   /**
* Below method will be used to log the statistic
*/
   public void logStatistics() {
 for (QueryStatistic statistic : queryStatistics) {
-  LOGGER.statistic(statistic.getStatistics(queryIWthTask));
+  LOGGER.statistic(statistic.getStatistics());
+}
+  }
+
+  /**
+   * Below method will be used to show statistic log as table
+   */
+  public void logStatisticsTable() {
+String tableInfo = putStatisticsIntoTable();
+if (null != tableInfo) {
+  LOGGER.statistic(tableInfo);
+}
+  }
+
+  /**
+   * Below method will parse queryStatisticsMap and put time into table
+   */
+  public String putStatisticsIntoTable() {
+for (String key: queryStatisticsMap.keySet()) {
+  try {
+// TODO: get the finished query, and print Statistics
+if (queryStatisticsMap.get(key).size() > 8) {
+  String jdbc_connection_time = "";
+  String sql_parse_time = "";
+  String load_meta_time = "";
+  String block_identification_time = "";
+  String schedule_time = "";
+  String driver_part_time = "";
+  String executor_part_time = "";
+  String load_index_time = "";
--- End diff --

change load_index_time to block loading time 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-carbondata pull request #82: [CARBONDATA-165] Support loading fact...

2016-08-30 Thread QiangCai
Github user QiangCai commented on a diff in the pull request:

https://github.com/apache/incubator-carbondata/pull/82#discussion_r76749797
  
--- Diff: 
integration/spark/src/main/scala/org/apache/carbondata/spark/util/GlobalDictionaryUtil.scala
 ---
@@ -736,27 +761,20 @@ object GlobalDictionaryUtil extends Logging {
 logInfo("Generate global dictionary from all dictionary files!")
 val isNonempty = validateAllDictionaryPath(allDictionaryPath)
 if(isNonempty) {
-  // fill the map[columnIndex -> columnName]
-  var fileHeaders : Array[String] = null
-  if(!StringUtils.isEmpty(carbonLoadModel.getCsvHeader)) {
-val splitColumns = carbonLoadModel.getCsvHeader.split("" + 
CSVWriter.DEFAULT_SEPARATOR)
-val fileHeadersArr = new ArrayBuffer[String]()
-for(i <- 0 until splitColumns.length) {
-  fileHeadersArr += splitColumns(i).trim.toLowerCase()
-}
-fileHeaders = fileHeadersArr.toArray
+  var headers = if 
(StringUtils.isEmpty(carbonLoadModel.getCsvHeader)) {
+getHeaderFormFactFile(carbonLoadModel)
   } else {
-logError("Not found file header! Please set fileheader")
-throw new IOException("Failed to get file header")
+carbonLoadModel.getCsvHeader.toLowerCase.split("" + 
CSVWriter.DEFAULT_SEPARATOR)
   }
+  headers = headers.map(headerName => headerName.trim)
--- End diff --

headers = headers.map(_)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-carbondata pull request #100: Handle all dictionary exception more...

2016-08-30 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-carbondata/pull/100


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-carbondata pull request #82: [CARBONDATA-165] Support loading fact...

2016-08-30 Thread foryou2030
Github user foryou2030 commented on a diff in the pull request:

https://github.com/apache/incubator-carbondata/pull/82#discussion_r76740663
  
--- Diff: 
integration/spark/src/main/scala/org/apache/carbondata/spark/util/GlobalDictionaryUtil.scala
 ---
@@ -650,6 +650,51 @@ object GlobalDictionaryUtil extends Logging {
   }
 
   /**
+   * get file headers from fact file
+   *
+   * @param carbonLoadModel
+   * @return headers
+   */
+  private def getHeaderFormFactFile(carbonLoadModel: CarbonLoadModel): 
Array[String] = {
+var headers: Array[String] = null
+var factFile: String = null
+val fileType = FileFactory.getFileType(carbonLoadModel.getFactFilePath)
+val filePath = 
FileFactory.getCarbonFile(carbonLoadModel.getFactFilePath, fileType)
+if (filePath.isDirectory) {
+  val listFiles = filePath.getParentFile.listFiles()
--- End diff --

ok, thanks @QiangCai @manishgupta88 
i have handled



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (CARBONDATA-192) Invalidate table from hive context while dropping the table

2016-08-30 Thread Manohar Vanam (JIRA)
Manohar Vanam created CARBONDATA-192:


 Summary: Invalidate table from hive context while dropping the 
table
 Key: CARBONDATA-192
 URL: https://issues.apache.org/jira/browse/CARBONDATA-192
 Project: CarbonData
  Issue Type: Bug
Reporter: Manohar Vanam
Assignee: Manohar Vanam


Create  table table1
load table1
select * from table1
drop table1

create same table table1
load table1
select * from table1

throws exception

Invalidate table from hive context while dropping the table



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)