[jira] [Created] (CARBONDATA-234) wrong message is printed in the logs each time when the compaction is done.

[ravikiran (JIRA)]

ravikiran created CARBONDATA-234:


 Summary: wrong message is printed in the logs each time when the 
compaction is done.
 Key: CARBONDATA-234
 URL: https://issues.apache.org/jira/browse/CARBONDATA-234
 Project: CarbonData
  Issue Type: Bug
Reporter: ravikiran


wrong message is printed in the logs each time when the compaction is done.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] incubator-carbondata pull request #149: wrong message getting displayed whil...

[ravikiran23]

GitHub user ravikiran23 opened a pull request:

https://github.com/apache/incubator-carbondata/pull/149

wrong message getting displayed while compaction.

Why raise this pr?

for each compaction the error message "compaction request file can not be 
deleted " is printing even though it has been deleted from the file system.

How to resolve?

The return of the boolean value is missing in the API 
deleteCompactionRequiredFile(). Need to return the boolean value correctly for 
getting the delete status.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ravikiran23/incubator-carbondata WrongLogging

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-carbondata/pull/149.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #149


commit 9ba6891f81abd1e5e807ee3adeb024bb94ca413f
Author: ravikiran 
Date:   2016-09-08T15:55:44Z

correcting wrong logs.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-carbondata pull request #148: [CARBONDATA-233] bad record logger s...

[manishgupta88]

Github user manishgupta88 commented on a diff in the pull request:

https://github.com/apache/incubator-carbondata/pull/148#discussion_r78314030
  
--- Diff: 
processing/src/main/java/org/apache/carbondata/processing/surrogatekeysgenerator/csvbased/CarbonCSVBasedSeqGenStep.java
 ---
@@ -1133,6 +1149,9 @@ else if(isComplexTypeColumn[j]) {
   
.getDirectDictionaryGenerator(details.getColumnType());
   surrogateKeyForHrrchy[0] =
   
directDictionaryGenerator1.generateDirectSurrogateKey(tuple);
+  if (badRecordsLoggerEnable && surrogateKeyForHrrchy[0] == 1) 
{
+surrogateKeyForHrrchy[0] = -1;
--- End diff --

Replace -1 and 1 with proper identifiers from CarbonCommonConstants to give 
proper meaning and improve code readability


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (CARBONDATA-233) bad record logger support for non parsebale numeric and timestamp data

[Mohammad Shahid Khan (JIRA)]

Mohammad Shahid Khan created CARBONDATA-233:
---

 Summary: bad record logger support for non parsebale numeric and 
timestamp data
 Key: CARBONDATA-233
 URL: https://issues.apache.org/jira/browse/CARBONDATA-233
 Project: CarbonData
  Issue Type: Improvement
Reporter: Mohammad Shahid Khan
Assignee: Mohammad Shahid Khan


bad record logger support for non parsebale numeric and timestamp data



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)