wrote:
>
> > +1
> >
> > Great idea and I am sure it will make our life a lot easier as
> committer!!
> >
> > Jihong
> >
> > Sent from HUAWEI AnyOffice
> > From: Jacky Li
> > To: dev@carbondata.incubator.apache.org;
> > Subject: Re: [PROPOSAL
will make our life a lot easier as
> committer!!
> >
> > Jihong
> >
> > Sent from HUAWEI AnyOffice
> > From: Jacky Li
> > To: dev@carbondata.incubator.apache.org;
> > Subject: Re: [PROPOSAL] How to merge a pull request
> >
> > Time: 20
From: Jacky Li
> To: dev@carbondata.incubator.apache.org;
> Subject: Re: [PROPOSAL] How to merge a pull request
>
> Time: 2016-08-09 20:56:25
> definitely +1
>
>
> > 在 2016年8月9日，下午1:33，Jean-Baptiste Onofré 写道：
> >
> > Yes good idea.
> >
> > I&#
+1
Great idea and I am sure it will make our life a lot easier as committer!!
Jihong
Sent from HUAWEI AnyOffice
From: Jacky Li
To: dev@carbondata.incubator.apache.org;
Subject: Re: [PROPOSAL] How to merge a pull request
Time: 2016-08-09 20:56:25
definitely +1
> 在 2016年8月9日，下午1:33，J
definitely +1
> 在 2016年8月9日，下午1:33，Jean-Baptiste Onofré 写道：
>
> Yes good idea.
>
> I'm thinking about a github PR template too as we use in Beam.
>
> Regards
> JB
>
> On 08/09/2016 07:31 AM, Henry Saputra wrote:
>> This is great stuff, thanks for taking stab at it, JB.
>>
>> I would reccomm
Yes good idea.
I'm thinking about a github PR template too as we use in Beam.
Regards
JB
On 08/09/2016 07:31 AM, Henry Saputra wrote:
This is great stuff, thanks for taking stab at it, JB.
I would reccommend we add tool in the source code to help committers merge
PRs.
Some projects like Apac
This is great stuff, thanks for taking stab at it, JB.
I would reccommend we add tool in the source code to help committers merge
PRs.
Some projects like Apache Spark [1] and Apache Flink have simple script to
help automate the process.
We could adopt the script to do similar thing for CarbonData
+1
--
View this message in context:
http://apache-carbondata-mailing-list-archive.1130556.n5.nabble.com/PROPOSAL-How-to-merge-a-pull-request-tp18p22.html
Sent from the Apache CarbonData Mailing List archive mailing list archive at
Nabble.com.
Hi guys,
I discussed with Ravi how to cleanly merge a pull request, eventually
applying changes, keeping the original commit author, etc.
I proposed a procedure:
https://github.com/apache/incubator-carbondata/pull/63#issuecomment-237817370
For convenience, let me paste the proposal here:
Pr
