Re: Timeout unit tests in trunk

2018-02-27 Thread Dikang Gu
Cool, I think I fixed the ViewTest by changing from updateView("TRUNCATE %s") to execute("TRUNCATE %s"). I also split it into several smaller unit tests. Patch is here: https://issues.apache.org/jira/browse/CASSANDRA-14280 I haven't got time to look into BatchMetricsTest yet. Thanks Dikang. On

Re: Timeout unit tests in trunk

2018-02-27 Thread Jason Brown
All, As @kjellman pointed out, the timeouts on ViewTest & ViewBuilderTaskTest are being addressed in CASSANDRA-14194 (I have a patch, almost ready to release). @dikang if you want to refactor those tests for fun, go for it - but note that th

Re: Action Required: We are sunsetting CircleCI 1.0 on August 31, 2018

2018-02-27 Thread Michael Kjellman
2.2: yes 2.1: no. i don't think it's worth the effort to get it working on 2.1 at this point -- and i hope we've fully moved on from 2.1 by August 31, 2018 ;) > On Feb 27, 2018, at 5:35 PM, kurt greaves wrote: > > Not that much gets committed to 2.1 and 2.2 anymore, but is this also true > for

Re: Action Required: We are sunsetting CircleCI 1.0 on August 31, 2018

2018-02-27 Thread kurt greaves
Not that much gets committed to 2.1 and 2.2 anymore, but is this also true for those branches? On 27 February 2018 at 22:58, Michael Kjellman wrote: > FYI: we're already fully on circleci 2.0 for the 3.0, 3.11, and trunk > branches so no action required for us here! > > best, > kjellman > > Begi

Re: Timeout unit tests in trunk

2018-02-27 Thread Dinesh Joshi
Yes, give it a go. I am not 100% sure if it will help a whole lot but try it out and let's see what happens! Dinesh On Tuesday, February 27, 2018, 2:57:41 PM PST, Dikang Gu wrote: I took some look at the cql3.ViewTest, it seems too big and timeout very often. Any objections if I split

Re: Timeout unit tests in trunk

2018-02-27 Thread Michael Kjellman
i've seen it timeout a lot too. if you think breaking it up will fix it that definitely sounds like a good approach! > On Feb 27, 2018, at 2:57 PM, Dikang Gu wrote: > > I took some look at the cql3.ViewTest, it seems too big and timeout very > often. Any objections if I split it into two or mul

Fwd: Action Required: We are sunsetting CircleCI 1.0 on August 31, 2018

2018-02-27 Thread Michael Kjellman
FYI: we're already fully on circleci 2.0 for the 3.0, 3.11, and trunk branches so no action required for us here! best, kjellman Begin forwarded message: From: The CircleCI Team mailto:no-re...@circleci.com>> Subject: Action Required: We are sunsetting CircleCI 1.0 on August 31, 2018 Date: Febr

Re: Timeout unit tests in trunk

2018-02-27 Thread Dikang Gu
I took some look at the cql3.ViewTest, it seems too big and timeout very often. Any objections if I split it into two or multiple tests? On Tue, Feb 27, 2018 at 1:32 PM, Michael Kjellman wrote: > well, turns out we already have a jira tracking the MV tests being broken > on trunk. they are legit

Re: Expensive metrics?

2018-02-27 Thread Nate McCall
Hi Micke, There is some good research in here - have you had a chance to create some issues in Jira from this? On Fri, Feb 23, 2018 at 6:28 AM, Michael Burman wrote: > Hi, > > I was referring to this article by Shipilev (there are few small issues > forgotten in that url you pasted): > > https://

Re: Timeout unit tests in trunk

2018-02-27 Thread Michael Kjellman
well, turns out we already have a jira tracking the MV tests being broken on trunk. they are legit broken :) thanks jaso https://issues.apache.org/jira/browse/CASSANDRA-14194 not sure about the batch test timeout there though.. did you debug it at all by chance? On Feb 27, 2018, at 1:27 PM, M

Re: Timeout unit tests in trunk

2018-02-27 Thread Michael Kjellman
hey dikang: just chatted a little bit about this. proposal: let's add the equivalent of @resource_intensive to unit tests too.. and the first one is to stop from running the MV unit tests in the free circleci containers. thoughts? also, might want to bug your management to see if you can get som

Re: Timeout unit tests in trunk

2018-02-27 Thread Dinesh Joshi
Some tests might require additional resources to spin up the required components. 2 CPU / 4GB might not be sufficient. You may need to bump up the resources to 8CPU / 16GB. Dinesh On Tuesday, February 27, 2018, 11:24:34 AM PST, Dikang Gu wrote: Looks like there are a few flaky/timeou

Re: Design Proposal for Auditing feature in Cassandra

2018-02-27 Thread Vinay Kumar Chella
Hi Anuj, Thanks for the detailed design document. We had a similar requirement recently for our internal 2.1 clusters and we implemented a simple version (no "Separate Configuration for Whitelisted Users" etc…) for sox auditing. As your design is very close to what we implemented, just a few diffe

Timeout unit tests in trunk

2018-02-27 Thread Dikang Gu
Looks like there are a few flaky/timeout unit tests in trunk, wondering is there anyone looking at them already? testBuildRange - org.apache.cassandra.db.view.ViewBuilderTaskTest testUnloggedPartitionsPerBatch - org.apache.cassandra.metrics.BatchMetricsTest testViewBuilderResume - org.apache.cassa

Re: Design Proposal for Auditing feature in Cassandra

2018-02-27 Thread Dinesh Joshi
Hey Anuj, Thanks for submitting the patch. I am looking at the design. Will comment on the Jira with my feedback. Dinesh On Monday, February 26, 2018, 4:09:41 AM PST, Anuj Wadehra wrote: Hi, Apache Cassandra doesn't provides an auditing feature. As Database auditing is critical for a