+1 for a separate repository.
Michael
On 08/23/2018 07:30 PM, Murukesh Mohanan wrote:
> FWIW, I think it's possible to merge in a separate repository into a
> subdirectory while keeping git history, but I don't know if the other way
> will be possible if commits span other parts of the repo as
> However, in addition to using such a
> tool, I believe, when we make a release, we should build against the actual
> JDKs we support (that way, we are not making a release just based on the
> result of an external tool), and we should be able to optionally run UTs
> and DTests against the JDK
FWIW, I think it's possible to merge in a separate repository into a
subdirectory while keeping git history, but I don't know if the other way
will be possible if commits span other parts of the repo as well\* (which
will likely happen sooner or later). So a separate repo is a choice we can
+1 also for separate repo
> On 24 Aug 2018, at 01:11, Jeff Jirsa wrote:
>
> +1 for separate repo
>
>
> --
> Jeff Jirsa
>
>
>> On Aug 23, 2018, at 1:00 PM, sankalp kohli wrote:
>>
>> Separate repo is in a majority so far. Please reply to this thread with
>> your responses.
>>
>> On Tue,
+1 for separate repo
--
Jeff Jirsa
> On Aug 23, 2018, at 1:00 PM, sankalp kohli wrote:
>
> Separate repo is in a majority so far. Please reply to this thread with
> your responses.
>
> On Tue, Aug 21, 2018 at 4:34 PM Rahul Singh
> wrote:
>
>> +1 for separate repo. Especially on git.
Some of our java8 code will not compile under java11 (see CASSANDRA-9608);
the symbols have literally been removed (Unsafe.monitorEnter() /
Unsafe.monitorExit() ). Setting -source to "8" will not help. Thus, we need
two compilers for the foreseeable future.
On Thu, Aug 23, 2018 at 3:44 PM,
I am not against using a compile-time quick-feedback tool like Animal
Sniffer either. It is great to have such a tool to know of any obvious bad
changes right away during development. However, in addition to using such a
tool, I believe, when we make a release, we should build against the actual
Separate repo is in a majority so far. Please reply to this thread with
your responses.
On Tue, Aug 21, 2018 at 4:34 PM Rahul Singh
wrote:
> +1 for separate repo. Especially on git. Maybe make it a submodule.
>
> Rahul
> On Aug 21, 2018, 3:33 PM -0500, Stefan Podkowinski ,
> wrote:
> > I'm also
> > There's a cost-optimisation here in reducing what we have to support.
>
> I agree and animal sniffer is a great way to ferret out obvious issues.
> I am not against using animal sniffer. I'm concerned that there are
> various incompatibilities[1] between JDK versions and I am not 100%
>
> On Aug 22, 2018, at 7:23 PM, Mick Semb Wever wrote:
>
> There's a cost-optimisation here in reducing what we have to support.
I agree and animal sniffer is a great way to ferret out obvious issues. I am
not against using animal sniffer. I'm concerned that there are various
10 matches
Mail list logo
