Re: cassandra-stress HexStrings generator

2018-12-14 Thread Saleil Bhat (BLOOMBERG/ 731 LEX)
Main issue is resolved. The test I was using to determine normality was too sensitive to discretization, so it was yielding a negative result even though the data looked pretty normal on visual inspection. The tool only ever uses the Strings generator; HexStrings is unused. The only (minor)

Re: CASSANDRA-14925 DecimalSerializer.toString() can OOM

2018-12-14 Thread dinesh.jo...@yahoo.com.INVALID
I think it makes sticking to trunk as this change will affect log messages and may break tooling that depends on certain patterns. Dinesh On Friday, December 14, 2018, 4:09:51 PM GMT+5:30, Jasonstack Zhao Yang wrote: Hi, Would like to get some feedback for CASSANDRA-14925. In order

CASSANDRA-14925 DecimalSerializer.toString() can OOM

2018-12-14 Thread Jasonstack Zhao Yang
Hi, Would like to get some feedback for CASSANDRA-14925. In order to avoid potential OOM attack, we propose to change DecimalSerializer.toString() from `BigDecimal.toPlainString()` to `BigDecimal.toString()` on Trunk. This change should not cause any compatibility issues.. Thanks Zhao Yang

Re: Revisit the proposal to use github PR

2018-12-14 Thread Benedict Elliott Smith
So, without hopefully getting too dragged into this, I’m honestly not convinced that GitHub is so phenomenal for review. Though perhaps I just suck at the UX. - Missed notifications, to both me and seemingly Jira. Jira sometimes fails my personal email too, but commits@ can be relied upon. -