+1 to the guideline.
> > For the instance() / getInstance() methods - I know it is an additional
> effort, but on the other hand it has many advantages because you can
> replace the singleton for testing
>
> Again, do this as necessary. I think for public instances this is a fine
>
Congratulations Aleksandr! Thank you for your work on the project.
On Thu, 17 Mar 2022 at 12:33, Erick Ramirez
wrote:
> Congratulations Aleksandr and welcome aboard!
>
> On Thu, 17 Mar 2022 at 00:15, Benjamin Lerer wrote:
>
>> The PMC members are pleased to announce that Aleksandr Sorokoumov
Congratulations Aleksandr and welcome aboard!
On Thu, 17 Mar 2022 at 00:15, Benjamin Lerer wrote:
> The PMC members are pleased to announce that Aleksandr Sorokoumov has
> accepted
> the invitation to become committer.
>
> Thanks a lot, Aleksandr , for everything you have done for the
Congratulations Aleksandr!
On Wed, Mar 16, 2022 at 7:34 AM Andrés de la Peña
wrote:
> Congrats, well deserved!
>
> On Wed, 16 Mar 2022 at 14:01, J. D. Jordan
> wrote:
>
>> Congratulations!
>>
>> On Mar 16, 2022, at 8:43 AM, Ekaterina Dimitrova
>> wrote:
>>
>>
>> Great news! Well deserved!
Thank you Stefan for all the efforts!
Regarding the "merge strategy change", should we start a new thread?
I am +1 on adopting the merge button. It should work in the single branch
commit. Just the cross branch commit could be tricky.
- Yifan
Sounds good to me. Thanks for doing all this work, Stefan.
So, I went through all pull requests we have on GitHub manually (yes,
I did that, never more!) and out of ~550 PRs I managed to reduce it to
188 so I closed around 400 PRs.
All remaining PRs are of this nature:
1) Every PR has a name of "CASSANDRA-XYZ - description" or there is a
ticket number
Hi Paulo
Thanks for the feedback. If we do get the track accepted then we will
definitely be needing help reviewing the submissions - so may take you up on
your offer :-)
Thanks
Sharan
On 2022/03/14 16:32:23 Paulo Motta wrote:
> This Apachecon track sounds fun! I hope someone from the
Hi Chris
+1
This looks really good. I added a few comments and suggestions so feel free to
use what you think.
Thanks
Sharan
On 2022/03/15 21:16:34 Chris Thornett wrote:
> As requested, I'm posting content contributions for community review on the
> ML for those that might not spot them on
Congrats, well deserved!
On Wed, 16 Mar 2022 at 14:01, J. D. Jordan
wrote:
> Congratulations!
>
> On Mar 16, 2022, at 8:43 AM, Ekaterina Dimitrova
> wrote:
>
>
> Great news! Well deserved! Congrats and thank you for all your support!
>
> On Wed, 16 Mar 2022 at 9:41, Paulo Motta wrote:
>
>>
Congrats Aleks!
On Wed, 16 Mar 2022 at 22:01, J. D. Jordan
wrote:
> Congratulations!
>
> On Mar 16, 2022, at 8:43 AM, Ekaterina Dimitrova
> wrote:
>
>
> Great news! Well deserved! Congrats and thank you for all your support!
>
> On Wed, 16 Mar 2022 at 9:41, Paulo Motta wrote:
>
>>
In CASSANDRA-17445 we’ve started discussing the options of replacing the
deprecated airlift/airline framework used in CLI tools.
Considering the amount of commands this framework is used in, the impact this
might cause and the future possibilities the operational aspects of Cassandra
could
An easier fix here is just to put a close action into the commit message:
Closes #nnn
e.g.
https://github.com/apache/cassandra/commit/ad249424814836bd00f47931258ad58bfefb24fd
/ https://github.com/apache/cassandra/pull/1046
On Wed, Mar 16, 2022 at 5:40 AM Josh McKenzie wrote:
> I think the
Congratulations!
> On Mar 16, 2022, at 8:43 AM, Ekaterina Dimitrova
> wrote:
>
>
> Great news! Well deserved! Congrats and thank you for all your support!
>
>> On Wed, 16 Mar 2022 at 9:41, Paulo Motta wrote:
>> Congratulations Alex, well deserved! :-)
>>
>>> Em qua., 16 de mar. de 2022 às
Great news! Well deserved! Congrats and thank you for all your support!
On Wed, 16 Mar 2022 at 9:41, Paulo Motta wrote:
> Congratulations Alex, well deserved! :-)
>
> Em qua., 16 de mar. de 2022 às 10:15, Benjamin Lerer
> escreveu:
>
>> The PMC members are pleased to announce that Aleksandr
Congratulations Alex, well deserved! :-)
Em qua., 16 de mar. de 2022 às 10:15, Benjamin Lerer
escreveu:
> The PMC members are pleased to announce that Aleksandr Sorokoumov has
> accepted
> the invitation to become committer.
>
> Thanks a lot, Aleksandr , for everything you have done for the
The PMC members are pleased to announce that Aleksandr Sorokoumov has
accepted
the invitation to become committer.
Thanks a lot, Aleksandr , for everything you have done for the project.
Congratulations and welcome
The Apache Cassandra PMC members
+1
Kind Regards,
Brandon
On Tue, Mar 15, 2022 at 4:17 PM Chris Thornett wrote:
>
> As requested, I'm posting content contributions for community review on the
> ML for those that might not spot them on Slack.
>
> We're currently mid-review for our first contributor Q which is with Lorina
>
+1, let’s change our merge strategy
From: Josh McKenzie
Date: Wednesday, 16 March 2022 at 12:47
To: dev@cassandra.apache.org
Subject: Re: Using labels on pull requests in GitHub
I think the fact that they pile up is because our merge strategy means we don't
actually merge using the PR's we
I confess, I'm guilty as charged. I use the git CLI for everything else but
use the merge button on the web UI for convenience.
I think the fact that they pile up is because our merge strategy means we don't
actually merge using the PR's we use for review so there's nothing codified in
the workflow to close them out when a ticket's done.
An easy fix would be to change our merge strategy and use the merge button on
PR's
+1
On Wed, 16 Mar 2022 at 11:55, Anthony Grasso
wrote:
> +1
>
> On Wed, 16 Mar 2022 at 21:58, bened...@apache.org
> wrote:
>
>> +1
>>
>>
>>
>> *From: *Erick Ramirez
>> *Date: *Tuesday, 15 March 2022 at 22:08
>> *To: *dev@cassandra.apache.org
>> *Subject: *Re: [FOR REVIEW] Blog post: An
+1
On Wed, 16 Mar 2022 at 21:58, bened...@apache.org
wrote:
> +1
>
>
>
> *From: *Erick Ramirez
> *Date: *Tuesday, 15 March 2022 at 22:08
> *To: *dev@cassandra.apache.org
> *Subject: *Re: [FOR REVIEW] Blog post: An Interview with Project
> Contributor, Lorina Poland
>
> Looks good to me!
>
>
Thanks for doing this Stefan.
The fact that PRs are abandoned and piling up on github demonstrates a
hygiene problem and creates a bad user experience to newcomers which are
accustomed to the Github workflow. I'm supportive of any initiative to
improve this
I think starting labelling PRs
Since PRs are a second class citizen to Jira, mostly used for a scratch pad for
nits and questions with code context, I suspect any improvements here will need
to be automated to have any hope of success.
From: Stefan Miklosovic
Date: Wednesday, 16 March 2022 at 08:16
To:
+1
From: Erick Ramirez
Date: Tuesday, 15 March 2022 at 22:08
To: dev@cassandra.apache.org
Subject: Re: [FOR REVIEW] Blog post: An Interview with Project Contributor,
Lorina Poland
Looks good to me!
On Wed, 16 Mar 2022 at 08:17, Chris Thornett
mailto:ch...@constantia.io>> wrote:
As
Yeah, what I see quite frequently is that people come over, they open
PR but it does not have any related JIRA ticket and they just drop it
there and never return hence these PRs are in a constant limbo, not in
JIRA and they are more often than not left behind completely. Creating
categories would
+1 it's a great idea. I have to admit that I don't go through the PRs and I
only pay attention to tickets so if doc PRs are "orphans" (don't have
associated tickets), I don't ever work on them. I'll aim to do this when I
have bandwidth. Cheers!
On Wed, 16 Mar 2022 at 19:02, Stefan Miklosovic <
Hello,
Is somebody fundamentally opposing the idea of applying labels to pull
requests when applicable? I went through the pull requests and it
would be nice to have some basic filters, like "show me all pull
requests related to documentation" would be labeled as "docs", then
PRs fixing some
29 matches
Mail list logo
