Re: [DISCUSS] CEP-51: Support Include Semantics for cassandra.yaml

2025-09-12 Thread Jordan West
Following up on this. Sounds like we can take this to a vote? I’m happy to sheperd if another committee or PMC member is not available On Fri, Aug 1, 2025 at 01:46 Jeff Jirsa wrote: > Hey folks > > Helping nudge this along - any dissent? Anyone with concerns they’d like > addressed before we mov

Re: [DISCUSS] CEP-51: Support Include Semantics for cassandra.yaml

2025-07-31 Thread Jeff Jirsa
Hey folksHelping nudge this along - any dissent? Anyone with concerns they’d like addressed before we move towards a vote? - Jeff On Jul 26, 2025, at 12:35 PM, Ekaterina Dimitrova wrote:Hi,Just wanted to mention that we already have some config related to duplicate keys in cassandra.yaml. (That d

Re: [DISCUSS] CEP-51: Support Include Semantics for cassandra.yaml

2025-07-26 Thread Ekaterina Dimitrova
Hi, Just wanted to mention that we already have some config related to duplicate keys in cassandra.yaml. (That doesn’t mean we cannot extend/improve things further, of course) >From our docs: CASSANDRA-17379 was opened to improve the user ex

Re: [DISCUSS] CEP-51: Support Include Semantics for cassandra.yaml

2025-07-23 Thread Johnny Miller
That's a really good idea! I have updated the CEP to include this duplicate_key_policy functionality and corresponding test scenarios. On Tue, 22 Jul 2025 at 16:35, Patrick McFadin wrote: > Another hit from the DevOps request backlog. I'm glad this has > finally turned into something formal. Thi

Re: [DISCUSS] CEP-51: Support Include Semantics for cassandra.yaml

2025-07-22 Thread Patrick McFadin
Another hit from the DevOps request backlog. I'm glad this has finally turned into something formal. This will make CI/CD much easier. One thing I hope this fosters more of is the sharing of configs. For example, "here are my recommended storage settings for EBS." The CEP aborts on any duplicate k

Re: [DISCUSS] CEP-51: Support Include Semantics for cassandra.yaml

2025-07-21 Thread Josh McKenzie
> give us a minimally invasive way to support both through a transition. I'm caught up on the slack thread now; let's not even allude to nor discuss transitioning a default and just keep things constrained to adding new functionality and keeping it in sync. Don't want to derail things. On Mon, J

Re: [DISCUSS] CEP-51: Support Include Semantics for cassandra.yaml

2025-07-21 Thread Johnny Miller
I think that's worth getting done - it would be very handy! Maybe we can discuss it when implementing to figure out the way to do it? On Mon, 21 Jul 2025 at 16:02, Josh McKenzie wrote: > I suppose the only concern would be maintaining this version in alignment > with what's going into the main c

Re: [DISCUSS] CEP-51: Support Include Semantics for cassandra.yaml

2025-07-21 Thread Johnny Miller
Another possible idea for this - we could support env variables on the includes eg include_if_exists: conf/environments/${ENVIRONMENT}.yaml This would be quite useful I think? On Fri, 18 Jul 2025 at 19:57, Johnny Miller wrote: > Hello 👋 > > We would like to propose CEP-51: Support Include Sem

Re: [DISCUSS] CEP-51: Support Include Semantics for cassandra.yaml

2025-07-21 Thread Josh McKenzie
> I suppose the only concern would be maintaining this version in alignment > with what's going into the main cassandra.yaml as part of the regular > development. Seems like it'd be relatively easy to script something that'll generate modularized config files based on the reference cassandra.ya

Re: [DISCUSS] CEP-51: Support Include Semantics for cassandra.yaml

2025-07-21 Thread Johnny Miller
I have added the section "Reference Example Configuration" - will see what the feedback on this is. I suppose the only concern would be maintaining this version in alignment with what's going into the main cassandra.yaml as part of the regular development. On Mon, 21 Jul 2025 at 15:24, Josh McKenz

Re: [DISCUSS] CEP-51: Support Include Semantics for cassandra.yaml

2025-07-21 Thread Josh McKenzie
That sounds useful to me. I'd like to see us move to "modularized by default"; our current config being 2839 lines of .yaml is a bad experience for both new and old users. Starting with examples of the new paradigm and then r

Re: [DISCUSS] CEP-51: Support Include Semantics for cassandra.yaml

2025-07-21 Thread Johnny Miller
One feature I was thinking of adding to the CEP was to have an example yaml config setup using the includes with the config grouped logically so people have a reference example in the conf? Would this be a good idea? On Fri, 18 Jul 2025 at 19:57, Johnny Miller wrote: > Hello 👋 > > We would like

Re: [DISCUSS] CEP-51: Support Include Semantics for cassandra.yaml

2025-07-21 Thread Josh McKenzie
Looks great Johnny. I remain a +1. :) On Mon, Jul 21, 2025, at 4:29 AM, Johnny Miller wrote: > Thanks Josh - I have updated the unit tests and integration test requirements > to be more detailed with specific things to cover off. Let me know if there's > anything missing when you have a chance 👍

Re: [DISCUSS] CEP-51: Support Include Semantics for cassandra.yaml

2025-07-21 Thread Johnny Miller
Thanks Josh - I have updated the unit tests and integration test requirements to be more detailed with specific things to cover off. Let me know if there's anything missing when you have a chance 👍 On Sat, 19 Jul 2025 at 20:18, Josh McKenzie wrote: > +1 > > One small bit of feedback - in testing

Re: [DISCUSS] CEP-51: Support Include Semantics for cassandra.yaml

2025-07-19 Thread Josh McKenzie
+1 One small bit of feedback - in testing: > Unit Tests > > • Include file loading with all three directive types > • Rejection of include directives in included files > • Detection of duplicate configuration keys across files > • Error messages for duplicate keys include file and line number

Re: [DISCUSS] CEP-51: Support Include Semantics for cassandra.yaml

2025-07-18 Thread Jeff Jirsa
In general I think this is reasonable, as long as we don't change the main existing yaml, because doing so will probably mess up a lot of people's packaging and tooling (I assume someone, somewhere, has a "copy the yaml into the container" logic that doesnt know there may be multiple yamls). O

Re: [DISCUSS] CEP-51: Support Include Semantics for cassandra.yaml

2025-07-18 Thread Jeff Jirsa
In general I think this is reasonable, as long as we don't change the main existing yaml, because doing so will probably mess up a lot of people's packaging and tooling (I assume someone, somewhere, has a "copy the yaml into the container" logic that doesnt know there may be multiple yamls).

Re: [DISCUSS] CEP-51: Support Include Semantics for cassandra.yaml

2025-07-18 Thread Jeff Jirsa
In general I think this is reasonable, as long as we don't change the main existing yaml, because doing so will probably mess up a lot of people's packaging and tooling (I assume someone, somewhere, has a "copy the yaml into the container" logic that doesnt know there may be multiple yamls).

[DISCUSS] CEP-51: Support Include Semantics for cassandra.yaml

2025-07-18 Thread Johnny Miller
Hello 👋 We would like to propose CEP-51: Support Include Semantics for cassandra.yaml for adoption by the community: https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-51+Support+Include+Semantics+for+cassandra.yaml This CEP proposes adding completely optional include directives to Cassand