Re: [DISCUSS] Replace Sigar with OSHI (CASSANDRA-16565)

2023-12-18 Thread Mick Semb Wever
On Mon, 18 Dec 2023 at 11:04, Claude Warren, Jr wrote: > The pull request is : https://github.com/apache/cassandra/pull/2842 > That doesn't help me much. https://github.com/Claudenw/cassandra/pull/6 is still open, and the ticket has discussions still open in its trailing comments. It would be

Re: [DISCUSS] Replace Sigar with OSHI (CASSANDRA-16565)

2023-12-18 Thread Claude Warren, Jr via dev
The pull request is : https://github.com/apache/cassandra/pull/2842 On Mon, Dec 18, 2023 at 10:26 AM Mick Semb Wever wrote: > > > Can I get an another review/approval for the pull request? >> https://github.com/apache/cassandra/pull/2842/files >> > > > It is not clear on the ticket what is

Re: [DISCUSS] Replace Sigar with OSHI (CASSANDRA-16565)

2023-12-18 Thread Mick Semb Wever
Can I get an another review/approval for the pull request? > https://github.com/apache/cassandra/pull/2842/files > It is not clear on the ticket what is being finally proposed, or what is to be reviewed, ref: https://github.com/Claudenw/cassandra/pull/6 Keeping the ticket up to date makes this

Re: [DISCUSS] Replace Sigar with OSHI (CASSANDRA-16565)

2023-12-17 Thread Claude Warren, Jr via dev
Can I get an another review/approval for the pull request? https://github.com/apache/cassandra/pull/2842/files On Fri, Dec 15, 2023 at 4:04 AM guo Maxwell wrote: > +1 too > > Mick Semb Wever 于2023年12月15日周五 10:01写道: > >> >> >> >>> >>> Are there objections to making this switch and adding a new

Re: [DISCUSS] Replace Sigar with OSHI (CASSANDRA-16565)

2023-12-14 Thread guo Maxwell
+1 too Mick Semb Wever 于2023年12月15日周五 10:01写道: > > > >> >> Are there objections to making this switch and adding a new dependency? >> >> [1] https://github.com/apache/cassandra/pull/2842/files >> [2] https://issues.apache.org/jira/browse/CASSANDRA-16565 >> > > > > +1 to removing sigar and to

Re: [DISCUSS] Replace Sigar with OSHI (CASSANDRA-16565)

2023-12-14 Thread Mick Semb Wever
> > Are there objections to making this switch and adding a new dependency? > > [1] https://github.com/apache/cassandra/pull/2842/files > [2] https://issues.apache.org/jira/browse/CASSANDRA-16565 > +1 to removing sigar and to add oshi-core

Re: [DISCUSS] Replace Sigar with OSHI (CASSANDRA-16565)

2023-12-14 Thread Miklosovic, Stefan via dev
/6gzyh1zhxnkz50lld7hlgq172xc0pg3t From: Claude Warren, Jr via dev Sent: Thursday, December 14, 2023 0:17 To: dev Cc: Claude Warren, Jr Subject: [DISCUSS] Replace Sigar with OSHI (CASSANDRA-16565) EXTERNAL EMAIL - USE CAUTION when clicking links or attachments

[DISCUSS] Replace Sigar with OSHI (CASSANDRA-16565)

2023-12-14 Thread Claude Warren, Jr via dev
Greetings, I have submitted a pull request[1] that replaces the unsupported Sigar library with the maintained OSHI library. OSHI is an MIT licensed library that provides information about the underlying OS much like Sigar did. The change adds a dependency on oshi-core at the following