Re: CEP-21 - Transactional cluster metadata merged to trunk

2023-11-28 Thread Ekaterina Dimitrova
I hate to say it, but I was disappointed that this email thread was started after the TCM work had already been committed. Especially knowing how we had even an epic with patches spread around the codebase, which are waiting on TCM to get committed first so that we do not disturb any rebase. The

Re: CEP-21 - Transactional cluster metadata merged to trunk

2023-11-27 Thread Josh McKenzie
> on our internal CI system Some more context: This environment adheres to the requirements we laid out in pre-commit CI on Cassandra with a couple required differences. We don't yet include the resource

Re: CEP-21 - Transactional cluster metadata merged to trunk

2023-11-27 Thread Sam Tunnicliffe
I ought to clarify, we did actually have green CI modulo 3 flaky tests on our internal CI system. I've attached the test artefacts to CASSANDRA-18330 now[1][2]: 2 of the 3 failures are upgrade dtests, with 1 other python dtest failure noted. None of these were reproducible in a dev setup, so we

Re: CEP-21 - Transactional cluster metadata merged to trunk

2023-11-27 Thread Berenguer Blasi
Hi, I have written this email like 10 times before sending it and I can't manage to avoid making it sound with a negative spin to it. So pardon my English or poor choice of words in advance and try to read it in a positive way. It is really demotivating to me seeing things getting merged

Re: CEP-21 - Transactional cluster metadata merged to trunk

2023-11-27 Thread Jacek Lewandowski
Hi, I'm happy to hear that the feature got merged. Though, I share Benjamin's worries about that being a bad precedent. I don't think it makes sense to do repeated runs in this particular case. Detecting flaky tests would not prove anything; they can be caused by this patch, but we would not

Re: CEP-21 - Transactional cluster metadata merged to trunk

2023-11-27 Thread Benjamin Lerer
Hi, I must admit that I have been surprised by this merge and this following email. We had lengthy discussions recently and the final agreement was that the requirement for a merge was a green CI. I could understand that for some reasons as a community we could wish to make some exceptions. In

Re: CEP-21 - Transactional cluster metadata merged to trunk

2023-11-25 Thread Mick Semb Wever
Great work Sam, Alex & Marcus ! > There are about 15-20 flaky or failing tests in total, spread over several > test jobs[2] (i.e. single digit failures in a few of these). We have filed > JIRAs for the failures and are working on getting those fixed as a top > priority. CASSANDRA-19055[3] is

CEP-21 - Transactional cluster metadata merged to trunk

2023-11-24 Thread Marcus Eriksson
Hi all We just wanted to give a heads up that we merged CEP-21, Transactional Cluster Metadata to trunk[1] today. There are about 15-20 flaky or failing tests in total, spread over several test jobs[2] (i.e. single digit failures in a few of these). We have filed JIRAs for the failures