Re: Issue when creating a stream session

2022-12-21 Thread Aleksey Yeshchenko
Indeed, it is safe to clean up now. Normally we prefer to do cleanups like that on trunk only, but I’d say feel free to remove this dead code in 4.0+ if that’s the branch you are targeting in CASSANDRA-17199. > On 19 Dec 2022, at 03:53, Yuki Morishita wrote: > > I dug the git history and it

Re: Issue when creating a stream session

2022-12-18 Thread Yuki Morishita
I dug the git history and it looks like CASSANDRA-3569 changed to not register to Gossip. https://github.com/apache/cassandra/commit/0f2d7d0b9540efa3ea3dfe4f8270c3635afdc63c (It removed the `register` part, not the `unregister` part though.)

Re: Issue when creating a stream session

2022-12-16 Thread David Capwell
This sounds like a bug to me, but would be good to get feedback from others who have touched Streaming… Repair will fail if membership notifies that a participate node was removed, so I think it makes sense for Streaming to also follow this behavior. > On Dec 14, 2022, at 1:22 PM, Natnael

Re: Issue when creating a stream session

2022-12-14 Thread Natnael Adere
To give more context, StreamSession is not listening to Gossip for membership changes. Although it implements an interface for listening to membership changes, we do not register with Gossip and, therefore, never get these changes. This results in the IEndpointStateChangeSubscriber interface

Issue when creating a stream session

2022-12-14 Thread Natnael Adere
Hello, I am working on CASSANDRA-17199 and testing for this ticket has uncovered some issues with streaming. When creating a StreamSession we have an intent for to listen but that never happens. My concern is wether or not we should we