According to the conclusion, I think we can fix the bug when the argument
number is bigger than 2 first.
Thanks everyone.
Bowen Song via dev 于2023年3月23日周四 22:17写道：
> In that case, I would recommend fix the bug that prints everything when an
> arbitrary number of arguments is given.
> On
In that case, I would recommend fix the bug that prints everything when
an arbitrary number of arguments is given.
On 23/03/2023 13:40, guo Maxwell wrote:
firstly I think anything existing must be reasonable，so ignore option
for tablestats must be a need for the user to use. at least I used it
firstly I think anything existing must be reasonable，so ignore option for
tablestats must be a need for the user to use. at least I used it some time
；
secondly in order to keep this as simple as possible ，I think left the
option unchanged is enough ，because the original usage is simple enough.
I don't think the nodetool tablestats command's parameters should be
used as a reference implementation for the nodetool tablehistograms
command. Because:
* the tablehistograms command can take the keyspace and table as two
separate parameters, but the tablestats command can't.
* the
Maybe I didn't describe the usage of option "-i" clearly, The reason why I
think the command argument should be like this :
1. nodetool tablehistograms ks.tb1 or ks tb1 ... //this is *one of the old
> way *of using tablehistogram. will print out the histograms of tabke
> ks.tb1 , we keep the
Agree w/Bowen. I think the straight forward simplicity of "clear inclusion and
exclusion semantics, default to include all in scope excepting things that are
explicitly ignored" would be ideal.
On Wed, Mar 22, 2023, at 8:45 AM, Bowen Song via dev wrote:
> TBH, the syntax looks unnecessarily
TBH, the syntax looks unnecessarily complex and confusing to me.
For example, for this command:
nodetool tablehistograns -ks ks1 -i -tbs ks1.tb1 ks2.tb2
Which one of the following should it do?
1. all tables in the keyspace ks1, except the table tb1; or
2. all tables in all keyspaces,
Thanks everyone , So It seems that it is better to add new parameter
options to meet our needs, while keeping the original parameter functions
unaffected to achieve backward compatibility.
So the new options are :
1. nodetool tablehistograms ks.tb1 or ks tb1 ... //this is *one of the old
way *of
-1 on any change which breaks the previously documented usage.
+1 any additions to what the tool can do without breaking previously documented
behavior.
> On Mar 16, 2023, at 7:42 AM, Josh McKenzie wrote:
>
> We could also consider augmenting the tool with new named arguments with the
>
We could also consider augmenting the tool with new named arguments with the
functionality you described and leave the positional usage intact.
On Thu, Mar 16, 2023, at 6:43 AM, Bowen Song via dev wrote:
> The documented command options are:
>
>> nodetool tablehistograms [ | ]
>>
>
>
> That
The documented command options are:
nodetool tablehistograms [ | ]
That means one parameter will be treated as dot separated keyspace and
table. Alternatively, two parameters will be treated as the keyspace and
table respectively.
To remain compatible with the documented behaviour, my
11 matches
Mail list logo
