Re: Side Car New Repo vs not

2018-08-27 Thread Sankalp Kohli
Thanks everyone for the feedback. Looks like we will go with separate repo as that is what majority of people prefer. Also note that we can always change this approach later as we build the side car. > On Aug 24, 2018, at 07:00, Eric Evans wrote: > >> On Thu, Aug 23, 2018 at 3:01 PM

Re: Side Car New Repo vs not

2018-08-24 Thread Eric Evans
On Thu, Aug 23, 2018 at 3:01 PM sankalp kohli wrote: > > Separate repo is in a majority so far. Please reply to this thread with > your responses. I think it makes sense for the code, project, and workflows to be (de|loosely)-coupled, so the repo should be as well. +1 for a separate repository

Re: Side Car New Repo vs not

2018-08-24 Thread kurt greaves
+1 separate repo. I think in-tree only works if you're *not* supporting multiple versions and each sidecar release is directly tied to a corresponding C* release. Considering this case is also completely achievable in a separate repo anyway with minimal overhead we may as well start that way and

Re: Side Car New Repo vs not

2018-08-24 Thread Sam Tunnicliffe
+1 for a separate repo On Fri, 24 Aug 2018 at 06:40, Michael Shuler wrote: > +1 for a separate repository. > > Michael > > On 08/23/2018 07:30 PM, Murukesh Mohanan wrote: > > FWIW, I think it's possible to merge in a separate repository into a > > subdirectory while keeping git history, but I

Re: Side Car New Repo vs not

2018-08-23 Thread Michael Shuler
+1 for a separate repository. Michael On 08/23/2018 07:30 PM, Murukesh Mohanan wrote: > FWIW, I think it's possible to merge in a separate repository into a > subdirectory while keeping git history, but I don't know if the other way > will be possible if commits span other parts of the repo as

Re: Side Car New Repo vs not

2018-08-23 Thread Murukesh Mohanan
FWIW, I think it's possible to merge in a separate repository into a subdirectory while keeping git history, but I don't know if the other way will be possible if commits span other parts of the repo as well\* (which will likely happen sooner or later). So a separate repo is a choice we can

Re: Side Car New Repo vs not

2018-08-23 Thread Benedict Elliott Smith
+1 also for separate repo > On 24 Aug 2018, at 01:11, Jeff Jirsa wrote: > > +1 for separate repo > > > -- > Jeff Jirsa > > >> On Aug 23, 2018, at 1:00 PM, sankalp kohli wrote: >> >> Separate repo is in a majority so far. Please reply to this thread with >> your responses. >> >> On Tue,

Re: Side Car New Repo vs not

2018-08-23 Thread Jeff Jirsa
+1 for separate repo -- Jeff Jirsa > On Aug 23, 2018, at 1:00 PM, sankalp kohli wrote: > > Separate repo is in a majority so far. Please reply to this thread with > your responses. > > On Tue, Aug 21, 2018 at 4:34 PM Rahul Singh > wrote: > >> +1 for separate repo. Especially on git.

Re: Side Car New Repo vs not

2018-08-23 Thread sankalp kohli
Separate repo is in a majority so far. Please reply to this thread with your responses. On Tue, Aug 21, 2018 at 4:34 PM Rahul Singh wrote: > +1 for separate repo. Especially on git. Maybe make it a submodule. > > Rahul > On Aug 21, 2018, 3:33 PM -0500, Stefan Podkowinski , > wrote: > > I'm also

Re: Side Car New Repo vs not

2018-08-21 Thread Rahul Singh
+1 for separate repo. Especially on git. Maybe make it a submodule. Rahul On Aug 21, 2018, 3:33 PM -0500, Stefan Podkowinski , wrote: > I'm also currently -1 on the in-tree option. > > Additionally to what Aleksey mentioned, I also don't see how we could > make this work with the current build

Re: Side Car New Repo vs not

2018-08-21 Thread Stefan Podkowinski
I'm also currently -1 on the in-tree option. Additionally to what Aleksey mentioned, I also don't see how we could make this work with the current build and release process. Our scripts [0] for creating releases (tarballs and native packages), would need significant work to add support for an

Re: Side Car New Repo vs not

2018-08-21 Thread Jason Brown
+1 for separate repo. For pretty much all the same reasons Aleksey elucidated. On Tue, Aug 21, 2018 at 10:20 AM, Aleksey Yeshchenko wrote: > Sure, allow me to elaborate - at least a little bit. But before I do, just > let me note that this wasn’t a veto -1, just a shorthand for “I don’t like >

Re: Side Car New Repo vs not

2018-08-21 Thread Aleksey Yeshchenko
Sure, allow me to elaborate - at least a little bit. But before I do, just let me note that this wasn’t a veto -1, just a shorthand for “I don’t like this option”. It would be nice to have sidecar and C* version and release cycles fully decoupled. I know it *can* be done when in-tree, but the

Re: Side Car New Repo vs not

2018-08-21 Thread sankalp kohli
Hi Aleksey, Can you please elaborate on the reasons for your -1? This way we can make progress towards any one approach. Thanks, Sankalp On Tue, Aug 21, 2018 at 8:39 AM Aleksey Yeshchenko wrote: > FWIW I’m strongly -1 on in-tree approach, and would much prefer a separate >

Re: Side Car New Repo vs not

2018-08-21 Thread Aleksey Yeshchenko
FWIW I’m strongly -1 on in-tree approach, and would much prefer a separate repo, dtest-style. — AY On 21 August 2018 at 16:36:02, Jeremiah D Jordan (jeremiah.jor...@gmail.com) wrote: I think the following is a very big plus of it being in tree: >> * Faster iteration speed in general. For

Re: Side Car New Repo vs not

2018-08-21 Thread Jeremiah D Jordan
I think the following is a very big plus of it being in tree: >> * Faster iteration speed in general. For example when we need to add a >> new >> JMX endpoint that the sidecar needs, or change something from JMX to a >> virtual table (e.g. for repair, or monitoring) we can do all changes >>

Re: Side Car New Repo vs not

2018-08-21 Thread Jonathan Haddad
Strongly agree with Blake. In my mind supporting multiple versions is mandatory. As I've stated before, we already do it with Reaper, I'd consider it a major misstep if we couldn't support multiple with the project - provided admin tool. It's the same reason dtests are separate - they work with

Re: Side Car New Repo vs not

2018-08-20 Thread dinesh.jo...@yahoo.com.INVALID
An option is to create a mono repo with Cassandra and SideCar as modules that could be built independently. This would keep source for both artifacts in the same repo and have their own release cadences. That said, I don't have any strong opinions at this point. We can try going with a separate

Re: Side Car New Repo vs not

2018-08-20 Thread Joseph Lynch
I think that the pros of incubating the sidecar in tree as a tool first outweigh the alternatives at this point of time. Rough tradeoffs that I see: Unique pros of in tree sidecar: * Faster iteration speed in general. For example when we need to add a new JMX endpoint that the sidecar needs, or

Side Car New Repo vs not

2018-08-20 Thread sankalp kohli
Hi, I am starting a new thread to get consensus on where the side car should be contributed. Please send your responses with pro/cons of each approach or any other approach. Please be clear which approach you will pick while still giving pros/cons of both approaches. Thanks. Sankalp