Re: upgrade sstable selection

2023-01-11 Thread Jacek Lewandowski
Hi, It does not look like returning an unsorted map is a bug. Whenever we want to sort sstables according to their generation id, we do that explicitly, for example in leveled compactor. Though, as you pointed out, the order should be retained when upgrading sstables because otherwise things like

Re: upgrade sstable selection

2023-01-10 Thread Claude Warren, Jr via dev
Actually since the Directories.SSTableLister stores the Components in a HashMap indexed by the Descriptor. Since the upgrade/downgrade code retrieves the list in hash order there is no guarantee that they will be in order. I suspect that this is a bug. On Tue, Jan 10, 2023 at 12:34 PM Brandon Wi

Re: upgrade sstable selection

2023-01-10 Thread Brandon Williams
> I think this means that the Directories.SSTableLister on occasion returns > files in the incorrect order during a call to lister.list().entrySet() This seems easy enough to verify by looping it and examining the results. Kind Regards, Brandon On Tue, Jan 10, 2023 at 4:44 AM Claude Warren, Jr

upgrade sstable selection

2023-01-10 Thread Claude Warren, Jr via dev
Greetings, I am working on the downgradesstables code and seem to have a problem with ordering of the downgrade or perhaps the Directories.SSTableLister I lifted the code from upgradesstables to select the files to downgrade. The only difference in the code that selects the files to downgrade is