[GitHub] [cassandra-builds] smiklosovic commented on issue #9: CASSANDRA-14712 - Cassandra 4.0 packaging support
smiklosovic commented on issue #9: CASSANDRA-14712 - Cassandra 4.0 packaging support URL: https://github.com/apache/cassandra-builds/pull/9#issuecomment-477001506 There needs to be merged / reviewed this too: https://github.com/smiklosovic/cassandra/commit/4a3926aa58f2b8a4a1e4b02b67810817243ff83e This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org For additional commands, e-mail: dev-h...@cassandra.apache.org
[GitHub] [cassandra-builds] smiklosovic commented on a change in pull request #9: CASSANDRA-14712 - Cassandra 4.0 packaging support
smiklosovic commented on a change in pull request #9: CASSANDRA-14712 -
Cassandra 4.0 packaging support
URL: https://github.com/apache/cassandra-builds/pull/9#discussion_r269422027
##
File path: docker/stretch-image.docker
##
@@ -1,32 +1,34 @@
-FROM debian:jessie-backports
+FROM debian:stretch-backports
ENV DEB_DIST_DIR=/dist
ENV BUILD_HOME=/home/build
ENV CASSANDRA_DIR=$BUILD_HOME/cassandra
+ENV ANT_VERSION=1.10.5
-LABEL org.cassandra.buildenv=jessie
+LABEL org.cassandra.buildenv=stretch
VOLUME ${DEB_DIST_DIR}
# install deps
RUN apt-get update && apt-get -y install \
- ant \
build-essential \
curl \
devscripts \
git \
sudo
-RUN apt-get -y -t jessie-backports --no-install-recommends install \
- openjdk-7-jdk \
Review comment:
`openjdk-7-jdk` is not in stretch anymore, Ive removed 7 from centos too
then
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org
For additional commands, e-mail: dev-h...@cassandra.apache.org
[GitHub] [cassandra-builds] mshuler commented on issue #9: CASSANDRA-14712 - Cassandra 4.0 packaging support
mshuler commented on issue #9: CASSANDRA-14712 - Cassandra 4.0 packaging support URL: https://github.com/apache/cassandra-builds/pull/9#issuecomment-477163370 Not sure why you're downloading a specific version of ant. Please, squash your commits. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org For additional commands, e-mail: dev-h...@cassandra.apache.org
[GitHub] [cassandra-builds] mshuler commented on a change in pull request #9: CASSANDRA-14712 - Cassandra 4.0 packaging support
mshuler commented on a change in pull request #9: CASSANDRA-14712 - Cassandra
4.0 packaging support
URL: https://github.com/apache/cassandra-builds/pull/9#discussion_r269569842
##
File path: docker/stretch-image.docker
##
@@ -1,32 +1,34 @@
-FROM debian:jessie-backports
+FROM debian:stretch-backports
ENV DEB_DIST_DIR=/dist
ENV BUILD_HOME=/home/build
ENV CASSANDRA_DIR=$BUILD_HOME/cassandra
+ENV ANT_VERSION=1.10.5
-LABEL org.cassandra.buildenv=jessie
+LABEL org.cassandra.buildenv=stretch
VOLUME ${DEB_DIST_DIR}
# install deps
RUN apt-get update && apt-get -y install \
- ant \
build-essential \
curl \
devscripts \
git \
sudo
-RUN apt-get -y -t jessie-backports --no-install-recommends install \
- openjdk-7-jdk \
- openjdk-8-jdk
+RUN apt-get -y -t stretch-backports --no-install-recommends install \
+ openjdk-8-jdk \
+ openjdk-11-jdk
-RUN apt-get -y -t jessie-backports install \
+RUN apt-get -y -t stretch-backports install \
python-sphinx \
python-sphinx-rtd-theme
RUN update-java-alternatives --set java-1.8.0-openjdk-amd64
+RUN mkdir -p /opt && curl
http://www-eu.apache.org/dist/ant/binaries/apache-ant-$ANT_VERSION-bin.tar.gz |
tar xz -C /opt && mv /opt/apache-ant-$ANT_VERSION /opt/ant && ln -s
/opt/ant/bin/ant /usr/local/bin/ant
Review comment:
why again?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org
For additional commands, e-mail: dev-h...@cassandra.apache.org
[GitHub] [cassandra-builds] mshuler commented on a change in pull request #9: CASSANDRA-14712 - Cassandra 4.0 packaging support
mshuler commented on a change in pull request #9: CASSANDRA-14712 - Cassandra
4.0 packaging support
URL: https://github.com/apache/cassandra-builds/pull/9#discussion_r269569635
##
File path: docker/centos7-image.docker
##
@@ -4,26 +4,27 @@ ENV BUILD_HOME=/home/build
ENV RPM_BUILD_DIR=$BUILD_HOME/rpmbuild
ENV RPM_DIST_DIR=/dist
ENV CASSANDRA_DIR=$BUILD_HOME/cassandra
+ENV ANT_VERSION=1.10.5
LABEL org.cassandra.buildenv=centos
VOLUME ${RPM_DIST_DIR}
# install deps
RUN yum -y install \
- ant \
- ant-junit \
epel-release \
git \
- java-1.7.0-openjdk-devel \
java-1.8.0-openjdk-devel \
+ java-11-openjdk-devel \
make \
rpm-build \
sudo
# via epel-releases
RUN yum -y install python2-pip
+RUN mkdir -p /opt && curl
http://www-eu.apache.org/dist/ant/binaries/apache-ant-$ANT_VERSION-bin.tar.gz |
tar xz -C /opt && mv /opt/apache-ant-$ANT_VERSION /opt/ant && ln -s
/opt/ant/bin/ant /usr/local/bin/ant
Review comment:
why?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org
For additional commands, e-mail: dev-h...@cassandra.apache.org
[GitHub] [cassandra-builds] smiklosovic commented on a change in pull request #9: CASSANDRA-14712 - Cassandra 4.0 packaging support
smiklosovic commented on a change in pull request #9: CASSANDRA-14712 -
Cassandra 4.0 packaging support
URL: https://github.com/apache/cassandra-builds/pull/9#discussion_r269855955
##
File path: docker/stretch-image.docker
##
@@ -1,32 +1,34 @@
-FROM debian:jessie-backports
+FROM debian:stretch-backports
ENV DEB_DIST_DIR=/dist
ENV BUILD_HOME=/home/build
ENV CASSANDRA_DIR=$BUILD_HOME/cassandra
+ENV ANT_VERSION=1.10.5
-LABEL org.cassandra.buildenv=jessie
+LABEL org.cassandra.buildenv=stretch
VOLUME ${DEB_DIST_DIR}
# install deps
RUN apt-get update && apt-get -y install \
- ant \
build-essential \
curl \
devscripts \
git \
sudo
-RUN apt-get -y -t jessie-backports --no-install-recommends install \
- openjdk-7-jdk \
- openjdk-8-jdk
+RUN apt-get -y -t stretch-backports --no-install-recommends install \
+ openjdk-8-jdk \
+ openjdk-11-jdk
-RUN apt-get -y -t jessie-backports install \
+RUN apt-get -y -t stretch-backports install \
python-sphinx \
python-sphinx-rtd-theme
RUN update-java-alternatives --set java-1.8.0-openjdk-amd64
+RUN mkdir -p /opt && curl
http://www-eu.apache.org/dist/ant/binaries/apache-ant-$ANT_VERSION-bin.tar.gz |
tar xz -C /opt && mv /opt/apache-ant-$ANT_VERSION /opt/ant && ln -s
/opt/ant/bin/ant /usr/local/bin/ant
Review comment:
@mshuler fixed in both cases
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org
For additional commands, e-mail: dev-h...@cassandra.apache.org
[GitHub] [cassandra-builds] smiklosovic opened a new pull request #9: CASSANDRA-14712 - Cassandra 4.0 packaging support
smiklosovic opened a new pull request #9: CASSANDRA-14712 - Cassandra 4.0 packaging support URL: https://github.com/apache/cassandra-builds/pull/9 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org For additional commands, e-mail: dev-h...@cassandra.apache.org
[GitHub] [cassandra-builds] smiklosovic commented on a change in pull request #9: CASSANDRA-14712 - Cassandra 4.0 packaging support
smiklosovic commented on a change in pull request #9: CASSANDRA-14712 - Cassandra 4.0 packaging support URL: https://github.com/apache/cassandra-builds/pull/9#discussion_r269420661 ## File path: docker/build-debs.sh ## @@ -78,7 +87,12 @@ fi # Install build dependencies and build package echo "y" | sudo mk-build-deps --install + Review comment: This had to be done otherwise following `dpkg-buildpackage` complained that JAVA_HOME can not be set like it was set at the beginning of this file. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org For additional commands, e-mail: dev-h...@cassandra.apache.org
[GitHub] [cassandra-builds] smiklosovic commented on a change in pull request #9: CASSANDRA-14712 - Cassandra 4.0 packaging support
smiklosovic commented on a change in pull request #9: CASSANDRA-14712 - Cassandra 4.0 packaging support URL: https://github.com/apache/cassandra-builds/pull/9#discussion_r269420748 ## File path: docker/build-debs.sh ## @@ -78,7 +87,12 @@ fi # Install build dependencies and build package echo "y" | sudo mk-build-deps --install + +unset JAVA8_HOME +unset JAVA_HOME + Review comment: This had to be done otherwise following `dpkg-buildpackage` complained that JAVA_HOME can not be set like it was set at the beginning of this file. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org For additional commands, e-mail: dev-h...@cassandra.apache.org
[GitHub] [cassandra-builds] smiklosovic commented on a change in pull request #9: CASSANDRA-14712 - Cassandra 4.0 packaging support
smiklosovic commented on a change in pull request #9: CASSANDRA-14712 - Cassandra 4.0 packaging support URL: https://github.com/apache/cassandra-builds/pull/9#discussion_r269420661 ## File path: docker/build-debs.sh ## @@ -78,7 +87,12 @@ fi # Install build dependencies and build package echo "y" | sudo mk-build-deps --install + Review comment: This had to be done otherwise following `dpkg-buildpackage` complained that JAVA_HOME can not be set like it was set at the beginning of this file. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org For additional commands, e-mail: dev-h...@cassandra.apache.org
[GitHub] [cassandra-builds] smiklosovic commented on a change in pull request #9: CASSANDRA-14712 - Cassandra 4.0 packaging support
smiklosovic commented on a change in pull request #9: CASSANDRA-14712 - Cassandra 4.0 packaging support URL: https://github.com/apache/cassandra-builds/pull/9#discussion_r269420748 ## File path: docker/build-debs.sh ## @@ -78,7 +87,12 @@ fi # Install build dependencies and build package echo "y" | sudo mk-build-deps --install + +unset JAVA8_HOME +unset JAVA_HOME + Review comment: This had to be done otherwise following `dpkg-buildpackage` complained that `JAVA_HOME` can not be set like it was set at the beginning of this file. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org For additional commands, e-mail: dev-h...@cassandra.apache.org
[GitHub] [cassandra-builds] smiklosovic commented on a change in pull request #9: CASSANDRA-14712 - Cassandra 4.0 packaging support
smiklosovic commented on a change in pull request #9: CASSANDRA-14712 - Cassandra 4.0 packaging support URL: https://github.com/apache/cassandra-builds/pull/9#discussion_r269421929 ## File path: docker/stretch-image.docker ## @@ -1,32 +1,34 @@ -FROM debian:jessie-backports Review comment: `jessie-backports` does not exist anymore, the subsequent update returns 404 on repos This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org For additional commands, e-mail: dev-h...@cassandra.apache.org
