fixing paging state for 4.0

2019-09-24 Thread Jon Haddad
I'm working with a team who just ran into CASSANDRA-14683 [1], which I didn't realize was an issue till now. Anyone have an interest in fixing full table pagination? I'm not sure of the full implications of changing the int to a long in the paging stage.

Re: fixing paging state for 4.0

2019-09-24 Thread Blake Eggleston
Changing paging state format is kind of a pain since the driver treats it as an opaque blob. I'd prefer we went with Sylvain's suggestion to just interpret Integer.MAX_VALUE as "no limit", which would be a lot simpler to implement. > On Sep 24, 2019, at 10:44 AM, Jon Haddad wrote: > > I'm

Re: Attention to serious bug CASSANDRA-15081

2019-09-24 Thread Blake Eggleston
This looks like a dupe of CASSANDRA-15086, which has been committed and will be included in 3.0.19. > On Sep 11, 2019, at 5:10 PM, Cameron Zemek wrote: > > Have had multiple customer hit this CASSANDRA-15081 issue now, where > upgrading from older versions the sstables contain an unknown

moving the site from SVN to git

2019-09-24 Thread Jon Haddad
While at apachecon I spoke with the folks at the INFRA desk to find out about moving the website from SVN to Git, and it's pretty straightforward. Here's the process: 1. Create a new Git repo fort the site 2. Copy the files over. I don't think we care about history. Unless someone speaks up,

Re: fixing paging state for 4.0

2019-09-24 Thread Blake Eggleston
Right, mixed version clusters. The opaque blob isn't versioned, and there isn't an opportunity for min version negotiation that you have with the messaging service. The result is situations where a client begins a read on one node, and attempts to read the next page from a different node over a

Re: moving the site from SVN to git

2019-09-24 Thread Anthony Grasso
Hi Jon, Thank you for actioning this! The only trivial things that come to mind for me is to do with documentation: - The README file with the instructions to build the site points to SVN - The website Publication page

Re: moving the site from SVN to git

2019-09-24 Thread Jon Haddad
Personally, no, I don't. What I need to know is if someone who actually works on the site needs the history in *git*. It would still be archived in SVN. On Tue, Sep 24, 2019 at 2:12 PM Joshua Drake wrote: > On Tue, Sep 24, 2019 at 1:44 PM Jon Haddad wrote: > > > While at apachecon I spoke

Re: fixing paging state for 4.0

2019-09-24 Thread Blake Eggleston
Yes, but if a client is connected to 2 different nodes, and is using a different protocol for each, the paging state formats aren’t going to match if it tries to use the paging date from one connection on the other. > On Sep 24, 2019, at 7:14 PM, J. D. Jordan wrote: > > It is inherently

Re: fixing paging state for 4.0

2019-09-24 Thread Jon Haddad
What's the pain point? Is it because of mixed version clusters or is there something else that makes it a problem? On Tue, Sep 24, 2019 at 11:03 AM Blake Eggleston wrote: > Changing paging state format is kind of a pain since the driver treats it > as an opaque blob. I'd prefer we went with

Re: fixing paging state for 4.0

2019-09-24 Thread J. D. Jordan
It is inherently versioned by the protocol version being used for the connection. > On Sep 24, 2019, at 9:06 PM, Jon Haddad wrote: > > The problem is that the payload isn't versioned, because the individual > fields aren't really part of the protocol. I think the long term fix > should be to

Re: moving the site from SVN to git

2019-09-24 Thread Joshua Drake
On Tue, Sep 24, 2019 at 1:44 PM Jon Haddad wrote: > While at apachecon I spoke with the folks at the INFRA desk to find out > about moving the website from SVN to Git, and it's pretty straightforward. > Here's the process: > > 1. Create a new Git repo fort the site > 2. Copy the files over. I

Re: fixing paging state for 4.0

2019-09-24 Thread J. D. Jordan
Are their drivers that try to do mixed protocol version connections? If so that would be a mistake on the drivers part if it sent the new paging state to an old server. Pretty easily protected against in said driver when it implements support for the new protocol version. The payload is

Re: fixing paging state for 4.0

2019-09-24 Thread Jeremiah Jordan
Clients do negotiate the protocol version they use when connecting. If the server bumped the protocol version then this larger paging state could be part of the new protocol version. But that doesn’t solve the problem for existing versions. The special treatment of Integer.MAX_VALUE can be

Re: fixing paging state for 4.0

2019-09-24 Thread Blake Eggleston
Right, that's the problem with changing the paging state format. It doesn't work in mixed mode. > On Sep 24, 2019, at 4:47 PM, Jeremiah Jordan wrote: > > Clients do negotiate the protocol version they use when connecting. If the > server bumped the protocol version then this larger paging

Re: fixing paging state for 4.0

2019-09-24 Thread Jon Haddad
The problem is that the payload isn't versioned, because the individual fields aren't really part of the protocol. I think the long term fix should be to add the fields of the paging state to the protocol itself rather than have it just be some serialized blob. Then we don't have to deal with

Re: fixing paging state for 4.0

2019-09-24 Thread J. D. Jordan
And as I said, that would be a bug in the driver that did this. Any driver implementing a protocol that has a “new” paging state, that supports mixed version connections, would need to handle that correctly and not send new states over the old protocol or old states over the new protocol. As

Re: moving the site from SVN to git

2019-09-24 Thread Mick Semb Wever
> Personally, no, I don't. What I need to know is if someone who actually > works on the site needs the history in *git*. Yes. I need the history in *git*. And I believe that INFRA can do the migration for you. (For example, INFRA-12055 and spark-website)

Re: fixing paging state for 4.0

2019-09-24 Thread Blake Eggleston
Sorry, I misread your earlier email. Yes, there are drivers that do mixed protocol versions. Not sure if the 4.0 java driver does, but at least one previous version did. > On Sep 24, 2019, at 7:19 PM, Blake Eggleston > wrote: > > Yes, but if a client is connected to 2 different nodes, and is