Re: Updating our Code Contribution/Style Guide

2022-03-20 Thread Mick Semb Wever
On Tue, 15 Mar 2022 at 11:46, Ruslan Fomkin wrote: > … > I support Jacek’s request to have each argument on a separate line when > they are many and need to be placed on multiple lines. For me it takes less > effort to grasp arguments on separate lines than when several arguments are > combined

Re: Updating our Code Contribution/Style Guide

2022-03-20 Thread Mick Semb Wever
> I support this too… leads to more noise in, and less readability of, the > patch. > > > > Readability of the patch is not harmed with modern tooling (with > whitespace being highlighted differently to content changes). > > > > Legibility of the code (not patch) should always be preferred IMO. To

Re: Updating our Code Contribution/Style Guide

2022-03-20 Thread bened...@apache.org
> I support this too… leads to more noise in, and less readability of, the > patch. Readability of the patch is not harmed with modern tooling (with whitespace being highlighted differently to content changes). Legibility of the code (not patch) should always be preferred IMO. To aid code

Re: Updating our Code Contribution/Style Guide

2022-03-20 Thread Jacek Lewandowski
Regarding `instance()` method / `instance` field - to clarify my point - we usually use that in many places. While it is quite easy to access by method rather than by a field from the beginning, regardless if there is a need for a mock immediately or not, it would be a much bigger change in terms

Re: Updating our Code Contribution/Style Guide

2022-03-20 Thread bened...@apache.org
> We are talking about one extra line, not a dozen or more. I think you are confused about the context. The case I was discussing often means 10+ additional lines at each call-site. > Once the code gets more real, it is faster to read the difference between (a) > and (c) This isn’t a great