Re: [Proposal] Mandatory comments

2016-05-05 Thread Michael Kjellman
My vote is to start with BigTableScanner (SSTableScanner).. 5 iterators that all do something different with each other depending on how used with zero comments -- in a critical code path. What could go wrong! > On May 5, 2016, at 11:26 AM, Dave Brosius wrote: > > A less controversial tact wou

Re: [Proposal] Mandatory comments

2016-05-05 Thread Dave Brosius
A less controversial tact would be to actively solicit input from contributors, etc, about what methods/classes are confusing, and put those classes/methods on a priority list for adding good javadoc. When that list goes to ~0, you've probably done enough. The key tho is to actively solicit, a

Can I replace a 2.0.9 node with a 2.1.14 node in a cluster?

2016-05-05 Thread Li, Guangxing
Hi, due to internal infrastructure changes, we have to replace all nodes with new nodes. All the existing nodes are running Cassandra Community version 2.0.9. I was thinking may be this is also an opportunity for us to upgrade to Cassandra Community version 2.1.14. I hope I am not asking a crazy q

Re: [Proposal] Mandatory comments

2016-05-05 Thread Jack Krupansky
FWIW, I recently wrote up a bunch of notes on Code Quality and published them on Medium. There are notes on comments and consistency and boilerplate buried in there. WARNING: There's a lot of stuff there and it is not for the faint of heart or those not truly committed to code quality. tl;dr - I

Re: [Proposal] Mandatory comments

2016-05-05 Thread Eric Evans
On Wed, May 4, 2016 at 12:14 PM, Jonathan Ellis wrote: > On Wed, May 4, 2016 at 2:27 AM, Sylvain Lebresne > wrote: > >> On Tue, May 3, 2016 at 6:57 PM, Eric Evans >> wrote: >> >> > On Mon, May 2, 2016 at 11:26 AM, Sylvain Lebresne >> > wrote: >> > > Looking forward to other's opinions and feedb