Re: sstableloader from java

2016-09-21 Thread J. D. Jordan
Yeah. I wouldn't use that class, I was just pointing it out as an example of code doing a similar thing. > On Sep 21, 2016, at 8:16 PM, Paul Weiss wrote: > > Great will try out. I noticed the code is within the hadoop folder, I am > using local disk so hopefully it

Re: sstableloader from java

2016-09-21 Thread Paul Weiss
Great will try out. I noticed the code is within the hadoop folder, I am using local disk so hopefully it will work without hadoop. Thanks, -paul On Sep 21, 2016 8:56 PM, "Jeremiah D Jordan" wrote: > Yes using the SSTableLoader class. You can see the

Re: sstableloader from java

2016-09-21 Thread Jeremiah D Jordan
Yes using the SSTableLoader class. You can see the CqlBulkRecordWriter class for an example of writing out sstables to disk and then using the SSTableLoader class to stream them to a cluster. -Jeremiah > On Sep 21, 2016, at 7:18 PM, Paul Weiss wrote: > > Hi, > > Is

sstableloader from java

2016-09-21 Thread Paul Weiss
Hi, Is it possible to call the sstableloader from java instead using the command line program? I have a process that uses the CQLSSTableWriter and generates the sstable files but am looking for an end to end process that bulk loads without any manual intervention. Ideally would like to avoid

Re: Guidelines for test coverage

2016-09-21 Thread Nate McCall
We have these already written down in from both the reviewing and development perspective: http://cassandra.apache.org/doc/latest/development/how_to_review.html http://cassandra.apache.org/doc/latest/development/testing.html My takeaway from recent in-person discussions the other week about this

Re: Question on assert

2016-09-21 Thread DuyHai Doan
I found that SO question very interesting to fuel the discussion about assert vs exception : http://stackoverflow.com/questions/1957645/when-to-use-an-assertion-and-when-to-use-an-exception On Wed, Sep 21, 2016 at 8:20 PM, Michael Kjellman < mkjell...@internalcircle.com> wrote: > Yeah, I

Re: chronicles

2016-09-21 Thread Julien Bertozzi
? 2016-09-21 7:09 GMT+02:00 Codarren Velvindron : > >

Re: Question on assert

2016-09-21 Thread Michael Kjellman
Yeah, I understand what you're saying, don't get me wrong. However, I just spent close to a year total working and writing CASSANDRA-9754 and when you're dealing with IO, sometimes asserts are the right way to go. I found putting them there are sanity checks mostly to ensure that code changes

Re: Question on assert

2016-09-21 Thread Jonathan Ellis
That sounds to me like we have some asserts that should be turned into actual exceptions. (I'm definitely not arguing that ALL our asserts are in this category.) On Wed, Sep 21, 2016 at 12:34 PM, Michael Kjellman < mkjell...@internalcircle.com> wrote: > Asserts have their place as sanity

Re: Question on assert

2016-09-21 Thread Michael Kjellman
Asserts have their place as sanity checks. Just like exceptions have their place. They can both live in harmony and they both serve a purpose. What doesn't serve a purpose is that comment encouraging n00b users to get a mythical 5% performance increase and then get silent corruption when their

Re: Question on assert

2016-09-21 Thread Edward Capriolo
" potential 5% performance win when you've corrupted all their data." This is somewhat of my point. Why do assertions that sometimes are trapped "protect my data" better then a checked exception? On Wed, Sep 21, 2016 at 1:24 PM, Michael Kjellman < mkjell...@internalcircle.com> wrote: > I hate

Re: Question on assert

2016-09-21 Thread Michael Kjellman
I hate that comment with a passion. Please please please please do yourself a favor and *always* run with asserts on. `-ea` for life. In practice I'd be surprised if you actually got a reliable 5% performance win and I doubt your customers will care about a potential 5% performance win when

Question on assert

2016-09-21 Thread Edward Capriolo
There are a variety of assert usages in the Cassandra. You can find several tickets like mine. https://issues.apache.org/jira/browse/CASSANDRA-12643 https://issues.apache.org/jira/browse/CASSANDRA-11537 Just to prove that I am not the only one who runs into these: