Re: Question on submitting a patch

On Fri, Jan 5, 2018 at 12:44 PM, Tyagi, Preetika wrote: > Hi all, > > When I click on "Submit Patch" option, it pops up a new screen where it > asks for a bunch of details including Fix Version(s). IF you know it, the 'Fix Version' should be set to the branches the bug impacts. For example, a

Re: Question on submitting a patch

great question! i personally always just leave everything blank to effectively just get the stupid state changed reason number 3000 why I personally hate JIRA. > On Jan 5, 2018, at 12:44 PM, Tyagi, Preetika wrote: > > Hi all, > > When I click on "Submit Patch" option, it pops up a new scr

Question on submitting a patch

Hi all, When I click on "Submit Patch" option, it pops up a new screen where it asks for a bunch of details including Fix Version(s). Does the patch need to be synced up with the latest repo or I can just choose which version I worked with (which may not necessarily be the latest and hence one

Re: CASSANDRA-8527

Right, I think naming it "deleted rows" is misleading because it suggests that 100 rows shadowed by one RT would be counted as 100 tombstones, which is not the case here (those get merged away before getting counted). The patch counts row tombstones, where (after merge) one tombstone shadows a sin

Re: CASSANDRA-8527

Counting the number of range tombstones - sure, that is reasonable. Counting cells/rows shadowed by range tombstones toward the limit, as if they were regular tombstones - arguably not so much. — AY On 5 January 2018 at 18:53:45, Jon Haddad (j...@jonhaddad.com) wrote: I think it’s reasonable t

Re: CASSANDRA-8527

I think it’s reasonable to count the number of range tombstones towards the total tombstone count / threshold. I agree the number of rows shadowed by the tombstones should be tracked separately, and we should probably think a bit more about how to add configuration / limits around this withou

Re: CASSANDRA-8527

Hi Aleksey, ok we'll split the work and only deal with row level tombstones in CASSANDRA-8527 and create a follow up ticket to work on the separate counts you're suggesting. My understanding of what you say is that you would not include range