Re: Supporting multiple JDKs

2018-09-04 Thread Sumanth Pasupuleti
C* 2.2 > I'm still left wondering why we want to use CI resources to find bugs that the users will never encounter. How would we be sure users will never encounter bugs unless we build against that JDK? This is the reason I propose having a CircleCI build against 1.7. > If you take out "and

Re: Request for post-freeze merge exception

2018-09-04 Thread Michael Shuler
+1 to merge. -- Michael On 09/04/2018 01:05 PM, Sam Tunnicliffe wrote: > Hey all, > > On 2018-31-08 CASSANDRA-14145 had been +1'd by two reviewers and CI was > green, and so it was marked Ready To Commit. This was before the 4.0 > feature freeze but before it landed, CASSANDRA-14408, which

Re: Request for post-freeze merge exception

2018-09-04 Thread dinesh.jo...@yahoo.com.INVALID
+1 Dinesh On Tuesday, September 4, 2018, 12:51:49 PM PDT, Ariel Weisberg wrote: +1 Transient Replication had some rebase pain as well, but we were able to get through it at the last minute. The traffic on the last few days was pretty heavy with several substantial commits. On Tue,

Re: Request for post-freeze merge exception

2018-09-04 Thread Ariel Weisberg
+1 Transient Replication had some rebase pain as well, but we were able to get through it at the last minute. The traffic on the last few days was pretty heavy with several substantial commits. On Tue, Sep 4, 2018, at 2:19 PM, Jeff Jirsa wrote: > Seems like a reasonable thing to merge to me.

Re: Request for post-freeze merge exception

2018-09-04 Thread Jeff Jirsa
Seems like a reasonable thing to merge to me. Nothing else has been committed, it was approved pre-freeze, seems like the rush to merge was bound to have some number of rebase casualties. On Tue, Sep 4, 2018 at 11:15 AM Sam Tunnicliffe wrote: > Hey all, > > On 2018-31-08 CASSANDRA-14145 had

Request for post-freeze merge exception

2018-09-04 Thread Sam Tunnicliffe
Hey all, On 2018-31-08 CASSANDRA-14145 had been +1'd by two reviewers and CI was green, and so it was marked Ready To Commit. This was before the 4.0 feature freeze but before it landed, CASSANDRA-14408, which touched a few common areas of the code, was merged. I didn't have chance to finish the