Re: Stabilising Internode Messaging in 4.0

2019-04-10 Thread Oleksandr Petrov
Sorry to pick only a few points to address, but I think these are ones where I can contribute productively to the discussion. > In principle, I agree with the technical improvements you mention (backpressure / checksumming / etc). These things should be there. Are they a hard requirement for 4.0?

Re: Stabilising Internode Messaging in 4.0

2019-04-10 Thread Dinesh Joshi
> On Apr 10, 2019, at 9:06 AM, Sankalp Kohli wrote: > > I think we should wait for testing doc on confluence to come up and discuss > what all needs to be added there to gain confidence. > > If the work is more to split the patch into smaller parts and delays 4.0 even > more, can we use time

Re: Stabilising Internode Messaging in 4.0

2019-04-10 Thread Sankalp Kohli
I think we should wait for testing doc on confluence to come up and discuss what all needs to be added there to gain confidence. If the work is more to split the patch into smaller parts and delays 4.0 even more, can we use time in adding more test coverage, documentation and design docs to th

Re: Stabilising Internode Messaging in 4.0

2019-04-10 Thread Jordan West
There is a lot of discuss here so I’ll try to keep my opinions brief: 1. The bug fixes are a requirement in order to have a stable 4.0. Whether they come from this patch or the original I have less of an opinion. I do think its important to minimize code changes at this time in the development/fre

Cassandra 4.0 Quality and Stability Update

2019-04-10 Thread Jordan West
In September, the community chose to freeze trunk to begin working on Quality and Stability with the goal of releasing the most stable Cassandra major in the project’s history. While lots of work has been ongoing and folks could follow along with progress on JIRA I thought it would be useful to cov

Re: Stabilising Internode Messaging in 4.0

2019-04-10 Thread Dinesh Joshi
Here's are my 2¢. I think the general direction of this work is valuable but I have a few concerns I’d like to address. More inline. > On Apr 4, 2019, at 1:13 PM, Aleksey Yeschenko wrote: > > I would like to propose CASSANDRA-15066 [1] - an important set of bug fixes > and stability improvemen

Re: Stabilising Internode Messaging in 4.0

2019-04-10 Thread Oleksandr Petrov
To be fair, even though the patch totals to 20K LoC, the core of the patch is within reasonable bounds (around net.async.*). There are many changes because of the code that got moved around. Some parts changes look large because Java is quite a verbose language (e.g., metric tables). Unfortunately,

Re: Stabilising Internode Messaging in 4.0

2019-04-10 Thread Benedict Elliott Smith
Appreciate everyone's input. It sounds like there's broad agreement that the fixes need to make it into 4.0, which I'm really pleased to see. The question seems to be moving towards scope and timing. TL;DR: This patch is probably the most efficient route to a stable 4.0. The patch is already re