Re: Should we change 4.1 to G1 and offheap_objects ?

2022-11-16 Thread C. Scott Andreas
We have precedent for changing defaults that have near-universal positive impact in patchlevel releases, yep. disk_access_mode: auto -> mmap_index_only comes to mind. - Scott > On Nov 16, 2022, at 6:49 PM, Derek Chen-Becker wrote: > > I'm fine with not including G1 in 4.1, but would we consi

Re: Should we change 4.1 to G1 and offheap_objects ?

2022-11-16 Thread Derek Chen-Becker
I'm fine with not including G1 in 4.1, but would we consider inclusion for 4.1.X down the road once validation has been done? Derek On Wed, Nov 16, 2022 at 4:39 PM David Capwell wrote: > > Getting poked in Slack to be more explicit in this thread… > > Switching to G1 on trunk, +1 > Switching to

Re: Should we change 4.1 to G1 and offheap_objects ?

2022-11-16 Thread C. Scott Andreas
I share David and Aleksey’s views on this. We shouldn’t make major defaults changes right before RC. Might be worth adding a release note recommending users try them, and that they may become default in a future release though. — Scott > On Nov 16, 2022, at 3:38 PM, David Capwell wrote: > >

Re: Should we change 4.1 to G1 and offheap_objects ?

2022-11-16 Thread David Capwell
Getting poked in Slack to be more explicit in this thread… Switching to G1 on trunk, +1 Switching to G1 on 4.1, -1. 4.1 is about to be released and this isn’t a bug fix but a perf improvement ticket and as such should go through validation that the perf improvements are seen, there is not enou

Re: Should we change 4.1 to G1 and offheap_objects ?

2022-11-16 Thread J. D. Jordan
Heap -+1 for G1 in trunk+0 for G1 in 4.1 - I think it’s worthwhile and fairly well tested but I understand pushback against changing this so late in the game.Memtable --1 for off heap in 4.1. I think this needs more testing and isn’t something to change at the last minute.+1 for running performance

Re: Should we change 4.1 to G1 and offheap_objects ?

2022-11-16 Thread Josh McKenzie
To clarify: -0 here on G1 as default for 4.1 as well; I'd like us to prioritize digging into G1's behavior on small heaps vs. CMS w/our default tuning sooner rather than later. With that info I'd likely be a strong +1 on the shift. -1 on switching to offheap_objects for 4.1 RC; again, think this

Re: Should we change 4.1 to G1 and offheap_objects ?

2022-11-16 Thread Aleksey Yeshchenko
All right. I’ll clarify then. -0 on switching the default to G1 *this late* just before RC1. -1 on switching the default offheap_objects *for 4.1 RC1*, but all for it in principle, for 4.2, after we run some more test and resolve the concerns raised by Jeff. Let’s please try to avoid this kind