Re: [DISCUSS] CASSANDRA-17292 Move cassandra.yaml toward a nested structure around major database concepts

2022-02-23 Thread Maulin Vasavada
Great discussion. It would be an implementation detail but we could imagine having a single interface for reading config and providing readers for old or/and new configuration formats. If we can streamline reading of all configs from that single interface we would have much centralized (following

Re: Build tool

2022-02-03 Thread Maulin Vasavada
On the onboarding new contributors I can definitely say that I agree with the earlier comment about 'getting surprised to see ant' (having worked on Maven and Gradle for the last 10+ years). Also, I would recount a specific challenge I had with making the 'examples' folder as a sub-module in

Re: Build tool

2022-02-02 Thread Maulin Vasavada
Hi Aleksei I was thinking about the same - build tool. I have used both - Maven and Gradle. In my experience, while Gradle has a rich DSL and the corresponding power, with constant changes in Gradle across versions it is difficult to focus on the actual product (like Cassandra in this case)

Re: Resurrection of CASSANDRA-9633 - SSTable encryption

2021-11-19 Thread Maulin Vasavada
Basically, we also have to think about how operable these changes will be for operators in multi-tenant, multi-cluster/dc environments w.r.t. key rotations, security, key deployments etc. On Fri, Nov 19, 2021 at 8:03 PM Maulin Vasavada wrote: > Hi all > > Really interesting disc

Re: Resurrection of CASSANDRA-9633 - SSTable encryption

2021-11-19 Thread Maulin Vasavada
Hi all Really interesting discussion. I started reading this thread and still have to catch-up a lot but based on my experience many big organizations ultimately settle on having over-the-wire encryption combined with OS/disk encryption to comply with the security requirements for various reasons

Re: [DISCUSS] CASSANDRA-17031: Add support for PEM based key material for SSL

2021-10-12 Thread Maulin Vasavada
+1 Dinesh. It will be like that. For client and server both encryption options you can choose different key material types. I'll raise a PR soon and you can check the tests I've. Thanks Maulin On Tue, Oct 12, 2021 at 9:22 PM Dinesh Joshi wrote: > On 10/11/21 12:34 PM, Maulin Vasavada wr

Re: [DISCUSS] CASSANDRA-17031: Add support for PEM based key material for SSL

2021-10-11 Thread Maulin Vasavada
ermission denied error when I try to access the ticket. What > do I need to do to get access? > > Thanks, > > Derek > > On Mon, Oct 11, 2021 at 1:34 PM Maulin Vasavada > > wrote: > > > Changing the subject for this discussion with the JIRA ticket now. >

[DISCUSS] CASSANDRA-17031: Add support for PEM based key material for SSL

2021-10-11 Thread Maulin Vasavada
private keys and JKS based truststore? Thanks Maulin On Mon, Oct 11, 2021 at 12:02 PM Maulin Vasavada wrote: > Thanks all for your responses. So I'll give back the CEP number (if I > can). > > For Dinesh's comment, I think we can take up in the DISCUSS thread for the > JIRA ticket

Re: [DISCUSS] CEP-17: Add support for PEM based key material for SSL

2021-10-11 Thread Maulin Vasavada
om the community, > whereas this seems like a straightforward feature we might want to > advertise to ensure others have an opportunity to offer their expertise and > opinions on. > >> > >> > >> From: Maulin Vasavada > >> Date: Monday, 11 October 2021 at

[DISCUSS] CEP-17: Add support for PEM based key material for SSL

2021-10-10 Thread Maulin Vasavada
Hi all, I would like to start this discussion thread for the CEP-17 . I think it would be a great addition to support a commonly used format for private keys and trusted certificates

Re: [DISCUSS] CEP-9: Make SSLContext creation pluggable

2021-07-16 Thread Maulin Vasavada
Hi all Thank you for the vote on this. Since the CEP is Accepted now, do we discuss PR/code details on the JIRA/Github right? Thanks Maulin On Wed, Jul 14, 2021 at 5:28 PM Maulin Vasavada wrote: > Thanks Berenguer. Mainly I did detailed PR since I was not familiar with > Cassandra co

Re: [VOTE] CIP-9: Make SSLContext creation pluggable

2021-07-16 Thread Maulin Vasavada
Yay! Thanks Benjamin and everybody who participated. Feeling fully energized to finish the work! On Fri, Jul 16, 2021 at 9:59 AM Benjamin Lerer wrote: > Vote passes with five binding +1, three non binding +1 and no vetos. > > Le mer. 14 juil. 2021 à 16:02, Joshua McKenzie a > écrit : > > > +1

Re: [DISCUSS] CEP-9: Make SSLContext creation pluggable

2021-07-14 Thread Maulin Vasavada
ally matter at this point in > time. > > But that might be only me. :-) > > > > Best regards, > > Ekaterina > > > > On Mon, 12 Jul 2021 at 15:47, Maulin Vasavada > > > wrote: > > > >> Thank you Benjamin. Sounds good to me. > >>

Re: [DISCUSS] CEP-9: Make SSLContext creation pluggable

2021-07-12 Thread Maulin Vasavada
disagrees, I will start the vote tomorrow. > > > > Le sam. 10 juil. 2021 à 07:05, Mick Semb Wever a écrit : > > > Thanks for bringing this back to the ML Maulin. > > Very much appreciated. > > > > On Sat, 10 Jul 2021 at 00:04, Maulin Vasavada >

Re: [DISCUSS] CEP-9: Make SSLContext creation pluggable

2021-07-09 Thread Maulin Vasavada
a separate branch and show how interface will change with keeping Common Encryption options + map instead of just the map. Thanks Maulin On Fri, Jul 9, 2021 at 2:59 PM Maulin Vasavada wrote: > Stefan Miklosovic > <https://cwiki.apache.org/confluence/display/~stefan.miklosovic> &

Re: [DISCUSS] CEP-9: Make SSLContext creation pluggable

2021-07-09 Thread Maulin Vasavada
Stefan Miklosovic <https://cwiki.apache.org/confluence/display/~stefan.miklosovic> Hi MAULIN VASAVADA <https://cwiki.apache.org/confluence/display/~maulin.vasavada>, few more observations. I see that you have commented again on JIRA and I am starting to be confused where to comment

Re: [DISCUSS] CEP-9: Make SSLContext creation pluggable

2021-07-09 Thread Maulin Vasavada
erface by default logic for which it works but there isnt any (public) example how to do yet another impl. there is a directory called "examples" in the root of the repository. On Fri, Jul 9, 2021 at 2:58 PM Maulin Vasavada wrote: > [image: maulin.vasavada]Maulin Vasavada > <

Re: [DISCUSS] CEP-9: Make SSLContext creation pluggable

2021-07-09 Thread Maulin Vasavada
[image: maulin.vasavada]Maulin Vasavada <https://issues.apache.org/jira/secure/ViewProfile.jspa?name=maulin.vasavada> added a comment - Yesterday - edited On second thoughts Stefan Miklosovic <https://issues.apache.org/jira/secure/ViewProfile.jspa?name=stefan.miklosovic>, I feel i

Re: [DISCUSS] CEP-9: Make SSLContext creation pluggable

2021-07-09 Thread Maulin Vasavada
o copy paste this discussion to DISCUSS thread also. Can you please post/copy your comments and I'd copy mine there? On Fri, Jul 9, 2021 at 2:58 PM Maulin Vasavada wrote: > [image: stefan.miklosovic]Stefan Miklosovic > <https://issues.apache.org/jira/secure/ViewProfile.jspa?name=stefan.miklosovic> &

Re: [DISCUSS] CEP-9: Make SSLContext creation pluggable

2021-07-09 Thread Maulin Vasavada
e know it indeed works as intended. It is strange to just code up an interface by default logic for which it works but there isnt any (public) example how to do yet another impl. On Fri, Jul 9, 2021 at 2:57 PM Maulin Vasavada wrote: > Sumanth Pasupuleti > <https://issues.apache.

Re: [DISCUSS] CEP-9: Make SSLContext creation pluggable

2021-07-09 Thread Maulin Vasavada
Sumanth Pasupuleti <https://issues.apache.org/jira/secure/ViewProfile.jspa?name=sumanth.pasupuleti> added a comment - 07/Jun/21 15:13 Maulin Vasavada <https://issues.apache.org/jira/secure/ViewProfile.jspa?name=maulin.vasavada> left a couple of review comments, but lgtm o

Re: [DISCUSS] CEP-9: Make SSLContext creation pluggable

2021-07-09 Thread Maulin Vasavada
Hi all I wanted to consolidate a couple of comments that started in JIRA/Wiki here to keep it in one place. I'll post different posts as replies for each comment. Thanks Maulin On Tue, Jun 29, 2021 at 1:07 PM Maulin Vasavada wrote: > ^^^ bumping up ^^^ this thread since people might have m

Re: [DISCUSS] Clarifying the CEP process

2021-07-08 Thread Maulin Vasavada
Based on my experience I definitely like the process where everything that needs to be discussed about CEP remains in DISCUSS thread. Also I like the comment made above " The jira ticket and PR can be created as a PoC to help explain and illustrate the CEP, but nothing more than that.". Sometimes

Re: [DISCUSS] CEP-9: Make SSLContext creation pluggable

2021-06-29 Thread Maulin Vasavada
ection in the CEP, I have coded for one option (here <https://github.com/maulin-vasavada/cassandra/commit/256ad30ecedbc50d66d8a039f8ca9e47074737ce>) and now will do for another option very soon. On Wed, Jun 2, 2021 at 5:11 PM Maulin Vasavada wrote: > Thank you Dinesh and everybody.

Re: [DISCUSS] CIP-9: Make SSLContext creation pluggable

2021-06-02 Thread Maulin Vasavada
silently. > Will take a look. It’s just that we’re currently busy so bear with us. > > Thanks, > > Dinesh > > > On Jun 2, 2021, at 3:28 PM, Maulin Vasavada > wrote: > > > > Hi all > > > > ^^^ bump ^^^ I've raised the PR and am waiting for th

Re: [DISCUSS] CIP-9: Make SSLContext creation pluggable

2021-06-02 Thread Maulin Vasavada
Hi all ^^^ bump ^^^ I've raised the PR and am waiting for the review. Once I see that the suggested changes are directionally right I'll start a VOTE thread on the CEP (unless I am recommended to follow another process). Thanks Maulin On Thu, May 27, 2021 at 1:29 PM Maulin Vasavada wrote

Re: [DISCUSS] CIP-9: Make SSLContext creation pluggable

2021-05-27 Thread Maulin Vasavada
:04 AM Maulin Vasavada wrote: > Sounds good Brandon. I'll raise the PR in a couple of hours from now. > Thanks. > > On Thu, May 27, 2021 at 10:14 AM Brandon Williams > wrote: > >> You can raise a PR in any state, but review will be a different >> matter. I would go ah

Re: [DISCUSS] CIP-9: Make SSLContext creation pluggable

2021-05-27 Thread Maulin Vasavada
out from there. > > On Thu, May 27, 2021 at 12:12 PM Maulin Vasavada > wrote: > > > > Hi all > > > > I think I am close to raising a PR now but my CircleCI job > > <https://app.circleci.com/pipelines/github/maulin-vasavada/cassandra> > > doesn't ma

Re: [DISCUSS] CIP-9: Make SSLContext creation pluggable

2021-05-27 Thread Maulin Vasavada
Hi all I think I am close to raising a PR now but my CircleCI job <https://app.circleci.com/pipelines/github/maulin-vasavada/cassandra> doesn't make progress beyond key tasks success like unit tests, dtests, cqlshlibtests. Any recommendation on if we need to see the whole CircleCI job

Re: [DISCUSS] CIP-9: Make SSLContext creation pluggable

2021-05-21 Thread Maulin Vasavada
I am almost done with all changes except the code snippet in the EncryptioOptions.java which determines 'enabled' and 'optional' encryption flags. Will raise the PR soon once I see my CircleCI getting green. On Fri, May 21, 2021 at 9:24 AM Maulin Vasavada wrote: > FYI - I am working on PR

Re: [DISCUSS] CIP-9: Make SSLContext creation pluggable

2021-05-21 Thread Maulin Vasavada
FYI - I am working on PR. I made some changes and trying to run tests. On Tue, May 18, 2021 at 10:14 PM Maulin Vasavada wrote: > Thanks Nate for reviewing the CEP. Yes for change #3 in the CEP, I mean to > have only single Default Impl and that would be a final class, not > ov

Re: [DISCUSS] CIP-9: Make SSLContext creation pluggable

2021-05-18 Thread Maulin Vasavada
oposed changes, I'm keen to only support a single default > impl in-tree. I don't think we should be in the business of picking > implementation to support. It looks like this is your intention as well? > > Thanks again, > -Nate > > On Wed, May 19, 2021 at 12:05 PM Maulin Va

[DISCUSS] CIP-9: Make SSLContext creation pluggable

2021-05-18 Thread Maulin Vasavada
Hi all Starting a discussion thread for the CIP-9 - https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-9%3A+Make+SSLContext+creation+pluggable However, while writing the CIP two areas that came up in my mind where I need to seek guidance apart from the other discussion that we would have

Requesting the permission to create a CIP

2021-05-17 Thread Maulin Vasavada
Hi all Can I get the permission to create a CIP (this is based on the recommendation from CASSANDRA-1 ticket)? My username: maulin.vasavada Email: maulin.vasav...@gmail.com Thanks Maulin

Re: [DISCUSS] CASSANDRA-16666 - Make SSLContext creation pluggable/extensible

2021-05-14 Thread Maulin Vasavada
May 2021 at 10:15, Maulin Vasavada > wrote: > > > Hi > > > > I just created the CASSANDRA-1 JIRA ticket. Please let me know if the > > discussion around that should happen here or on the jira ticket. > > > > I've contributed to Apache Kafka in th

Re: [DISCUSS] CASSANDRA-16666 - Make SSLContext creation pluggable/extensible

2021-05-13 Thread Maulin Vasavada
/ review. > > See: > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=95652201 > > Looking forward to it. > > ~Josh > > On Wed, May 12, 2021 at 8:15 PM Maulin Vasavada > > wrote: > > > Hi > > > > I just created the CASSANDRA-1 JIR

[DISCUSS] CASSANDRA-16666 - Make SSLContext creation pluggable/extensible

2021-05-12 Thread Maulin Vasavada
Hi I just created the CASSANDRA-1 JIRA ticket. Please let me know if the discussion around that should happen here or on the jira ticket. I've contributed to Apache Kafka in the past but they have a little different process for certain contributions by following KIP route. Looking forward