Re: Repair scheduling tools

2018-04-03 Thread Qingcun Zhou
ke it easier to use. > > > >> > > > >> > > > >> > > > >> Is this something we should be doing? If so, what should it look > like? > > > >> > > > >> > > > >> > > > >> Personally, I feel like this is a pretty big gap in the project and > > > >> would like to see an out of process tool offered. Ideally, Cassandra > > > >> would just take care of itself, but writing a distributed repair > > > >> scheduler that you trust to run in production is a lot harder than > > > >> writing a single process management application that can failover. > > > >> > > > >> > > > >> > > > >> Any thoughts on this? > > > >> > > > >> > > > >> > > > >> Thanks, > > > >> > > > >> > > > >> > > > >> Blake > > > >> > > > >> > > > > > > - > > > To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org > > > For additional commands, e-mail: dev-h...@cassandra.apache.org > > > > > > > > > - > > > To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org > > > For additional commands, e-mail: dev-h...@cassandra.apache.org > > > > > > > > > -- Thank you & Best Regards, --Simon (Qingcun) Zhou

Re: CASSANDRA-8527

2017-12-21 Thread Qingcun Zhou
wrote: > On Thu, Dec 21, 2017 at 12:33 PM, Qingcun Zhou <zhouqing...@gmail.com> > wrote: > > > I brought up Mockito topic couple of months ago but some committers don't > > think we should introduce more dependencies. > > > > > I don't see any indication of

Re: Code quality, principles and rules

2017-03-16 Thread Qingcun Zhou
ee to do a wide ranging refactor, because you at least counted for 8 > scenarios and you put unit test traps so that some rules are enforced. (Or > the person changing the code has to actively REMOVE your tests asserting it > was not or no longer is valid). Later on you (or someone else) __STILL__ > might screw the entire thing up, but at least you can now build forward. > > Anyway that patch on compaction was great and I am sure it improved things. > That being said it did not add any tests :). So it can easily be undone by > the next person who does not understand the specific issue trying to be > addressed. Inline comments almost scream to me 'we need a test' not > everyone believes that. > -- Thank you & Best Regards, --Simon (Qingcun) Zhou