Re: GitHub PR ticket spam

[dinesh.jo...@yahoo.com.INVALID]

Nice! Thanks for getting this done.
Dinesh 

On Wednesday, August 8, 2018, 2:21:22 PM PDT, Mick Semb Wever 
 wrote:  
 
 > > 
> > Great idea. +1 to moving it to the work log.
> > 
> 
> https://issues.apache.org/jira/browse/INFRA-16879 


This is working now.

See eg https://issues.apache.org/jira/browse/CASSANDRA-12926 
 (which I hijacked for testing and the comments in the PR have since been 
deleted)

cheers,
mick

-
To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org
For additional commands, e-mail: dev-h...@cassandra.apache.org

  

Re: GitHub PR ticket spam

[Mick Semb Wever]

> > 
> > Great idea. +1 to moving it to the work log.
> > 
> 
> https://issues.apache.org/jira/browse/INFRA-16879 


This is working now.

See eg https://issues.apache.org/jira/browse/CASSANDRA-12926 
 (which I hijacked for testing and the comments in the PR have since been 
deleted)

cheers,
mick

-
To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org
For additional commands, e-mail: dev-h...@cassandra.apache.org

Re: GitHub PR ticket spam

[kurt greaves]

+1

> Or perhaps we should require committers to summarise in the comments.  For
> most tickets, perhaps just stating ’nits from GitHub comments’.  But for
> any complex tickets, summarising the conclusions of any unexpected logical
> or structural discussion would be really helpful for posterity.  This has
> always been true, but especially so now, given how hard the replicated
> comments are to parse.

Yeah this. I think design discussion should continue to at least be
summarised in the comments. The worklog is still going to be painful to
parse, so should really only be used for the minor details and a record
IMO. I don't think we need to make this a hard requirement though, people
already do this so as long as we keep doing it setting the example should
be good enough.


On 7 August 2018 at 02:52, Benedict Elliott Smith 
wrote:

> Also +1
>
> It might perhaps be nice to (just once) have ASF Bot comment that a GitHub
> discussion has been replicated to the worklog? In the Arrow example, for
> instance, it isn’t immediately obvious that there are any worklog comments
> to look at.
>
> Or perhaps we should require committers to summarise in the comments.  For
> most tickets, perhaps just stating ’nits from GitHub comments’.  But for
> any complex tickets, summarising the conclusions of any unexpected logical
> or structural discussion would be really helpful for posterity.  This has
> always been true, but especially so now, given how hard the replicated
> comments are to parse.
>
>
> > On 6 Aug 2018, at 17:18, Jeremiah D Jordan 
> wrote:
> >
> > Oh nice.  I like the idea of keeping it but moving it to the worklog
> tab.  +1 on that from me.
> >
> >> On Aug 6, 2018, at 5:34 AM, Stefan Podkowinski  wrote:
> >>
> >> +1 for worklog option
> >>
> >> Here's an example ticket from Arrow, where they seem to be using the
> >> same approach:
> >> https://urldefense.proofpoint.com/v2/url?u=https-3A__issues.
> apache.org_jira_browse_ARROW-2D2583&d=DwICaQ&c=adz96Xi0w1RHqtPMowiL2g&r=
> CNZK3RiJDLqhsZDG6FQGnXn8WyPRCQhp4x_uBICNC0g&m=wYZwHSze6YITTXgzOrEvfr_
> onojahtjeJRzGAt8ByzM&s=KWt0xsOv9ESaieg432edGvPhktGkWHxVuLAdNyORiYY&e= <
> https://urldefense.proofpoint.com/v2/url?u=https-
> 3A__issues.apache.org_jira_browse_ARROW-2D2583&d=DwICaQ&
> c=adz96Xi0w1RHqtPMowiL2g&r=CNZK3RiJDLqhsZDG6FQGnXn8WyPRCQhp4x_uBICNC0g&m=
> wYZwHSze6YITTXgzOrEvfr_onojahtjeJRzGAt8ByzM&s=
> KWt0xsOv9ESaieg432edGvPhktGkWHxVuLAdNyORiYY&e=>
> >>
> >>
> >> On 05.08.2018 09:56, Mick Semb Wever wrote:
>  I find this a bit annoying while subscribed to commits@,
>  especially since we created pr@ for these kind of messages. Also I
> don't
>  really see any value in mirroring all github comments to the ticket.
> >>>
> >>>
> >>> I agree with you Stefan. It makes the jira tickets quite painful to
> read. And I tend to make comments on the commits rather than the PRs so to
> avoid spamming back to the jira ticket.
> >>>
> >>> But the linking to the PR is invaluable. And I can see Ariel's point
> about a chronological historical archive.
> >>>
> >>>
>  Ponies would be for this to be mirrored to a tab
>  separate from comments in JIRA.
> >>>
> >>>
> >>> Ariel, that would be the the "worklog" option.
> >>> https://urldefense.proofpoint.com/v2/url?u=https-3A__
> reference.apache.org_pmc_github&d=DwICaQ&c=adz96Xi0w1RHqtPMowiL2g&r=
> CNZK3RiJDLqhsZDG6FQGnXn8WyPRCQhp4x_uBICNC0g&m=wYZwHSze6YITTXgzOrEvfr_
> onojahtjeJRzGAt8ByzM&s=1lWQawAO9fITzakpnmdzERuCbZs6IGQsUH_EEIMCMqs&e= <
> https://urldefense.proofpoint.com/v2/url?u=https-
> 3A__reference.apache.org_pmc_github&d=DwICaQ&c=adz96Xi0w1RHqtPMowiL2g&r=
> CNZK3RiJDLqhsZDG6FQGnXn8WyPRCQhp4x_uBICNC0g&m=wYZwHSze6YITTXgzOrEvfr_
> onojahtjeJRzGAt8ByzM&s=1lWQawAO9fITzakpnmdzERuCbZs6IGQsUH_EEIMCMqs&e=>
> >>>
> >>> If this works for you, and others, I can open a INFRA to switch to
> worklog.
> >>> wdyt?
> >>>
> >>>
> >>> Mick.
> >>>
> >>> -
> >>> To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org  dev-unsubscr...@cassandra.apache.org>
> >>> For additional commands, e-mail: dev-h...@cassandra.apache.org
> 
> >>>
> >>
> >> -
> >> To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org  dev-unsubscr...@cassandra.apache.org>
> >> For additional commands, e-mail: dev-h...@cassandra.apache.org  dev-h...@cassandra.apache.org>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org
> For additional commands, e-mail: dev-h...@cassandra.apache.org
>
>

Re: GitHub PR ticket spam

[Jordan West]

+1 (nb) for the worklog approach.

Jordan

On Mon, Aug 6, 2018 at 4:53 PM dinesh.jo...@yahoo.com.INVALID
 wrote:

> +1 for preserving it as worklog.
> Dinesh
> P.S.: Apologies for the github spam :-)
> On Monday, August 6, 2018, 3:09:28 PM PDT, Mick Semb Wever <
> m...@apache.org> wrote:
>
>
> >
> > Great idea. +1 to moving it to the work log.
> >
>
>
> https://issues.apache.org/jira/browse/INFRA-16879
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org
> For additional commands, e-mail: dev-h...@cassandra.apache.org
>
>

Re: GitHub PR ticket spam

[dinesh.jo...@yahoo.com.INVALID]

+1 for preserving it as worklog.
Dinesh 
P.S.: Apologies for the github spam :-)
On Monday, August 6, 2018, 3:09:28 PM PDT, Mick Semb Wever 
 wrote:  
 
 
> 
> Great idea. +1 to moving it to the work log.
> 


https://issues.apache.org/jira/browse/INFRA-16879 


-
To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org
For additional commands, e-mail: dev-h...@cassandra.apache.org

  

Re: GitHub PR ticket spam

[Mick Semb Wever]

> 
> Great idea. +1 to moving it to the work log.
> 


https://issues.apache.org/jira/browse/INFRA-16879 


-
To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org
For additional commands, e-mail: dev-h...@cassandra.apache.org

Re: GitHub PR ticket spam

[Benedict Elliott Smith]

Also +1

It might perhaps be nice to (just once) have ASF Bot comment that a GitHub 
discussion has been replicated to the worklog? In the Arrow example, for 
instance, it isn’t immediately obvious that there are any worklog comments to 
look at.

Or perhaps we should require committers to summarise in the comments.  For most 
tickets, perhaps just stating ’nits from GitHub comments’.  But for any complex 
tickets, summarising the conclusions of any unexpected logical or structural 
discussion would be really helpful for posterity.  This has always been true, 
but especially so now, given how hard the replicated comments are to parse.


> On 6 Aug 2018, at 17:18, Jeremiah D Jordan  wrote:
> 
> Oh nice.  I like the idea of keeping it but moving it to the worklog tab.  +1 
> on that from me.
> 
>> On Aug 6, 2018, at 5:34 AM, Stefan Podkowinski  wrote:
>> 
>> +1 for worklog option
>> 
>> Here's an example ticket from Arrow, where they seem to be using the
>> same approach:
>> https://urldefense.proofpoint.com/v2/url?u=https-3A__issues.apache.org_jira_browse_ARROW-2D2583&d=DwICaQ&c=adz96Xi0w1RHqtPMowiL2g&r=CNZK3RiJDLqhsZDG6FQGnXn8WyPRCQhp4x_uBICNC0g&m=wYZwHSze6YITTXgzOrEvfr_onojahtjeJRzGAt8ByzM&s=KWt0xsOv9ESaieg432edGvPhktGkWHxVuLAdNyORiYY&e=
>>  
>> 
>> 
>> 
>> On 05.08.2018 09:56, Mick Semb Wever wrote:
 I find this a bit annoying while subscribed to commits@,
 especially since we created pr@ for these kind of messages. Also I don't
 really see any value in mirroring all github comments to the ticket.
>>> 
>>> 
>>> I agree with you Stefan. It makes the jira tickets quite painful to read. 
>>> And I tend to make comments on the commits rather than the PRs so to avoid 
>>> spamming back to the jira ticket.
>>> 
>>> But the linking to the PR is invaluable. And I can see Ariel's point about 
>>> a chronological historical archive.
>>> 
>>> 
 Ponies would be for this to be mirrored to a tab 
 separate from comments in JIRA.
>>> 
>>> 
>>> Ariel, that would be the the "worklog" option.
>>> https://urldefense.proofpoint.com/v2/url?u=https-3A__reference.apache.org_pmc_github&d=DwICaQ&c=adz96Xi0w1RHqtPMowiL2g&r=CNZK3RiJDLqhsZDG6FQGnXn8WyPRCQhp4x_uBICNC0g&m=wYZwHSze6YITTXgzOrEvfr_onojahtjeJRzGAt8ByzM&s=1lWQawAO9fITzakpnmdzERuCbZs6IGQsUH_EEIMCMqs&e=
>>>  
>>> 
>>> 
>>> If this works for you, and others, I can open a INFRA to switch to worklog.
>>> wdyt?
>>> 
>>> 
>>> Mick.
>>> 
>>> -
>>> To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org 
>>> 
>>> For additional commands, e-mail: dev-h...@cassandra.apache.org 
>>> 
>>> 
>> 
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org 
>> 
>> For additional commands, e-mail: dev-h...@cassandra.apache.org 
>> 


-
To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org
For additional commands, e-mail: dev-h...@cassandra.apache.org

Re: GitHub PR ticket spam

[Jonathan Haddad]

+1 to worklog

On Mon, Aug 6, 2018 at 9:44 AM Ariel Weisberg  wrote:

> Hi,
>
> Great idea. +1 to moving it to the work log.
>
> Thanks,
> Ariel
>
> On Mon, Aug 6, 2018, at 12:40 PM, Aleksey Yeshchenko wrote:
> > Nice indeed. I assume it also doesn’t spam commits@ when done this way,
> > in which case double +1 from me.
> >
> > —
> > AY
> >
> > On 6 August 2018 at 17:18:36, Jeremiah D Jordan
> > (jeremiah.jor...@gmail.com) wrote:
> >
> > Oh nice. I like the idea of keeping it but moving it to the worklog tab.
> > +1 on that from me.
> >
> > > On Aug 6, 2018, at 5:34 AM, Stefan Podkowinski 
> wrote:
> > >
> > > +1 for worklog option
> > >
> > > Here's an example ticket from Arrow, where they seem to be using the
> > > same approach:
> > >
> https://urldefense.proofpoint.com/v2/url?u=https-3A__issues.apache.org_jira_browse_ARROW-2D2583&d=DwICaQ&c=adz96Xi0w1RHqtPMowiL2g&r=CNZK3RiJDLqhsZDG6FQGnXn8WyPRCQhp4x_uBICNC0g&m=wYZwHSze6YITTXgzOrEvfr_onojahtjeJRzGAt8ByzM&s=KWt0xsOv9ESaieg432edGvPhktGkWHxVuLAdNyORiYY&e=
> <
> https://urldefense.proofpoint.com/v2/url?u=https-3A__issues.apache.org_jira_browse_ARROW-2D2583&d=DwICaQ&c=adz96Xi0w1RHqtPMowiL2g&r=CNZK3RiJDLqhsZDG6FQGnXn8WyPRCQhp4x_uBICNC0g&m=wYZwHSze6YITTXgzOrEvfr_onojahtjeJRzGAt8ByzM&s=KWt0xsOv9ESaieg432edGvPhktGkWHxVuLAdNyORiYY&e=>
>
> > >
> > >
> > > On 05.08.2018 09:56, Mick Semb Wever wrote:
> > >>> I find this a bit annoying while subscribed to commits@,
> > >>> especially since we created pr@ for these kind of messages. Also I
> don't
> > >>> really see any value in mirroring all github comments to the
> ticket.
> > >>
> > >>
> > >> I agree with you Stefan. It makes the jira tickets quite painful to
> read. And I tend to make comments on the commits rather than the PRs so to
> avoid spamming back to the jira ticket.
> > >>
> > >> But the linking to the PR is invaluable. And I can see Ariel's point
> about a chronological historical archive.
> > >>
> > >>
> > >>> Ponies would be for this to be mirrored to a tab
> > >>> separate from comments in JIRA.
> > >>
> > >>
> > >> Ariel, that would be the the "worklog" option.
> > >>
> https://urldefense.proofpoint.com/v2/url?u=https-3A__reference.apache.org_pmc_github&d=DwICaQ&c=adz96Xi0w1RHqtPMowiL2g&r=CNZK3RiJDLqhsZDG6FQGnXn8WyPRCQhp4x_uBICNC0g&m=wYZwHSze6YITTXgzOrEvfr_onojahtjeJRzGAt8ByzM&s=1lWQawAO9fITzakpnmdzERuCbZs6IGQsUH_EEIMCMqs&e=
> <
> https://urldefense.proofpoint.com/v2/url?u=https-3A__reference.apache.org_pmc_github&d=DwICaQ&c=adz96Xi0w1RHqtPMowiL2g&r=CNZK3RiJDLqhsZDG6FQGnXn8WyPRCQhp4x_uBICNC0g&m=wYZwHSze6YITTXgzOrEvfr_onojahtjeJRzGAt8ByzM&s=1lWQawAO9fITzakpnmdzERuCbZs6IGQsUH_EEIMCMqs&e=>
>
> > >>
> > >> If this works for you, and others, I can open a INFRA to switch to
> worklog.
> > >> wdyt?
> > >>
> > >>
> > >> Mick.
> > >>
> > >>
> -
> > >> To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org  dev-unsubscr...@cassandra.apache.org>
> > >> For additional commands, e-mail: dev-h...@cassandra.apache.org
> 
> > >>
> > >
> > > -
> > > To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org  dev-unsubscr...@cassandra.apache.org>
> > > For additional commands, e-mail: dev-h...@cassandra.apache.org
> 
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org
> For additional commands, e-mail: dev-h...@cassandra.apache.org
>
>

-- 
Jon Haddad
http://www.rustyrazorblade.com
twitter: rustyrazorblade

Re: GitHub PR ticket spam

[Ariel Weisberg]

Hi,

Great idea. +1 to moving it to the work log.

Thanks,
Ariel

On Mon, Aug 6, 2018, at 12:40 PM, Aleksey Yeshchenko wrote:
> Nice indeed. I assume it also doesn’t spam commits@ when done this way, 
> in which case double +1 from me.
> 
> —
> AY
> 
> On 6 August 2018 at 17:18:36, Jeremiah D Jordan 
> (jeremiah.jor...@gmail.com) wrote:
> 
> Oh nice. I like the idea of keeping it but moving it to the worklog tab. 
> +1 on that from me.  
> 
> > On Aug 6, 2018, at 5:34 AM, Stefan Podkowinski  wrote:  
> >  
> > +1 for worklog option  
> >  
> > Here's an example ticket from Arrow, where they seem to be using the  
> > same approach:  
> > https://urldefense.proofpoint.com/v2/url?u=https-3A__issues.apache.org_jira_browse_ARROW-2D2583&d=DwICaQ&c=adz96Xi0w1RHqtPMowiL2g&r=CNZK3RiJDLqhsZDG6FQGnXn8WyPRCQhp4x_uBICNC0g&m=wYZwHSze6YITTXgzOrEvfr_onojahtjeJRzGAt8ByzM&s=KWt0xsOv9ESaieg432edGvPhktGkWHxVuLAdNyORiYY&e=
> >  
> > 
> >   
> >  
> >  
> > On 05.08.2018 09:56, Mick Semb Wever wrote:  
> >>> I find this a bit annoying while subscribed to commits@,  
> >>> especially since we created pr@ for these kind of messages. Also I don't  
> >>> really see any value in mirroring all github comments to the ticket.  
> >>  
> >>  
> >> I agree with you Stefan. It makes the jira tickets quite painful to read. 
> >> And I tend to make comments on the commits rather than the PRs so to avoid 
> >> spamming back to the jira ticket.  
> >>  
> >> But the linking to the PR is invaluable. And I can see Ariel's point about 
> >> a chronological historical archive.  
> >>  
> >>  
> >>> Ponies would be for this to be mirrored to a tab  
> >>> separate from comments in JIRA.  
> >>  
> >>  
> >> Ariel, that would be the the "worklog" option.  
> >> https://urldefense.proofpoint.com/v2/url?u=https-3A__reference.apache.org_pmc_github&d=DwICaQ&c=adz96Xi0w1RHqtPMowiL2g&r=CNZK3RiJDLqhsZDG6FQGnXn8WyPRCQhp4x_uBICNC0g&m=wYZwHSze6YITTXgzOrEvfr_onojahtjeJRzGAt8ByzM&s=1lWQawAO9fITzakpnmdzERuCbZs6IGQsUH_EEIMCMqs&e=
> >>  
> >> 
> >>   
> >>  
> >> If this works for you, and others, I can open a INFRA to switch to 
> >> worklog.  
> >> wdyt?  
> >>  
> >>  
> >> Mick.  
> >>  
> >> -  
> >> To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org 
> >>   
> >> For additional commands, e-mail: dev-h...@cassandra.apache.org 
> >>   
> >>  
> >  
> > -  
> > To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org 
> >   
> > For additional commands, e-mail: dev-h...@cassandra.apache.org 
> >   

-
To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org
For additional commands, e-mail: dev-h...@cassandra.apache.org

Re: GitHub PR ticket spam

[Aleksey Yeshchenko]

Nice indeed. I assume it also doesn’t spam commits@ when done this way, in 
which case double +1 from me.

—
AY

On 6 August 2018 at 17:18:36, Jeremiah D Jordan (jeremiah.jor...@gmail.com) 
wrote:

Oh nice. I like the idea of keeping it but moving it to the worklog tab. +1 on 
that from me.  

> On Aug 6, 2018, at 5:34 AM, Stefan Podkowinski  wrote:  
>  
> +1 for worklog option  
>  
> Here's an example ticket from Arrow, where they seem to be using the  
> same approach:  
> https://urldefense.proofpoint.com/v2/url?u=https-3A__issues.apache.org_jira_browse_ARROW-2D2583&d=DwICaQ&c=adz96Xi0w1RHqtPMowiL2g&r=CNZK3RiJDLqhsZDG6FQGnXn8WyPRCQhp4x_uBICNC0g&m=wYZwHSze6YITTXgzOrEvfr_onojahtjeJRzGAt8ByzM&s=KWt0xsOv9ESaieg432edGvPhktGkWHxVuLAdNyORiYY&e=
>  
> 
>   
>  
>  
> On 05.08.2018 09:56, Mick Semb Wever wrote:  
>>> I find this a bit annoying while subscribed to commits@,  
>>> especially since we created pr@ for these kind of messages. Also I don't  
>>> really see any value in mirroring all github comments to the ticket.  
>>  
>>  
>> I agree with you Stefan. It makes the jira tickets quite painful to read. 
>> And I tend to make comments on the commits rather than the PRs so to avoid 
>> spamming back to the jira ticket.  
>>  
>> But the linking to the PR is invaluable. And I can see Ariel's point about a 
>> chronological historical archive.  
>>  
>>  
>>> Ponies would be for this to be mirrored to a tab  
>>> separate from comments in JIRA.  
>>  
>>  
>> Ariel, that would be the the "worklog" option.  
>> https://urldefense.proofpoint.com/v2/url?u=https-3A__reference.apache.org_pmc_github&d=DwICaQ&c=adz96Xi0w1RHqtPMowiL2g&r=CNZK3RiJDLqhsZDG6FQGnXn8WyPRCQhp4x_uBICNC0g&m=wYZwHSze6YITTXgzOrEvfr_onojahtjeJRzGAt8ByzM&s=1lWQawAO9fITzakpnmdzERuCbZs6IGQsUH_EEIMCMqs&e=
>>  
>> 
>>   
>>  
>> If this works for you, and others, I can open a INFRA to switch to worklog.  
>> wdyt?  
>>  
>>  
>> Mick.  
>>  
>> -  
>> To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org 
>>   
>> For additional commands, e-mail: dev-h...@cassandra.apache.org 
>>   
>>  
>  
> -  
> To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org 
>   
> For additional commands, e-mail: dev-h...@cassandra.apache.org 
>   

Re: GitHub PR ticket spam

[Jeremiah D Jordan]

Oh nice.  I like the idea of keeping it but moving it to the worklog tab.  +1 
on that from me.

> On Aug 6, 2018, at 5:34 AM, Stefan Podkowinski  wrote:
> 
> +1 for worklog option
> 
> Here's an example ticket from Arrow, where they seem to be using the
> same approach:
> https://urldefense.proofpoint.com/v2/url?u=https-3A__issues.apache.org_jira_browse_ARROW-2D2583&d=DwICaQ&c=adz96Xi0w1RHqtPMowiL2g&r=CNZK3RiJDLqhsZDG6FQGnXn8WyPRCQhp4x_uBICNC0g&m=wYZwHSze6YITTXgzOrEvfr_onojahtjeJRzGAt8ByzM&s=KWt0xsOv9ESaieg432edGvPhktGkWHxVuLAdNyORiYY&e=
>  
> 
> 
> 
> On 05.08.2018 09:56, Mick Semb Wever wrote:
>>> I find this a bit annoying while subscribed to commits@,
>>> especially since we created pr@ for these kind of messages. Also I don't
>>> really see any value in mirroring all github comments to the ticket.
>> 
>> 
>> I agree with you Stefan. It makes the jira tickets quite painful to read. 
>> And I tend to make comments on the commits rather than the PRs so to avoid 
>> spamming back to the jira ticket.
>> 
>> But the linking to the PR is invaluable. And I can see Ariel's point about a 
>> chronological historical archive.
>> 
>> 
>>> Ponies would be for this to be mirrored to a tab 
>>> separate from comments in JIRA.
>> 
>> 
>> Ariel, that would be the the "worklog" option.
>> https://urldefense.proofpoint.com/v2/url?u=https-3A__reference.apache.org_pmc_github&d=DwICaQ&c=adz96Xi0w1RHqtPMowiL2g&r=CNZK3RiJDLqhsZDG6FQGnXn8WyPRCQhp4x_uBICNC0g&m=wYZwHSze6YITTXgzOrEvfr_onojahtjeJRzGAt8ByzM&s=1lWQawAO9fITzakpnmdzERuCbZs6IGQsUH_EEIMCMqs&e=
>>  
>> 
>> 
>> If this works for you, and others, I can open a INFRA to switch to worklog.
>> wdyt?
>> 
>> 
>> Mick.
>> 
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org 
>> 
>> For additional commands, e-mail: dev-h...@cassandra.apache.org 
>> 
>> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org 
> 
> For additional commands, e-mail: dev-h...@cassandra.apache.org 
> 

Re: GitHub PR ticket spam

[Stefan Podkowinski]

+1 for worklog option

Here's an example ticket from Arrow, where they seem to be using the
same approach:
https://issues.apache.org/jira/browse/ARROW-2583


On 05.08.2018 09:56, Mick Semb Wever wrote:
>> I find this a bit annoying while subscribed to commits@,
>> especially since we created pr@ for these kind of messages. Also I don't
>> really see any value in mirroring all github comments to the ticket.
> 
> 
> I agree with you Stefan. It makes the jira tickets quite painful to read. And 
> I tend to make comments on the commits rather than the PRs so to avoid 
> spamming back to the jira ticket.
> 
> But the linking to the PR is invaluable. And I can see Ariel's point about a 
> chronological historical archive.
> 
> 
>> Ponies would be for this to be mirrored to a tab 
>> separate from comments in JIRA.
> 
> 
> Ariel, that would be the the "worklog" option.
> https://reference.apache.org/pmc/github
> 
> If this works for you, and others, I can open a INFRA to switch to worklog.
> wdyt?
> 
> 
> Mick.
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org
> For additional commands, e-mail: dev-h...@cassandra.apache.org
> 

-
To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org
For additional commands, e-mail: dev-h...@cassandra.apache.org

Re: GitHub PR ticket spam

[Nate McCall]

I'd be fine with putting this traffic through as 'worklog' - good call, Mick!

On Sun, Aug 5, 2018 at 7:56 PM, Mick Semb Wever  wrote:
>> I find this a bit annoying while subscribed to commits@,
>> especially since we created pr@ for these kind of messages. Also I don't
>> really see any value in mirroring all github comments to the ticket.
>
>
> I agree with you Stefan. It makes the jira tickets quite painful to read. And 
> I tend to make comments on the commits rather than the PRs so to avoid 
> spamming back to the jira ticket.
>
> But the linking to the PR is invaluable. And I can see Ariel's point about a 
> chronological historical archive.
>
>
>> Ponies would be for this to be mirrored to a tab
>> separate from comments in JIRA.
>
>
> Ariel, that would be the the "worklog" option.
> https://reference.apache.org/pmc/github
>
> If this works for you, and others, I can open a INFRA to switch to worklog.
> wdyt?
>
>
> Mick.
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org
> For additional commands, e-mail: dev-h...@cassandra.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org
For additional commands, e-mail: dev-h...@cassandra.apache.org

Re: GitHub PR ticket spam

[Mick Semb Wever]

> I find this a bit annoying while subscribed to commits@,
> especially since we created pr@ for these kind of messages. Also I don't
> really see any value in mirroring all github comments to the ticket.


I agree with you Stefan. It makes the jira tickets quite painful to read. And I 
tend to make comments on the commits rather than the PRs so to avoid spamming 
back to the jira ticket.

But the linking to the PR is invaluable. And I can see Ariel's point about a 
chronological historical archive.


> Ponies would be for this to be mirrored to a tab 
> separate from comments in JIRA.


Ariel, that would be the the "worklog" option.
https://reference.apache.org/pmc/github

If this works for you, and others, I can open a INFRA to switch to worklog.
wdyt?


Mick.

-
To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org
For additional commands, e-mail: dev-h...@cassandra.apache.org

Re: GitHub PR ticket spam

[dinesh.jo...@yahoo.com.INVALID]

It is useful to have a historical record. However, it could definitely be 
better (huge diffs are pointless).
Thanks,
Dinesh 

On Monday, July 30, 2018, 1:27:26 AM PDT, Stefan Podkowinski 
 wrote:  
 
 Looks like we had some active PRs recently to discuss code changes in
detail on GitHub, which I think is something we agreed is perfectly
fine, in addition to the usual Jira ticket.

What bugs me a bit is that for some reasons any comments on the PR would
be posted to the Jira ticket as well. I'm not sure what would be the
exact reason for this, I guess it's because the PR is linked in the
ticket? I find this a bit annoying while subscribed to commits@,
especially since we created pr@ for these kind of messages. Also I don't
really see any value in mirroring all github comments to the ticket.
#14556 is a good example how you could end up with tons of unformatted
code in the ticket that will also mess up search in jira. Does anyone
think this is really useful, or can we stop linking the PR in the future
(at least for highly active PRs)?


-
To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org
For additional commands, e-mail: dev-h...@cassandra.apache.org

  

Re: GitHub PR ticket spam

[Ariel Weisberg]

Hi,

I really like having it mirrored. I would not be in favor of eliminating 
automated mirroring. What we are seeing is that removing the pain of commenting 
in JIRA is encouraging people to converse more in finer detail. That's a good 
thing.

I have also seen the pain of how various github workflows hide PRs. Rebasing, 
squashing, multiple branches, all of these can obfuscate the history of a 
review. So mirroring stuff to JIRA still makes sense to me as it's easier to 
untangle what happened in chronological order.

I think reducing verbosity to not include diffs is good. Especially if it 
contains a link to the comment. I do like being able to see the diff in JIRA 
(context switching bad) I just don't like to see it mixed in with regular 
comments. Ponies would be for this to be mirrored to a tab separate from 
comments in JIRA.

Regards,
Ariel

On Mon, Jul 30, 2018, at 1:25 PM, dinesh.jo...@yahoo.com.INVALID wrote:
> It is useful to have a historical record. However, it could definitely 
> be better (huge diffs are pointless).
> Thanks,
> Dinesh 
> 
> On Monday, July 30, 2018, 1:27:26 AM PDT, Stefan Podkowinski 
>  wrote:  
>  
>  Looks like we had some active PRs recently to discuss code changes in
> detail on GitHub, which I think is something we agreed is perfectly
> fine, in addition to the usual Jira ticket.
> 
> What bugs me a bit is that for some reasons any comments on the PR would
> be posted to the Jira ticket as well. I'm not sure what would be the
> exact reason for this, I guess it's because the PR is linked in the
> ticket? I find this a bit annoying while subscribed to commits@,
> especially since we created pr@ for these kind of messages. Also I don't
> really see any value in mirroring all github comments to the ticket.
> #14556 is a good example how you could end up with tons of unformatted
> code in the ticket that will also mess up search in jira. Does anyone
> think this is really useful, or can we stop linking the PR in the future
> (at least for highly active PRs)?
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org
> For additional commands, e-mail: dev-h...@cassandra.apache.org
> 
>   

-
To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org
For additional commands, e-mail: dev-h...@cassandra.apache.org

Re: GitHub PR ticket spam

[Benedict Elliott Smith]

I agree this is a mess.  I think we have previously taken the view that JIRA 
should be the permanent record of discussion, and that as such the git 
conversation should be duplicated there.

However, I think it would be better for JIRA to get a summary of important 
discussions, by one of the participants, not an illegible duplication of a page 
of code diffs attached to every one line nit comment.


> On 30 Jul 2018, at 09:27, Stefan Podkowinski  wrote:
> 
> Looks like we had some active PRs recently to discuss code changes in
> detail on GitHub, which I think is something we agreed is perfectly
> fine, in addition to the usual Jira ticket.
> 
> What bugs me a bit is that for some reasons any comments on the PR would
> be posted to the Jira ticket as well. I'm not sure what would be the
> exact reason for this, I guess it's because the PR is linked in the
> ticket? I find this a bit annoying while subscribed to commits@,
> especially since we created pr@ for these kind of messages. Also I don't
> really see any value in mirroring all github comments to the ticket.
> #14556 is a good example how you could end up with tons of unformatted
> code in the ticket that will also mess up search in jira. Does anyone
> think this is really useful, or can we stop linking the PR in the future
> (at least for highly active PRs)?
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org
> For additional commands, e-mail: dev-h...@cassandra.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org
For additional commands, e-mail: dev-h...@cassandra.apache.org

GitHub PR ticket spam

[Stefan Podkowinski]

Looks like we had some active PRs recently to discuss code changes in
detail on GitHub, which I think is something we agreed is perfectly
fine, in addition to the usual Jira ticket.

What bugs me a bit is that for some reasons any comments on the PR would
be posted to the Jira ticket as well. I'm not sure what would be the
exact reason for this, I guess it's because the PR is linked in the
ticket? I find this a bit annoying while subscribed to commits@,
especially since we created pr@ for these kind of messages. Also I don't
really see any value in mirroring all github comments to the ticket.
#14556 is a good example how you could end up with tons of unformatted
code in the ticket that will also mess up search in jira. Does anyone
think this is really useful, or can we stop linking the PR in the future
(at least for highly active PRs)?


-
To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org
For additional commands, e-mail: dev-h...@cassandra.apache.org