Re: [DISCUSS] Removing support for java 8

2022-09-02 Thread Josh McKenzie
+1 on removing JDK8 support from trunk. On Wed, Aug 31, 2022, at 12:07 PM, David Capwell wrote: > +1 to remove from trunk > >> On Aug 30, 2022, at 7:54 PM, Caleb Rackliffe >> wrote: >> >> +1 on removing 8 for trunk >> >> On Tue, Aug 30, 2022 at 2:42 PM Jon Haddad >> wrote: >>> +1 to

Re: [DISCUSS] Removing support for java 8

2022-08-31 Thread David Capwell
+1 to remove from trunk > On Aug 30, 2022, at 7:54 PM, Caleb Rackliffe wrote: > > +1 on removing 8 for trunk > > On Tue, Aug 30, 2022 at 2:42 PM Jon Haddad > wrote: > +1 to removal of 8 in trunk. > > On 2022/08/29 20:09:55 Blake Eggleston wrote: > > Hi all,

Re: [DISCUSS] Removing support for java 8

2022-08-30 Thread Caleb Rackliffe
+1 on removing 8 for trunk On Tue, Aug 30, 2022 at 2:42 PM Jon Haddad wrote: > +1 to removal of 8 in trunk. > > On 2022/08/29 20:09:55 Blake Eggleston wrote: > > Hi all, I wanted to propose removing jdk8 support for 4.1. Active > support ended back in March of this year, and I believe the

Re: [DISCUSS] Removing support for java 8

2022-08-30 Thread Jon Haddad
+1 to removal of 8 in trunk. On 2022/08/29 20:09:55 Blake Eggleston wrote: > Hi all, I wanted to propose removing jdk8 support for 4.1. Active support > ended back in March of this year, and I believe the community has built > enough confidence in java 11 to make it an uncontroversial change

Re: [DISCUSS] Removing support for java 8

2022-08-30 Thread Brad
+1 on removing jdk8. We should also remove python 3.6 (EOL 12/21) on trunk at the same time. On Mon, Aug 29, 2022 at 9:40 PM Blake Eggleston wrote: > Sorry, I meant trunk, not 4.1 :) > > > On Aug 29, 2022, at 1:09 PM, Blake Eggleston > wrote: > > > > Hi all, I wanted to propose removing jdk8

Re: [DISCUSS] Removing support for java 8

2022-08-30 Thread Benjamin Lerer
I seem to recall some discussion about the fact that we took some shortcuts when introducing java11 support. Before removing java8 support we should probably make sure that we have cleaned those things. My understanding was that it would be part of the work related to adding support for java 17

Re: [DISCUSS] Removing support for java 8

2022-08-30 Thread Mick Semb Wever
On Mon, 29 Aug 2022 at 23:01, Brandon Williams wrote: > +1 for removing it when we add 17, to avoid making extra work. > +1 on that^

Re: [DISCUSS] Removing support for java 8

2022-08-29 Thread Blake Eggleston
Let me look into how much work it would take to get accord building with jdk8, that may create the least amount of work for everyone involved. > On Aug 29, 2022, at 2:42 PM, Ekaterina Dimitrova > wrote: > > We will need also Jenkins, cassandra-builds. We need to add also j11 upgrade > tests

Re: [DISCUSS] Removing support for java 8

2022-08-29 Thread Ekaterina Dimitrova
We will need also Jenkins, cassandra-builds. We need to add also j11 upgrade tests and fix some other inconsistencies what jobs we run. I have it on my list and some things partially ready. And I am sure I am missing something. As I said in Slack, I am not against, just trying to be optimal and

Re: [DISCUSS] Removing support for java 8

2022-08-29 Thread Brandon Williams
Off the top of my head I know all the packages are built with java8 right now, so those tests would fail. I don't think there's any of it that is too difficult, it's just going to be a lot of little things that are probably easier to do in one pass instead of two. Kind Regards, Brandon On Mon,

Re: [DISCUSS] Removing support for java 8

2022-08-29 Thread Blake Eggleston
Can you say some more about what extra work you expect removing jdk8 to cause? I'd expect removing jdk8 to be mostly subtractive (from build.xml and circleci confs), and jdk17 support to be mostly additive. We're getting ready to merge the first set of accord integration patches, and the

Re: [DISCUSS] Removing support for java 8

2022-08-29 Thread Brandon Williams
+1 for removing it when we add 17, to avoid making extra work. Kind Regards, Brandon On Mon, Aug 29, 2022 at 3:40 PM Blake Eggleston wrote: > > Sorry, I meant trunk, not 4.1 :) > > > On Aug 29, 2022, at 1:09 PM, Blake Eggleston wrote: > > > > Hi all, I wanted to propose removing jdk8 support

Re: [DISCUSS] Removing support for java 8

2022-08-29 Thread Blake Eggleston
Yes I'd seen the 11+17 thread, but didn't see anything about an explicit jdk8 removal (ie: removal from CI etc). Ekaterina informed me there was an earlier thread covering that though > On Aug 29, 2022, at 1:09 PM, Blake Eggleston wrote: > > Hi all, I wanted to propose removing jdk8 support

Re: [DISCUSS] Removing support for java 8

2022-08-29 Thread Francisco Guerrero
+1 (nb) on removing java8 support from trunk. On 2022/08/29 20:42:18 "J. D. Jordan" wrote: > +1 for removing on trunk. Pretty sure we already discussed that in the Java > 17 thread? That trunk will move to 11+17? > > > On Aug 29, 2022, at 3:40 PM, Blake Eggleston wrote: > > > > Sorry, I

Re: [DISCUSS] Removing support for java 8

2022-08-29 Thread J. D. Jordan
+1 for removing on trunk. Pretty sure we already discussed that in the Java 17 thread? That trunk will move to 11+17? > On Aug 29, 2022, at 3:40 PM, Blake Eggleston wrote: > > Sorry, I meant trunk, not 4.1 :) > >> On Aug 29, 2022, at 1:09 PM, Blake Eggleston wrote: >> >> Hi all, I wanted

Re: [DISCUSS] Removing support for java 8

2022-08-29 Thread Blake Eggleston
Sorry, I meant trunk, not 4.1 :) > On Aug 29, 2022, at 1:09 PM, Blake Eggleston wrote: > > Hi all, I wanted to propose removing jdk8 support for 4.1. Active support > ended back in March of this year, and I believe the community has built > enough confidence in java 11 to make it an

[DISCUSS] Removing support for java 8

2022-08-29 Thread Blake Eggleston
Hi all, I wanted to propose removing jdk8 support for 4.1. Active support ended back in March of this year, and I believe the community has built enough confidence in java 11 to make it an uncontroversial change for our next major release. Let me know what you think. Thanks, Blake