Re: [DISSCUSS] Access to JDK internals only after dev mailing list consensus?

2022-11-10 Thread Ekaterina Dimitrova
4, 2022 at 3:51 PM > *To: *"dev@cassandra.apache.org" > *Subject: *RE: [EXTERNAL][DISSCUSS] Access to JDK internals only after > dev mailing list consensus? > > > > *CAUTION*: This email originated from outside of the organization. Do not > click links or open atta

Re: [DISSCUSS] Access to JDK internals only after dev mailing list consensus?

2022-11-08 Thread Josh McKenzie
; *To: *"dev@cassandra.apache.org" > *Subject: *RE: [EXTERNAL][DISSCUSS] Access to JDK internals only after dev > mailing list consensus? > > *CAUTION*: This email originated from outside of the organization. Do not > click links or open attachments unless you can confirm

Re: [DISSCUSS] Access to JDK internals only after dev mailing list consensus?

2022-11-07 Thread Chen-Becker, Derek
g" Subject: RE: [EXTERNAL][DISSCUSS] Access to JDK internals only after dev mailing list consensus? CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.  I finally got th

Re: [DISSCUSS] Access to JDK internals only after dev mailing list consensus?

2022-11-07 Thread Claude Warren, Jr via dev
This change looks good to me. It is clear and concise. On Fri, Nov 4, 2022 at 9:50 PM Ekaterina Dimitrova wrote: >  > > I finally got the chance to put down a proposal for a section at the end > of the Cassandra Code Style document. > Please help a fellow non-native speaker and definitely not

Re: [DISSCUSS] Access to JDK internals only after dev mailing list consensus?

2022-11-04 Thread Ekaterina Dimitrova
 I finally got the chance to put down a proposal for a section at the end of the Cassandra Code Style document. Please help a fellow non-native speaker and definitely not a writer with some constructive criticism. :-) My proposal is in this commit -

Re: [DISSCUSS] Access to JDK internals only after dev mailing list consensus?

2022-09-09 Thread Ekaterina Dimitrova
Hi everyone, Seems to me that people will be fine with heads up on the mailing list and details on tickets? Plus update of the Code Style to add a point around that, as suggested. I will leave this thread open a few more days and if there are no objections I will continue with documenting it.

Re: [DISSCUSS] Access to JDK internals only after dev mailing list consensus?

2022-09-02 Thread Ekaterina Dimitrova
Git and jira , nothing specific On Fri, 2 Sep 2022 at 12:51, Derek Chen-Becker wrote: > I think it's fine to state it explicitly rather than making it an > assumption. Are we tracking any usage of internals in the codebase > currently? > > Cheers, > > Derek > > On Fri, Sep 2, 2022 at 6:30 AM

Re: [DISSCUSS] Access to JDK internals only after dev mailing list consensus?

2022-09-02 Thread Derek Chen-Becker
I think it's fine to state it explicitly rather than making it an assumption. Are we tracking any usage of internals in the codebase currently? Cheers, Derek On Fri, Sep 2, 2022 at 6:30 AM Ekaterina Dimitrova wrote: > > > “ A quick heads up to the dev list with the jira would be sufficient

Re: [DISSCUSS] Access to JDK internals only after dev mailing list consensus?

2022-09-02 Thread Ekaterina Dimitrova
“ A quick heads up to the dev list with the jira would be sufficient for anybody interested in discussing it further to comment on the jira.” Agreed, I did’t mean voting but more or less we have the lazy consensus or sharing concerns. Discussing them on a ticket should be enough but it needs to

Re: [DISSCUSS] Access to JDK internals only after dev mailing list consensus?

2022-09-01 Thread Dinesh Joshi
Personally not opposed to this. However, this is something that should be vetted closely by the reviewers. Unless absolutely needed we should avoid accessing the internals. Folks on this project should understand why. We can make the dangers of this explicit in our contributor documentation.

Re: [DISSCUSS] Access to JDK internals only after dev mailing list consensus?

2022-09-01 Thread Erick Ramirez
+1 to more visibility. What examples of JDK internals access did you have in mind? I was just trying to think of some practical application where this would apply. Cheers!

Re: [DISSCUSS] Access to JDK internals only after dev mailing list consensus?

2022-09-01 Thread Benedict
I’m not opposed to this, although I think there is less need for it. Do you have an example of where you think this policy could have resulted in a different outcome? > On 1 Sep 2022, at 16:31, Ekaterina Dimitrova wrote: > > Hi everyone, > > Some time ago we added a note to the project

[DISSCUSS] Access to JDK internals only after dev mailing list consensus?

2022-09-01 Thread Ekaterina Dimitrova
Hi everyone, Some time ago we added a note to the project Cassandra Code Style: “New dependencies should not be included without community consensus first being obtained via a [DISCUSS] thread on the dev@cassandra.apache.org mailing list” I would like to suggest also to add a point around