[GitHub] cassandra pull request #79: Correct Spelling Errors in JavaDoc for IEndPoint...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cassandra/pull/79


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cassandra pull request #79: Correct Spelling Errors in JavaDoc for IEndPoint...

[michaelsembwever]

Github user michaelsembwever commented on a diff in the pull request:

https://github.com/apache/cassandra/pull/79#discussion_r86710443
  
--- Diff: src/java/org/apache/cassandra/locator/IEndpointSnitch.java ---
@@ -30,12 +30,12 @@
 public interface IEndpointSnitch
 {
 /**
- * returns a String repesenting the rack this endpoint belongs to
+ * returns a String representing the rack this endpoint belongs to
  */
 public String getRack(InetAddress endpoint);
 
 /**
- * returns a String representing the datacenter this endpoint belongs 
to
+ * returns a String representing the data center this endpoint belongs 
to
--- End diff --

I don't think this is warranted.
 `datacenter` is the more popular term within the repository than `data 
center`

```
cassandra-git (trunk) $ find . -type f -exec grep -l "datacenter" {} \; | 
wc -l
98
cassandra-git (trunk) $ find . -type f -exec grep -l "data center" {} \; | 
wc -l
56
```



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cassandra pull request #79: Correct Spelling Errors in JavaDoc for IEndPoint...

[michaelsembwever]

Github user michaelsembwever commented on a diff in the pull request:

https://github.com/apache/cassandra/pull/79#discussion_r86710377
  
--- Diff: src/java/org/apache/cassandra/locator/IEndpointSnitch.java ---
@@ -30,12 +30,12 @@
 public interface IEndpointSnitch
 {
 /**
- * returns a String repesenting the rack this endpoint belongs to
+ * returns a String representing the rack this endpoint belongs to
--- End diff --

Thanks for spotting and patching this!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cassandra pull request #79: Correct Spelling Errors in JavaDoc for IEndPoint...

[cmlicata]

GitHub user cmlicata opened a pull request:

https://github.com/apache/cassandra/pull/79

Correct Spelling Errors in JavaDoc for IEndPointSnitch

Addresses issue 
[CASSANDRA-12855](https://issues.apache.org/jira/browse/CASSANDRA-12855).

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cmlicata/cassandra 12855-trunk

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cassandra/pull/79.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #79


commit fcc1df484d00ffad19b280f4cef9d07f2dd6b70d
Author: Christopher Licata (xle012) 
Date:   2016-10-28T13:02:23Z

correct JavaDoc in IEndPointSnitch




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---