Re: [proposal] Introduce AssertJ in test framework

> (4. potentially migrating other existing tests to AssertJ in the long term) Highest value conversions would probably be assertTrue/False() assertions as I believe those offer the least feedback on failure. I would imagine that exception assertions would follow that especially when leaning on @T

Re: [proposal] Introduce AssertJ in test framework

Hi, Once you get to know assertJ, it's impossible to go back to basic > assertions of JUnit Definitely with you on that :) Great to see people are excited about this, thanks for the responses. Given the positive feedback I have created CASSANDRA-15631

Re: [proposal] Introduce AssertJ in test framework

Strong +1 here. Many of you know I'm a C# / LINQ junkie though. ;) On Tue, Mar 10, 2020 at 3:55 PM DuyHai Doan wrote: > Definitely +1 > > Coding in Java every day, I can't write test without assertJ. Once you get > to know assertJ, it's impossible to go back to basic assertions of JUnit > that f

Re: [proposal] Introduce AssertJ in test framework

Definitely +1 Coding in Java every day, I can't write test without assertJ. Once you get to know assertJ, it's impossible to go back to basic assertions of JUnit that feels really boilerplate On Tue, Mar 10, 2020 at 8:53 PM Jordan West wrote: > If it encourages more and higher quality test w

Re: [proposal] Introduce AssertJ in test framework

If it encourages more and higher quality test writing +1 (nb). Also, low risk given it’s a test dep. Using QuickTheories as an example, merging it with a new or updated test could be a good way to get it merged Jordan On Tue, Mar 10, 2020 at 10:33 AM Benjamin Lerer wrote: > +1 > > On Tue, Mar

Re: [proposal] Introduce AssertJ in test framework

+1 On Tue, Mar 10, 2020 at 6:18 PM Jon Haddad wrote: > I've used assertj in a lot of projects, I prefer it by a wide margin over > using only junit. > > On Tue, Mar 10, 2020 at 9:45 AM David Capwell wrote: > > > +1 from me > > > > In CASSANDRA-15564 I build my own assert chain to make the tests

Re: [proposal] Introduce AssertJ in test framework

I've used assertj in a lot of projects, I prefer it by a wide margin over using only junit. On Tue, Mar 10, 2020 at 9:45 AM David Capwell wrote: > +1 from me > > In CASSANDRA-15564 I build my own assert chain to make the tests cleaner; > did it since assertj wasn't there. > > On Tue, Mar 10, 202

Re: [proposal] Introduce AssertJ in test framework

+1 from me In CASSANDRA-15564 I build my own assert chain to make the tests cleaner; did it since assertj wasn't there. On Tue, Mar 10, 2020, 9:28 AM Kevin Gallardo wrote: > I would like to propose adding AssertJ as > a test dependency and therefore have it avai

[proposal] Introduce AssertJ in test framework

I would like to propose adding AssertJ as a test dependency and therefore have it available for writing unit/distributed/any test assertions. In addition to the examples mentioned on the AssertJ docs page (allows to do elaborate and comprehensible assertions on Col