Re: Moving Semver4j from test to main dependencies
+1 > On Dec 15, 2023, at 7:35 PM, Mick Semb Wever wrote: > > > >> I'd like to add Semver4j to the production dependencies. It is currently on >> the test classpath. The library is pretty lightweight, licensed with MIT and >> has no transitive dependencies. >> >> We need to represent the kernel version somehow in CASSANDRA-19196 and >> Semver4j looks as the right tool for it. Maybe at some point we can replace >> our custom implementation of CassandraVersion as well. > > > I'm +1 on both counts. > > But IMO you need to include those that were involved in this past discussion > that touched on the use of this library: > https://lists.apache.org/thread/zz3x1zl1lo8rkqpf0cl992y6fsy4r9gc
Re: Moving Semver4j from test to main dependencies
I'd like to add Semver4j to the production dependencies. It is currently on > the test classpath. The library is pretty lightweight, licensed with MIT > and has no transitive dependencies. > > We need to represent the kernel version somehow in CASSANDRA-19196 and > Semver4j looks as the right tool for it. Maybe at some point we can replace > our custom implementation of CassandraVersion as well. > I'm +1 on both counts. But IMO you need to include those that were involved in this past discussion that touched on the use of this library: https://lists.apache.org/thread/zz3x1zl1lo8rkqpf0cl992y6fsy4r9gc
Re: Moving Semver4j from test to main dependencies
+1 On Fri, Dec 15, 2023, at 1:29 PM, Derek Chen-Becker wrote: > +1 > > Semver4j seems reasonable to me. I looked through the code and it's > relatively easy to understand. I'm not sure how easy it would be to replace > CassandraVersion, but that's not an immediate concern I guess. > > Cheers, > > Derek > > On Fri, Dec 15, 2023 at 2:56 AM Jacek Lewandowski > wrote: >> Hi, >> >> I'd like to add Semver4j to the production dependencies. It is currently on >> the test classpath. The library is pretty lightweight, licensed with MIT and >> has no transitive dependencies. >> >> We need to represent the kernel version somehow in CASSANDRA-19196 and >> Semver4j looks as the right tool for it. Maybe at some point we can replace >> our custom implementation of CassandraVersion as well. >> >> Thanks, >> - - -- --- - - >> Jacek Lewandowski > > > -- > +---+ > | Derek Chen-Becker | > | GPG Key available at https://keybase.io/dchenbecker and | > | https://pgp.mit.edu/pks/lookup?search=derek%40chen-becker.org | > | Fngrprnt: EB8A 6480 F0A3 C8EB C1E7 7F42 AFC5 AFEE 96E4 6ACC | > +---+ >
Re: Moving Semver4j from test to main dependencies
+1 Semver4j seems reasonable to me. I looked through the code and it's relatively easy to understand. I'm not sure how easy it would be to replace CassandraVersion, but that's not an immediate concern I guess. Cheers, Derek On Fri, Dec 15, 2023 at 2:56 AM Jacek Lewandowski < lewandowski.ja...@gmail.com> wrote: > Hi, > > I'd like to add Semver4j to the production dependencies. It is currently > on the test classpath. The library is pretty lightweight, licensed with MIT > and has no transitive dependencies. > > We need to represent the kernel version somehow in CASSANDRA-19196 and > Semver4j looks as the right tool for it. Maybe at some point we can replace > our custom implementation of CassandraVersion as well. > > Thanks, > - - -- --- - - > Jacek Lewandowski > -- +---+ | Derek Chen-Becker | | GPG Key available at https://keybase.io/dchenbecker and | | https://pgp.mit.edu/pks/lookup?search=derek%40chen-becker.org | | Fngrprnt: EB8A 6480 F0A3 C8EB C1E7 7F42 AFC5 AFEE 96E4 6ACC | +---+
Moving Semver4j from test to main dependencies
Hi, I'd like to add Semver4j to the production dependencies. It is currently on the test classpath. The library is pretty lightweight, licensed with MIT and has no transitive dependencies. We need to represent the kernel version somehow in CASSANDRA-19196 and Semver4j looks as the right tool for it. Maybe at some point we can replace our custom implementation of CassandraVersion as well. Thanks, - - -- --- - - Jacek Lewandowski
