Re: Removing 2-phase compaction question

2012-11-30 Thread Sylvain Lebresne
I'm finding myself modifying row serialization stuff in ColumnFamilySerializer, RowIndexEntry, SSTableReader/Writer, SimpleSliceReader, and others. That mostly sound about right. As said in the ticket, if we stop writing the size at the beginning of the rows, we need to have marker of the end

Re: Removing 2-phase compaction question

2012-11-30 Thread Jason Brown
Sylvain, Thanks for the feedback! You're probably right about the RIE, but as this is my first 'really deep' ticket into the bowels of c*, I'm learning the role/purpose of everything as I'm going. As for the WIP branch, I may take the community up on that :). Thanks, -Jason On Fri, Nov 30,

Removing 2-phase compaction question

2012-11-29 Thread Jason Brown
Hi all, I'm working on 4180 (https://issues.apache.org/jira/browse/CASSANDRA-4180), and I need a little help. In the ticket. we're removing the rest of the row header (size in bytes and column count) after the row index was moved out ( https://issues.apache.org/jira/browse/CASSANDRA-2319). Row